| *** tpb has joined #freeorion | 00:00 | |
| *** VargaD has quit IRC | 00:47 | |
| *** lethu has quit IRC | 03:43 | |
| *** lethu has joined #freeorion | 03:55 | |
| *** lethu has joined #freeorion | 03:55 | |
| *** STalKer-Y has joined #freeorion | 04:53 | |
| *** STalKer-X has quit IRC | 04:53 | |
| *** StrangerDanger has joined #freeorion | 05:34 | |
| *** gvdm has joined #freeorion | 07:20 | |
| GeofftheMedio | gvdm: ResourceCenterChangedSignal is a signal, not a regular function. it has no definition in ResourceCenter, but instead is connected to other functions by GG::Connect calls. | 07:28 |
|---|---|---|
| gvdm | where would I see these GG::Connect calls? | 07:28 |
| GeofftheMedio | lots of places | 07:28 |
| *** tpb has joined #freeorion | 07:32 | |
| gvdm | I'm basically trying to track down where the focus target meter is set and where all the other target meters are set to 0 | 07:32 |
| gvdm | ResourceCenter::SetFocus | 07:33 |
| gvdm | is the closest I can find | 07:33 |
| GeofftheMedio | SetFocus has nothing to do with meter values | 07:33 |
| gvdm | I imagine that ResourceCenter::Reset() is called before making the focus meters target set to a value (modified by effects) | 07:34 |
| GeofftheMedio | Meter values are set mainly by effects. When calculating target meter values, they are all reset to 0, then effects applied to calculate their value. | 07:34 |
| gvdm | right, so where would I find this? | 07:34 |
| GeofftheMedio | no; Reset is used when starving / removing player ownership of a planet | 07:34 |
| gvdm | quote: they are all reset to 0 | 07:34 |
| gvdm | right | 07:34 |
| gvdm | and ResourceCenter::ResourceCenterResetTargetMaxUnpairedMeters()? | 07:35 |
| gvdm | could I add some comments to these functions? | 07:35 |
| GeofftheMedio | there's not much to comment about in that function | 07:36 |
| gvdm | more, like, when and why its called | 07:36 |
| gvdm | ResourceCenterPopGrowthProductionResearchPhase() has a descriptive enough name to not warrant that kind of comment | 07:37 |
| GeofftheMedio | the base UniverseObject class has such a comment for its ResetTargetMaxUnpairedMeters | 07:37 |
| GeofftheMedio | duplicating it for all derived classes (which ResourceCenter effectively, if not technically, is) | 07:37 |
| GeofftheMedio | is not necessary | 07:37 |
| gvdm | void UniverseObject::ResetTargetMaxUnpairedMeters() | 07:37 |
| gvdm | { GetMeter(METER_STEALTH)->ResetCurrent(); } | 07:37 |
| gvdm | ? | 07:37 |
| gvdm | no comment | 07:38 |
| GeofftheMedio | header | 07:38 |
| gvdm | ok, so that's called, and then effects are calculated? | 07:39 |
| GeofftheMedio | look at UpdateMeterEstimates in Universe | 07:40 |
| GeofftheMedio | and ApplyAllEffectsAndUpdateMeters | 07:41 |
| *** GeofftheMedio_ has joined #freeorion | 08:22 | |
| *** GeofftheMedio has quit IRC | 08:24 | |
| *** GeofftheMedio_ is now known as GeofftheMedio | 08:24 | |
| *** VargaD has joined #freeorion | 08:26 | |
| gvdm | ok | 09:05 |
| gvdm | so, i've been reading code for a bit now | 09:06 |
| gvdm | and, i still can't see where the differentiation between the focused and unfocused meters is made to set the target meters, unless the effects files check that, in which case, why the f am i reading c++? | 09:07 |
| GeofftheMedio | as I said, effects determine meter values | 09:07 |
| GeofftheMedio | I'm not sure why you're reading c++... presumably because of interest or bad assumptions? | 09:07 |
| gvdm | bit of both | 09:08 |
| gvdm | ok, so currently species.txt shows what happens to targets when they are focused, shouldn't there be a formula something along the lines of default_target = pop*x, focused_target = default_target*something | 09:15 |
| gvdm | right now its just focused_target=pop*something | 09:15 |
| GeofftheMedio | uh... no? | 09:15 |
| gvdm | hmm? | 09:16 |
| GeofftheMedio | it works as it works, not how you suggest. | 09:16 |
| gvdm | like, for food, default_target = pop*0.7, focused_target = default_target*2 | 09:16 |
| gvdm | well, currently, as just the focused target counts, when the meters are reset, they all go to DEFAULT_VALUE, which is 0 | 09:17 |
| GeofftheMedio | yes... | 09:17 |
| gvdm | so only the focused stat gets produced, resulting in a crappy startup and unbalanced empire when there are too few planets | 09:17 |
| GeofftheMedio | there are other bonuses to meters besides from focus / species | 09:18 |
| gvdm | yes, I was just thinking that | 09:18 |
| GeofftheMedio | but yes; you have to pick a particular focus, and can't do everything at first. this is itentional. | 09:18 |
| gvdm | ok, IMO, crappy economy setup | 09:19 |
| *** __alex has joined #freeorion | 09:19 | |
| gvdm | the insta death thing with colonies would also not have been such an issue if they produced a minimal (but not sufficient amount) of food while focusing industry | 09:20 |
| gvdm | that is, with blockade and supply lines | 09:20 |
| gvdm | focus should be taken into account after all the other effects I think, so species effect first, then modified by techs, then shuffled according to focus, ie non focused gets nerfed to the point where the planet is dependent on empire (but still produces) and focused makes planet exporting | 09:23 |
| gvdm | ok, but I now am busy for rest of day | 09:23 |
| gvdm | so, I see you all later | 09:23 |
| *** __alex has quit IRC | 09:28 | |
| *** dansan has quit IRC | 09:38 | |
| *** dansan has joined #freeorion | 09:38 | |
| *** __alex has joined #freeorion | 09:38 | |
| *** theTroy has joined #freeorion | 09:43 | |
| *** gvdm has quit IRC | 10:01 | |
| *** gvdm has joined #freeorion | 10:02 | |
| *** theTroy has quit IRC | 11:45 | |
| *** gvdm has quit IRC | 13:06 | |
| *** StrangerDanger has quit IRC | 14:40 | |
| *** VargaD has quit IRC | 14:47 | |
| *** lethu has quit IRC | 14:58 | |
| *** lethu has joined #freeorion | 14:59 | |
| *** lethu has joined #freeorion | 14:59 | |
| *** StrangerDanger has joined #freeorion | 15:00 | |
| *** lethu has quit IRC | 15:02 | |
| *** lethu has joined #freeorion | 15:03 | |
| *** lethu has joined #freeorion | 15:03 | |
| *** gvdm has joined #freeorion | 15:04 | |
| *** gvdm has quit IRC | 15:09 | |
| *** __alex has quit IRC | 16:24 | |
| *** theTroy has joined #freeorion | 17:21 | |
| *** VargaD has joined #freeorion | 17:54 | |
| *** neoneurone has joined #freeorion | 19:28 | |
| *** neoneurone has quit IRC | 21:12 | |
| *** StrangerDanger has quit IRC | 21:31 | |
Generated by irclog2html.py 2.5 by Marius Gedminas - find it at mg.pov.lt!