| *** tpb has joined #freeorion | 00:00 | |
| CIA-17 | FreeOrion: eleazzaar * r3956 /trunk/FreeOrion/default/data/art/icons/species/ (aerial-02.png floater-04.png insectoid-03.png): three new species icons. | 01:18 |
|---|---|---|
| *** tomboy64 has quit IRC | 01:59 | |
| *** bernardh has joined #freeorion | 03:47 | |
| *** STalKer-Y has quit IRC | 04:58 | |
| *** STalKer-X has joined #freeorion | 05:07 | |
| *** StrangerDanger has quit IRC | 06:23 | |
| *** bernardh has quit IRC | 09:34 | |
| *** bernardh has joined #freeorion | 09:47 | |
| *** bernardh has quit IRC | 10:35 | |
| *** bernardh has joined #freeorion | 10:47 | |
| *** keis has quit IRC | 11:31 | |
| *** keis has joined #freeorion | 11:43 | |
| *** Farmer_ has joined #freeorion | 12:04 | |
| *** tomboy64 has joined #freeorion | 12:44 | |
| *** Farmer_ has quit IRC | 12:49 | |
| keis | sup, i'm trying to compile freeorion (from svn) but I get link errors to some serialize templates | 13:38 |
| keis | any idea what could be going wrong? | 13:38 |
| keis | adding explicit instansiation with xml_(i|o)archive for System::serialize solved this for me | 14:17 |
| *** bernardh has quit IRC | 15:33 | |
| *** StrangerDanger has joined #freeorion | 16:07 | |
| *** StrangerDanger has quit IRC | 17:03 | |
| *** StrangerDanger has joined #freeorion | 17:03 | |
| *** tomboy64 has quit IRC | 19:23 | |
| *** tomboy64 has joined #freeorion | 19:27 | |
| GeofftheMedio | keis: what svn revision are you compiling? | 19:57 |
| GeofftheMedio | and on what OS / compiler? | 19:59 |
| GeofftheMedio | and could you post the full error output? | 19:59 |
| keis | umm, not really sure what rev.. latest I think | 19:59 |
| keis | with gcc-4.5.2 on gentoo | 20:00 |
| keis | r3956 | 20:00 |
| keis | http://paste.pocoo.org/show/328842/ | 20:02 |
| tpb | Title: Paste #328842 | LodgeIt! (at paste.pocoo.org) | 20:02 |
| GeofftheMedio | hmm. There have been a bunch of issues with serializing the System class | 20:34 |
| GeofftheMedio | usually it's just crashes during execution due to an "unregistered class" | 20:34 |
| GeofftheMedio | but that was fixed some time ago | 20:34 |
| GeofftheMedio | where did you need to add code to fix the template instatitiation issue? | 20:35 |
| keis | I did it in SerializeUniverse.cpp | 20:35 |
| keis | but what I did is not the proper way I guess | 20:36 |
| keis | svn diff http://paste.pocoo.org/show/328858/ | 20:36 |
| tpb | Title: Paste #328858 | LodgeIt! (at paste.pocoo.org) | 20:36 |
| GeofftheMedio | that looks reasonable... | 20:41 |
| GeofftheMedio | do you need both of those additions for it to link? | 20:42 |
| keis | yeah, did not work with only the first anyway | 20:43 |
| GeofftheMedio | hmm. well, I dunno why the System class creates so many problems with serialization. There's nothing particularly special about it besides the generic name, but that didn't seem to matter for some of the other problems | 20:45 |
| keis | I can't see why that would matter | 20:50 |
| keis | but then again I have read about 100 SLOC of freeorion :P | 20:50 |
| GeofftheMedio | I don't know how it would matter for a compile error, but it's possible that "System" was the same symbol name as something else, which could lead to linker errors... maybe? | 20:52 |
| GeofftheMedio | and for run-time, it's even more plausible that "system" would appear somewhere such that one part of the serialization engine thought it didn't need to automatically register a class, and then another part would break because of that... | 20:53 |
| GeofftheMedio | but it didn't seem to matter even when we changed the name of the class... so... I have no idea. | 20:54 |
| GeofftheMedio | it's just cursed apparently | 20:54 |
| keis | yeah, there's always that bit in a project that needs a /* here be dragons */ | 20:55 |
| GeofftheMedio | so, things seem to work fine after explicitly instatiating those templates, so I'll just commit it. thanks for reporting... | 20:58 |
| keis | np | 21:02 |
| CIA-17 | FreeOrion: geoffthemedio * r3957 /trunk/FreeOrion/ (msvc2010/src/Version.cpp util/SerializeUniverse.cpp): Added excplicit instantiation of System::serialize to fix reported link error with gcc 4.5.2. | 21:04 |
| *** bernardh has joined #freeorion | 22:14 | |
| *** tomboy64 has quit IRC | 22:56 | |
| *** tomboy64 has joined #freeorion | 23:00 | |
| CIA-17 | FreeOrion: geoffthemedio * r3958 /trunk/FreeOrion/ (3 files in 2 dirs): | 23:17 |
| CIA-17 | FreeOrion: -Fixed content parsing bug that was matching the "Target" part of | 23:17 |
| CIA-17 | FreeOrion: "TargetPopulation" as the separate "Target" condition, and then matching | 23:17 |
| CIA-17 | FreeOrion: "Population" as a separate condition in cases where "TargetPopulation" was one | 23:17 |
| CIA-17 | FreeOrion: of several conditions in an "And" condition. | 23:17 |
| CIA-17 | FreeOrion: -Fixed typo in eng_stringtable.txt. | 23:17 |
| CIA-17 | FreeOrion: -Commented out ValueRef debug output. | 23:17 |
| CIA-17 | FreeOrion: geoffthemedio * r3959 /trunk/FreeOrion/default/AI/ (7 files): AI scripts update by RgnadKzin. | 23:18 |
| *** tomboy64 has quit IRC | 23:42 | |
| CIA-17 | FreeOrion: geoffthemedio * r3960 /trunk/FreeOrion/ (7 files in 4 dirs): Removed OGDF code to replace with Lathanda's not-quite-finished but functional custom graph layout code. | 23:49 |
| CIA-17 | FreeOrion: geoffthemedio * r3961 /trunk/FreeOrion/msvc2008/FreeOrion/freeorion/freeorion.vcproj: OGDF -> Lathanda changes for MSVC 2008 project files. | 23:50 |
Generated by irclog2html.py 2.5 by Marius Gedminas - find it at mg.pov.lt!