| *** tpb has joined #freeorion | 00:00 | |
| *** mithro_ has joined #freeorion | 01:41 | |
| *** mithro has quit IRC | 01:53 | |
| *** mithro_ has quit IRC | 02:18 | |
| *** mithro_ has joined #freeorion | 02:18 | |
| *** mithro_ has quit IRC | 02:44 | |
| *** welterde has quit IRC | 04:13 | |
| *** welterde has joined #freeorion | 04:14 | |
| *** kroddnoMobil has joined #freeorion | 04:50 | |
| *** ChanServ sets mode: +o kroddnoMobil | 04:50 | |
| *** mithro_ has joined #freeorion | 04:52 | |
| *** kroddnoMobil has quit IRC | 05:25 | |
| *** mithro_ has quit IRC | 06:03 | |
| GeofftheMedio | kroddn: isn't most of of any_regular.hpp after the #include lines inside namespace adobe ? | 06:47 |
|---|---|---|
| kroddn | yes, but one header is namespace adobe::version_1 and in that namespace no "swap" is found | 07:40 |
| kroddn | you can see that if you fallow the error backtrace | 07:41 |
| GeofftheMedio | how does putting adobe:: before swap in a function that's already in the adobe namespace help, though? | 07:44 |
| kroddn | but I don't know if that is the right swap to use at this point | 07:44 |
| kroddn | There is no adobe::version_1::swap, so using adobe::swap seems to be the solution | 07:45 |
| kroddn | maybe its a compiler problem, but I don't want to install a non-default compiler on my freeorion chroot | 07:45 |
| GeofftheMedio | hmm. after making your change it still compiled file for me, but I don't know if it would affect how it works | 07:46 |
| kroddn | I don't understand it that good too | 07:47 |
| kroddn | but std::swap seems to be the wrong function at that point | 07:47 |
| GeofftheMedio | presumably there's a reason they wrote their own | 07:48 |
| kroddn | Have a look at GG/adobe/implementation/swap.hpp | 07:48 |
| kroddn | I don't relly understand what they do :-( | 07:49 |
| kroddn | I hope tzlaine will understand it and fix it the right way ;-) | 07:50 |
| GeofftheMedio | one can hope | 07:50 |
| kroddn | Interesting: http://www.informit.com/guides/content.aspx?g=cplusplus&seqNum=155 | 07:51 |
| tpb | <http://ln-s.net/3$5A> (at www.informit.com) | 07:51 |
| GeofftheMedio | guess that's why they just used the std::swap | 07:59 |
| kroddn | but why did they implement the adobe::swap then? | 08:01 |
| GeofftheMedio | they didn't ... it's just std::swap | 08:02 |
| GeofftheMedio | they did this to make the code look nice, apparently... | 08:02 |
| GeofftheMedio | "all code in namespace adobe that calls swap | 08:02 |
| GeofftheMedio | should call it unqualified. This is less cluttered than employing local using declaration" | 08:02 |
| GeofftheMedio | (from comment in swap.hpp) | 08:03 |
| kroddn | strange code around line 722 | 08:05 |
| GeofftheMedio | of? | 08:05 |
| kroddn | okay, then writing std::swap at this line should compile too | 08:06 |
| GeofftheMedio | doesn't it? | 08:06 |
| kroddn | didn't try | 08:06 |
| kroddn | you said that code is never used at all, so I just want to make it compile - I think its tzlaine to fix it correctly | 08:07 |
| GeofftheMedio | I said I don't think it's used | 08:08 |
| GeofftheMedio | at least in FreeOrion | 08:08 |
| GeofftheMedio | there's an example of some sort that uses it in GiGi itself, though | 08:08 |
| GeofftheMedio | but you don't really need that | 08:08 |
| *** welterde has quit IRC | 08:19 | |
| *** welterde has joined #freeorion | 08:31 | |
| *** kroddnoMobil has joined #freeorion | 08:32 | |
| *** ChanServ sets mode: +o kroddnoMobil | 08:32 | |
| *** kroddnoMobil has quit IRC | 08:50 | |
| *** hagish has joined #freeorion | 14:13 | |
| *** welterde has quit IRC | 18:26 | |
| *** welterde has joined #freeorion | 18:28 | |
| *** welterde has quit IRC | 18:31 | |
| *** welterde has joined #freeorion | 18:34 | |
| *** hagish has quit IRC | 19:17 | |
| *** mithro_ has joined #freeorion | 19:18 | |
| *** mithro_ is now known as mithro | 19:35 | |
| *** mithro_ has joined #freeorion | 19:59 | |
| *** mithro has quit IRC | 19:59 | |
| *** mithro_ has quit IRC | 21:20 | |
| *** mithro_ has joined #freeorion | 21:20 | |
| *** mithro_ is now known as mithro | 21:55 | |
Generated by irclog2html.py 2.5 by Marius Gedminas - find it at mg.pov.lt!