Thursday, 2019-03-07

*** tpb has joined #vtr-dev00:00
*** vtrbot has quit IRC04:34
*** vtrbot has joined #vtr-dev05:01
mithrokem_: There is an example of what the clang-format run output would look like at https://github.com/kgugala/vtr-verilog-to-routing/commit/bae35143d8728674b6941f3b11cfd23a469508c1#diff-ab03a6d043b974937b0bc52ea8b94eb917:57
tpbTitle: run code-format · kgugala/[email protected] · GitHub (at github.com)17:57
litghostkem_: Please re-open https://github.com/verilog-to-routing/vtr-verilog-to-routing/issues/485, as the issue does not go away even with more reasonable timing values19:06
tpbTitle: Issues · verilog-to-routing/vtr-verilog-to-routing · GitHub (at github.com)19:06
litghostkem_: In fact the routing graph generated by VPR also replicates the issue19:06
litghostkem_: And the timing input is basically from the VPR example arch19:07
kem_litghost: Fixing the timing values on the test case fixed the issue for me. But if there are examples with realistic delays which cause the same issue I can definitely re-open it.20:30
litghostkem_: Already attached a new graph20:31
kem_mithro: The formatting looks pretty good21:44
kem_mithro: There are a just couple things that look a little odd, such as inserting an extra space before c++-style comments and a couple places where multi-line conditions are a bit off21:46
mithrokem_: example?21:46
kem_mithro: can't figure out how to link to specific lines from that commit...21:48
mithrokem_: Just click on the line numbers and then copy the url?21:48
kem_mithro: doesn't seem to change the url21:49
mithrokem_: You looking at https://github.com/kgugala/vtr-verilog-to-routing/commit/bae35143d8728674b6941f3b11cfd23a469508c1#diff-cb6d86211fc138d5f2a87ba2ac745365L139 ?21:49
tpbTitle: run code-format · kgugala/[email protected] · GitHub (at github.com)21:49
kem_mithro: OK I missed the line number at the end of the commit id :)21:50
kem_mithro: Extra space before c++ comment https://github.com/kgugala/vtr-verilog-to-routing/commit/bae35143d8728674b6941f3b11cfd23a469508c1#diff-6f0adcb7b2f19840e79075d70401da42L9121:51
tpbTitle: run code-format · kgugala/[email protected] · GitHub (at github.com)21:51
mithrokem_: Ahh, I see21:51
kem_mithro: I'm not set on this one, but I still miss the indent around public/private (https://github.com/kgugala/vtr-verilog-to-routing/commit/bae35143d8728674b6941f3b11cfd23a469508c1#diff-1819e1ce829cfffbd9a42da54338b406L82)21:54
tpbTitle: run code-format · kgugala/[email protected] · GitHub (at github.com)21:54
kem_mithro: For single line if bodies I prefer them on the same line as the if or with braces (in the future avoids accidentally adding something that is indented to appear as part of the body but actually is not). For example: https://github.com/kgugala/vtr-verilog-to-routing/commit/bae35143d8728674b6941f3b11cfd23a469508c1#diff-31ec6c191fb261c72ad6804a23bf1a26L50421:56
tpbTitle: run code-format · kgugala/[email protected] · GitHub (at github.com)21:56
kem_mithro: Also some funny formatting with these multi-line expressions (https://github.com/kgugala/vtr-verilog-to-routing/commit/bae35143d8728674b6941f3b11cfd23a469508c1#diff-db8d7b991af7b9051a745c120f1ef2b0R510). I generally try to line up the operators at the left so it's easier to read.22:05
tpbTitle: run code-format · kgugala/[email protected] · GitHub (at github.com)22:05
mithrokem_: https://github.com/mithro/vtr-verilog-to-routing/commit/c353d7b4f8375c554b3b27efec56ee6e49f9206e22:08
tpbTitle: run code-format · mithro/[email protected] · GitHub (at github.com)22:08
mithrokem_: That uses an offset of -2 for the member private/public/protected labels22:08
mithrokem_: Was there a decision about how long lines should be?22:31

Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!