Monday, 2019-03-04

*** tpb has joined #vtr-dev00:00
elmskem_: I ran into the blif parsing being more restrictive than I think required. I'm curious about why the ID needs the two cases. I'd like to write a test case if I'm missing why starting with a digit needs to be treated differently. https://github.com/elmsfu/vtr-verilog-to-routing/commit/e2bfc126a7503a20eb52f82306510441aac6649719:31
tpbTitle: libblifparse: broaden allowed character set for Ids · elmsfu/[email protected] · GitHub (at github.com)19:31
kem_elms: I can't recall the reason it was written that way...19:38
kem_elms: Provided it doesn't cause any problems the change you linked definitely looks cleaner19:38
kem_elms: What I'd recommend is to try running the blifparse_test executable on all of the .blif files checked in the VTR repo to make sure we can still parse everything19:39
elmskem_: ok will do20:03
*** litghost_ has quit IRC22:03
*** litghost has joined #vtr-dev22:03
litghostI believe https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/473 is ready for review22:03
tpbTitle: Add metadata support to architecture and rr_graph XML. by litghost · Pull Request #473 · verilog-to-routing/vtr-verilog-to-routing · GitHub (at github.com)22:03
elmskem_: all files except one passes, but I think it failed before. https://github.com/verilog-to-routing/vtr-verilog-to-routing/blob/master/abc_with_bb_support/JAMIESON_TESTS/sample4.blif#L18 looks like a .blackbox directive that isn't properly formed, but I'm not that familiar with blif22:14
tpbTitle: vtr-verilog-to-routing/sample4.blif at master · verilog-to-routing/vtr-verilog-to-routing · GitHub (at github.com)22:14
kem_elms: Yeah that one looks malformed so not passing on it is OK22:20
kem_elms: If you want to submit a PR for that, it should go to: https://github.com/kmurray/libblifparse22:22
tpbTitle: GitHub - kmurray/libblifparse: Parsing library for BLIF netlists (at github.com)22:22
kem_elms: Once it's in there the subtree used to include the library in VTR can be updated22:22

Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!