Wednesday, 2017-06-28

*** tpb has joined #timvideos00:00
*** froztbyt1 is now known as froztbyte02:41
*** rohitksingh_work has joined #timvideos04:23
paddatrappermithro: thanks!04:36
*** tvCommitBot has joined #timvideos04:50
-tvCommitBot- [av-foss-stack] CarlFK pushed 1 new commit to master:
-tvCommitBot- av-foss-stack/master 1c1a172 Carl Karsten: testing veyepar04:50
*** tvCommitBot has left #timvideos04:50
*** sb0 has quit IRC06:50
*** tpb has joined #timvideos07:07
shenkiIshan_Bansal: when you're learning how to respond to code reviews I recommend going through each of the comments one by one07:24
shenkiIshan_Bansal: if you have fixed the issue that the review comment points out, then just reply 'Done'07:25
mithroI'll be around for an hour if you have questions07:31
Ishan_Bansalshenki : After fixing any issue how can I make it to review again. Should I push my code again in the pull request or simply commit it in my own repository.08:19
mithroIshan_Bansal: You push your commits to the branch you made the pull request from08:31
mithroIshan_Bansal: and then reply to the comments on the pull request08:31
Ishan_Bansalmithro  : got it.08:43
*** techman83 has quit IRC08:47
*** techman83 has joined #timvideos08:48
*** ChanServ sets mode: +v techman8308:48
*** techman83 has quit IRC08:50
*** techman83 has joined #timvideos08:54
*** ChanServ sets mode: +v techman8308:54
*** techman83 has quit IRC09:17
*** techman83 has joined #timvideos09:23
*** ChanServ sets mode: +v techman8309:23
mithroIshan_Bansal: normal comments will be placed near the place which needs fixing, but you should make sure you apply the same logic through out the rest of the code09:53
mithroIshan_Bansal: IE I'll only probably mention fixing indenting in one or two places, but you should fix it everywhere.09:54
mithroAnyway, heading out for the night09:54
paddatrappermithro: progress report up for you10:41
*** sb0 has joined #timvideos11:43
*** sb0 has quit IRC12:22
*** rohitksingh_work has quit IRC12:51
paddatrapperwell turns out my exam is tomorrow... So will try get things done tonight13:09
*** sb0 has joined #timvideos14:08
*** rohitksingh has joined #timvideos14:29
*** hyadez has quit IRC16:58
*** rohitksingh has quit IRC18:00
*** rohitksingh has joined #timvideos18:03
*** rohitksingh has quit IRC18:25
paddatrappermithro: those two PRs should be good now19:23
*** hyadez has joined #timvideos19:43
*** CarlFK has quit IRC23:40

Generated by 2.13.1 by Marius Gedminas - find it at!