Tuesday, 2017-06-27

*** tpb has joined #timvideos00:00
xfxfmithro: nah, getting working audio is totally more important than exams.  who likes exams?  :P00:59
tumbleweedexam time usually means lots of free time :)01:01
paddatrappermithro: my first exam is early tomorrow, so may be able to get it done tomorrow afternoon04:11
*** miselin has quit IRC05:14
*** miselin has joined #timvideos05:15
*** rohitksingh has joined #timvideos05:20
paddatrappermithro: ok never mind. My exam is tomorrow afternoon, so I doubt I'll be able to work on it before Thursday05:53
mithropaddatrapper: Okay, understand06:34
mithropaddatrapper: Are you going to make our meeting tomorrow?06:35
*** bjoern_ has joined #timvideos06:38
paddatrappermithro: tomorrow's Wednesday, isn't our meeting Thursday?06:49
mithroYes, I'm just confused :-P06:50
paddatrapperCool :) as long as today is not Wednesday!06:51
mithroIt is not06:54
*** rohitksingh has quit IRC06:58
*** rohitksingh_work has joined #timvideos07:57
*** rohitksingh_work has quit IRC08:28
*** rohitksingh_work has joined #timvideos08:28
*** rohitksingh_work has quit IRC08:29
mithroIshan_Bansal: Hi! I added a bunch of comments on your pull request09:14
mithroIshan_Bansal: I added a lot of comments, but that is normal on your first few!09:14
mithroIshan_Bansal: If you have any questions, please do poke me and I'll try and respond09:15
mithroIshan_Bansal: I've been coding for ~15 years and still get tonnes of comments when I send out my code at work too :-P09:16
mithroIshan_Bansal: See an example at https://codereview.chromium.org/2054763004/ :-P09:18
tpbTitle: Issue 2054763004: luci-go/common/dirwalk: Code for walking a directory tree efficiently - Code Review (at codereview.chromium.org)09:18
mithroshenki: FYI ^^09:18
shenkimithro: thank you!09:20
*** andi-m has joined #timvideos09:29
*** ivodd_ has joined #timvideos09:29
*** froztbyt1 has joined #timvideos09:30
mithropaddatrapper: FYI - I also put comments on your pull request at https://github.com/mithro/fx2lib-linux-headers/pull/1/files09:30
tpbTitle: Add string table generator by paddatrapper · Pull Request #1 · mithro/fx2lib-linux-headers · GitHub (at github.com)09:30
paddatrappermithro: thanks09:30
mithroOh wait09:31
mithroI forgot to publish them09:31
paddatrapperlol. That does help :)09:34
paddatrapperHopefully I'll be able to work on them later tonight09:34
*** Ishan_Bansal has quit IRC09:35
*** andi_m has quit IRC09:35
*** froztbyte has quit IRC09:35
*** ivodd has quit IRC09:35
*** Ishan_Bansal has joined #timvideos09:40
shenkiIshan_Bansal: i reading through all of mithro's comments, and once you've read them all address each of his comments in turn09:50
shenkiIshan_Bansal: where you're not sure what the comment means, or you disagree with the suggestion, please use the tool to publish your comments09:51
*** rohitksingh has joined #timvideos13:43
*** rohitksingh has quit IRC13:51
*** rohitksingh has joined #timvideos13:52
*** rohitksingh has quit IRC13:58
Ishan_Bansalshenki : sure14:57
Ishan_Bansalmithro : should I go through each of the comment one by one and than show the edited version of the code after each step.14:59
Ishan_Bansalmithro : Or I go through all of them at once.15:00
*** tsglove has quit IRC16:58
*** tsglove has joined #timvideos17:01
*** tsglove2 has joined #timvideos21:36
*** tsglove has quit IRC21:40
mithropaddatrapper: Good luck with the exams!22:06

Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!