Monday, 2015-05-04

*** tpb has joined #timvideos00:00
*** Joelw has quit IRC00:03
*** Joelw has joined #timvideos00:04
*** hyades has quit IRC00:09
*** Joelw has quit IRC00:34
*** Joelw has joined #timvideos00:36
mithroMaZderMind: yes I have a fix for that00:46
mithroMaZderMind: will try and look at your pull request today00:48
mithroMaZderMind: I also have a fix for your Ethernet problem. I don't want it to always be enabled because it increases the CPU load significantly00:58
mithroMaZderMind: I guess you are probably asleep now - but is there any area you'd like me to concentrate on reviewing - IE somewhere you are not confident is correct?01:29
mithroCarlFK: how are those debian packages going?02:45
CarlFKmithro: technically I made progress.  might be 1/2 way there.  let me wrap up a little PSF/PS1 evote install bug report and Ill give a better answer04:06
*** tvCommitBot has joined #timvideos04:52
tvCommitBot[streaming-system] mithro pushed 1 new commit to master: http://git.io/vJVUo04:52
tvCommitBotstreaming-system/master 9b66b53 Tim 'mithro' Ansell: Adding license information....04:52
*** tvCommitBot has left #timvideos04:52
*** Niharika has joined #timvideos05:03
*** hyades has joined #timvideos05:21
CarlFKevote PR created.05:26
CarlFKim helping :p05:26
CarlFKmithro: on packing.  I was told to follow this guide, and I am to here so far: https://www.debian.org/doc/manuals/maint-guide/modify.en.html05:30
tpbTitle: Chapter 3. Modifying the source (at www.debian.org)05:30
CarlFKI am not suck, just keep getting distacted.05:31
CarlFKif I do get stuck, I can go back to the local guy that told me to follow the guide.05:31
*** Niharika has quit IRC05:50
MaZderMindmithro: I think it would be best to review the actual tests so I did bot miss snything06:12
MaZderMindCarlFK: might want to chat with florolf in #voc on hackint, he does the packaging/jenkins06:12
CarlFKMaZderMind: it seems like it's grunt work that someone has to sit down and do06:25
mithroMaZderMind: morning!06:26
mithroMaZderMind: just about to take a look at that pull request now that I've finished the HDMI2USB production board review work06:27
MaZderMindcool :) have some questions regarding hdmi2usb, too, but first things first06:33
mithroMaZderMind: some of the tests in your int-tests-rewrite2 branch fail on my machine07:08
mithroMaZderMind: https://gist.github.com/mithro/e7d554f0efd772bda9a507:08
tpbTitle: gist:e7d554f0efd772bda9a5 (at gist.github.com)07:08
mithroMaZderMind: it looks like the scipy version installed on ubuntu trusty doesn't have the scipy.misc.imread function... -- 0.13.3-1build107:09
mithroWhich is a bit weird, because it is in the documentation at http://docs.scipy.org/doc/scipy-0.13.0/reference/generated/scipy.misc.imread.html07:10
tpbTitle: scipy.misc.imread SciPy v0.13.0 Reference Guide (at docs.scipy.org)07:10
mithroOh, it's because I'm missing the python3-pil package07:10
mithroMaZderMind: yay, they now pass - but I'm getting lint errors07:12
CarlFKMaZderMind: buttons: Cut and whatever it takes to switch streams.07:12
mithrohttps://www.irccloud.com/pastebin/9636oj3X07:13
tpbTitle: Pastebin | IRCCloud (at www.irccloud.com)07:13
CarlFK I think this is progresss:  dpkg-source: error: aborting due to unexpected upstream changes,07:21
CarlFK2.19, time for bed.07:21
*** CarlFK has quit IRC07:56
*** MaZderMind has quit IRC08:38
*** MaZderMind has joined #timvideos08:40
*** Niharika has joined #timvideos09:01
*** Niharika has quit IRC09:26
MaZderMindmithro: thank you for the review but all your comments are multiple days worth of work on the int-tests. As I stated I'll work on something more useful to our project. I'll see if I can change some mor small things but I won't add new tests atm. because I'll need to get a working GUI and server running -- and tests won't help there11:44
mithroMaZderMind: what is multiple days worth of work?11:44
mithroMaZderMind: I thought I had just requested a bunch of extra comments / minor docstring fixes?11:47
MaZderMindmithro: for example this: https://github.com/timvideos/gst-switch/pull/198/files#r2957833011:47
tpbTitle: Rewriting the integration tests to make them reliable and easier to understand by MaZderMind · Pull Request #198 · timvideos/gst-switch · GitHub (at github.com)11:47
MaZderMindDo you have tests which handle the case where a controller is connected after everything it set up?11:47
MaZderMindWhat about the case where multiple controllers are connected?11:47
MaZderMindno we don't and writing them - so they even pass travis - is not that easy11:48
mithroMaZderMind: I was expecting you to reply "No, shall I add a TODO for that?"11:48
mithroMaZderMind: or "Yes you silly person, see section ABC below."11:49
mithroMaZderMind: code review is a discussion, if something is going to a lot of effort or I might have missed something - please do point it out11:50
MaZderMindwell, you're right that we should have such tests but I worked for about 4 hours today now on those tests which is more then I usually have on a normal workday11:50
mithroMaZderMind: this pull request is very close to being mergable11:50
mithroMaZderMind: putting in "TODO: We should add tests for XXXX, see issue #452" is fine11:51
mithroMaZderMind: btw adding a TODO doesn't mean your responsible for finishing the TODO either11:52
MaZderMindI just wanted you to know how many days working on this can consume11:53
MaZderMindwell… I'll see how far i get11:53
mithroMaZderMind: I'm super excited about this code11:54
mithroMaZderMind: it's *so* much more readable and understandable then the previous version11:54
MaZderMindmithro: how about https://github.com/MaZderMind/gst-switch/commit/c7c6277baa47a2c4ada7a477f25043d789a66756 <- whould i add this to the int-test PR?12:01
tpbTitle: Change Control-Port to be IPv6 Compatible · MaZderMind/[email protected] · GitHub (at github.com)12:02
mithroMaZderMind: Does it merge without it? That LGTM, so I'm happy to just merge it.12:03
mithroMaZderMind: sorry I missed that stuff in https://github.com/timvideos/gst-switch/pull/206 - Really should have gotten someone to review it :P12:04
tpbTitle: Bind to all IP address (IPv4 and IPv6) by default. by mithro · Pull Request #206 · timvideos/gst-switch · GitHub (at github.com)12:04
mithroMaZderMind: otherwise I'm happy for you to send it as part of the other one12:04
mithroMaZderMind: which ever you think is easier12:04
mithroMaZderMind: Wish github let you suggest modifications to someone's pull request. Then I could just do the modification and ask you to accept it.12:13
lukas2511mithro: well, i guess you could actually do a pullrequest on the branch that is requested to merge12:23
mithrolukas2511: yeah, but it a bit of a mess12:23
MaZderMindmithro: I did not know that there are docs automatically generated. makes sense to have the doc-comments structured then but I think this is a good thing for another PR12:49
mithroMaZderMind: Yeah, lets leave it for another PR12:49
*** tvCommitBot has joined #timvideos13:05
tvCommitBot[gst-switch] MaZderMind opened pull request #211: [WIP] Control port ipv6 (master...control-port-ipv6) http://git.io/vJwN513:05
*** tvCommitBot has left #timvideos13:05
*** CarlFK has joined #timvideos13:32
*** ChanServ sets mode: +v CarlFK13:32
mithroMaZderMind: is that everything?13:53
MaZderMindmithro: I'm done with your comments on #19814:01
MaZderMindmithro: I'm currently trying to figure out why #211 os failing: https://github.com/timvideos/gst-switch/pull/21114:01
tpbTitle: [WIP] Control port ipv6 by MaZderMind · Pull Request #211 · timvideos/gst-switch · GitHub (at github.com)14:01
*** tvCommitBot has joined #timvideos14:06
tvCommitBot[gst-switch] mithro closed pull request #198: Rewriting the integration tests to make them reliable and easier to understand (master...int-tests-rewrite2) http://git.io/At5u14:06
*** tvCommitBot has left #timvideos14:06
mithro\o/14:06
mithroMaZderMind: I'm working on https://github.com/timvideos/gst-switch/issues/20014:08
tpbTitle: Composite-Output is 30fps, independent of configured format · Issue #200 · timvideos/gst-switch · GitHub (at github.com)14:08
MaZderMindbuild on master passing, coverage 100% :)14:18
mithro\o/14:22
mithroMaZderMind: thank you so much for all your effort on this14:22
MaZderMindyou can't imagine how happy I'm to have this of my todo-list14:23
MaZderMindinteresting how always one of the two int-tests fail https://travis-ci.org/timvideos/gst-switch/builds/61142866 - https://travis-ci.org/timvideos/gst-switch/builds/61147810 - https://travis-ci.org/timvideos/gst-switch/builds/6115130314:30
tpbTitle: Travis CI - Test and Deploy Your Code with Confidence (at travis-ci.org)14:30
MaZderMindthey fail because the gst-launch command did not capture any frames from the server14:31
mithroMaZderMind: looks like you have a scope issue there too, should probably set img=None at the begining14:31
mithroMaZderMind: I need to go to bed15:08
*** tvCommitBot has joined #timvideos15:08
tvCommitBot[gst-switch] mithro opened pull request #214: [WIP] Fix recording output format (master...recording-fix) http://git.io/vJrHG15:08
*** tvCommitBot has left #timvideos15:08
mithroMaZderMind: but I think I have a working change for the recording problem at https://github.com/timvideos/gst-switch/issues/20015:08
tpbTitle: Composite-Output is 30fps, independent of configured format · Issue #200 · timvideos/gst-switch · GitHub (at github.com)15:08
mithroMaZderMind: atleast it makes your test pass :)15:08
mithroMaZderMind: take a look and see what you think, I'll try and work on it again tomorrow depending on how busy work gets15:09
MaZderMindmithro: thank you for coding along with me :)15:16
mithroI think I have a handle on what is causing the multiple audio failure issue too15:31
mithroMaZderMind: if you want to concentrate on getting the new Python UI working, I'll try and get the server side working?15:32
MaZderMindmithro: I think I fixed the Control-Port-IPv6-Thing15:33
MaZderMindmithro: I think you wanted to head to bed? :)15:33
MaZderMindmithro: I have some requirements to the server that need to be finished before, although they are small15:33
MaZderMindthere are three signals missing on the controller-api: A/B selection, Audio-Selection and the New-Recordig-Filename Signal15:34
mithroI only just got home from work so still getting ready for bed.15:44
mithroAdding those signals seems reasonable thing to do.15:45
mithroAnyway, really going to bed now15:46
mithroThanks once again MaZderMind !15:46
MaZderMindn815:47
*** Niharika has joined #timvideos16:02
*** Niharika has quit IRC16:12
*** Niharika has joined #timvideos16:12
*** hyades has quit IRC16:19
*** hyades has joined #timvideos17:41
*** CarlFK has quit IRC18:24
MaZderMindfyi: #211, #208 and #190 should be ready for review / merge.18:59
MaZderMindoh dear how i love those green checkmarks18:59
*** CarlFK has joined #timvideos19:30
*** ChanServ sets mode: +v CarlFK19:30
*** Niharika has quit IRC19:43
*** CARAM__ has quit IRC20:25
*** CARAM__ has joined #timvideos20:27
*** CARAM__ has quit IRC20:32
*** Sewar has quit IRC20:32
*** micolous has quit IRC20:34
*** micolous has joined #timvideos20:34
*** CARAM__ has joined #timvideos20:35
*** Sewar has joined #timvideos20:35
*** hyades has quit IRC23:09

Generated by irclog2html.py 2.13.1 by Marius Gedminas - find it at mg.pov.lt!