*** tpb has joined #melange | 00:00 | |
*** scorche` is now known as scorche | 00:29 | |
*** bobbyaldol has quit IRC | 00:49 | |
*** jenmylo has quit IRC | 00:49 | |
*** j2shar has joined #melange | 01:45 | |
*** saurabhsood91 has quit IRC | 02:01 | |
*** roonyH has joined #melange | 02:11 | |
*** j2shar has quit IRC | 02:13 | |
*** j2shar has joined #melange | 02:23 | |
*** manugupt1 has quit IRC | 02:31 | |
*** manugupt1 has joined #melange | 02:33 | |
*** Hamish_B has joined #melange | 02:51 | |
Hamish_B | Hi a co-admin here, is it expected that our primary admin does not show up on the list of "Connections for my organizations"? | 02:52 |
---|---|---|
Hamish_B | I guess their status can not be altered, which is ok | 02:53 |
*** j2shar has quit IRC | 02:53 | |
*** j2shar has joined #melange | 02:54 | |
*** BlankVerse has joined #melange | 03:02 | |
*** roonyH has quit IRC | 03:16 | |
*** j2shar has quit IRC | 03:24 | |
*** j2shar has joined #melange | 03:27 | |
*** rishabh has joined #melange | 03:34 | |
*** j2shar has quit IRC | 03:38 | |
*** BlankVerse has quit IRC | 03:48 | |
*** manugupt1 has quit IRC | 03:52 | |
*** manugupt1 has joined #melange | 03:55 | |
*** manugupt1 has joined #melange | 03:55 | |
*** manugupt1 has quit IRC | 04:11 | |
*** Hamish_B has quit IRC | 04:31 | |
*** roonyH has joined #melange | 04:40 | |
*** tpb has joined #melange | 04:42 | |
*** ishaan has joined #melange | 04:45 | |
*** ishaan has joined #melange | 04:49 | |
*** ishaan has quit IRC | 04:52 | |
*** robbyoconnor has quit IRC | 05:01 | |
*** robbyoconnor has joined #melange | 05:02 | |
*** roonyH has quit IRC | 05:22 | |
*** piyushbansal has joined #melange | 05:46 | |
piyushbansal | hi nathaneilmanista :) | 05:50 |
piyushbansal | *nathanielmanista | 05:51 |
*** banas has joined #melange | 06:07 | |
*** banas_ has joined #melange | 06:22 | |
*** banas has quit IRC | 06:22 | |
*** banas_ is now known as banas | 06:23 | |
madrazr | piyushbansal: nathanielmanista is probably not around | 06:32 |
madrazr | piyushbansal: what's up? | 06:32 |
*** perepujal has joined #melange | 06:52 | |
*** asmeurer has quit IRC | 06:59 | |
*** roonyH has joined #melange | 07:05 | |
*** perepujal has quit IRC | 07:36 | |
piyushbansal | Hi madrazr, I was having some difficulty setting up the development environment | 07:47 |
piyushbansal | I was followinng instructions at GettingStarted page on the project wiki | 07:47 |
madrazr | piyushbansal: Ok | 07:47 |
madrazr | piyushbansal: what was the difficulty? | 07:47 |
piyushbansal | I am not able to run bin/buildout successfully | 07:47 |
piyushbansal | getting timedout while fetching cns.recipe.symlink | 07:48 |
madrazr | piyushbansal: what is the error? | 07:48 |
piyushbansal | you want me to paste the traceback ? | 07:48 |
madrazr | piyushbansal: yes please? | 07:48 |
piyushbansal | http://pastebin.com/5Pqdze7T | 07:50 |
tpb | Title: Develop: '/root/soc/.' Develop: '/root/soc/thirdparty/google_appengine/lib/yaml - Pastebin.com (at pastebin.com) | 07:50 |
piyushbansal | This is the output of bin/buildout | 07:50 |
piyushbansal | madrazr : The bootstrap executes just fine | 07:54 |
madrazr | piyushbansal: Oh! Was this the discussion about proxy earlier today? | 07:54 |
madrazr | piyushbansal: are you behind a proxy? | 07:55 |
piyushbansal | Yeah, I believe | 07:55 |
piyushbansal | I am behind a proxy, but that is without any authentication | 07:55 |
madrazr | piyushbansal: Oh ok, then that should be fine | 07:55 |
piyushbansal | The bug reported in buildout is probably for a authentication based proxy, not the kind I am behind | 07:55 |
madrazr | piyushbansal: being behind an authenticated proxy is a hope-less situation for Python packaging | 07:56 |
piyushbansal | Yeah, but since its a timeout, we have every reason to believe that there is some network issue | 07:56 |
madrazr | piyushbansal: can you open a Python shell | 07:56 |
piyushbansal | madrazr : I agree :D | 07:56 |
piyushbansal | yeah | 07:56 |
madrazr | and try >>> import urllib2 | 07:56 |
madrazr | >>> fp = urllib2.urlopen('http://google.com') | 07:56 |
madrazr | and see what happens | 07:56 |
piyushbansal | I am able to send get and post | 07:56 |
madrazr | can you try https? | 07:57 |
piyushbansal | yeah that would work, I already tried it | 07:57 |
piyushbansal | hang on, I did not try https | 07:57 |
piyushbansal | yeah both of them return a socket._fileobject object | 07:58 |
piyushbansal | Both, I mean http and https | 07:58 |
madrazr | piyushbansal: read that file and see? | 07:58 |
madrazr | if the content is google.com's? | 07:58 |
madrazr | or some error? | 07:58 |
piyushbansal | yeah, it is | 07:58 |
piyushbansal | No error. | 07:59 |
piyushbansal | Is there any other wayout ( some other set of installation instructions) that don't rely on buildout | 07:59 |
piyushbansal | I'll manually install the dependencies or something | 07:59 |
madrazr | it is very tricky | 08:00 |
madrazr | buildout does a lot of things behind the scenes | 08:00 |
piyushbansal | I have been working on this, I mean, I even appliad a not so very reliable patch on the buildout, did not work | 08:00 |
madrazr | all I can imagine for now is to fetch all the dependencies | 08:00 |
madrazr | install them | 08:00 |
piyushbansal | I know, that's the reason, we use it in the first place | 08:00 |
madrazr | and add the path to those libraries to your PYTHONPATH environment variable | 08:00 |
piyushbansal | Where do I get the list of those dependencies | 08:01 |
madrazr | buildout.cfg? | 08:01 |
piyushbansal | Shall I read buildout.cfg ? | 08:01 |
madrazr | piyushbansal: yeah | 08:01 |
piyushbansal | Hmm okay , long shot, but worth a shot it seems | 08:01 |
madrazr | piyushbansal: but also keep in mind, each of those packages may have additional dependencies | 08:01 |
piyushbansal | oh right, It would never work that way. | 08:01 |
piyushbansal | I must figure what the real problem is. | 08:02 |
madrazr | piyushbansal: also another thing worth trying is to probably try using pip or easy_install? | 08:02 |
piyushbansal | Infact I even tried from my cell phone's packet data, I get timed out at the same recipe | 08:02 |
madrazr | Oh | 08:02 |
madrazr | that's weird | 08:02 |
piyushbansal | easy_install works under all kinds of proxies, I tried that as well | 08:02 |
piyushbansal | Its sort of more robust than pip, in terms of network issues | 08:03 |
piyushbansal | It really is weird, or I am missing something, which shouldn't be unless the instructions at GettingStarted have an issue in them | 08:03 |
madrazr | piyushbansal: we haven't seen any issues with the GettingStarted instructions so far | 08:04 |
piyushbansal | There should be something, just read the last comment on that page | 08:04 |
piyushbansal | Its like 6-8 months old, if I remember correctly | 08:04 |
piyushbansal | They guy has probably same issues as mine | 08:05 |
madrazr | piyushbansal: authenticated proxy he says? | 08:06 |
piyushbansal | One more thing madrazr, would you please tell me the output of nosetests -v on your shell ? | 08:06 |
madrazr | piyushbansal: which is not same as your issue? | 08:06 |
piyushbansal | yeah, that's right. | 08:06 |
madrazr | piyushbansal: I don't have nosetests installed :) | 08:06 |
piyushbansal | I missed that part. | 08:06 |
madrazr | piyushbansal: I use the buildout version of it | 08:07 |
piyushbansal | Oh so you run bin/run-tests | 08:07 |
piyushbansal | or something like that ? | 08:07 |
madrazr | piyushbansal: yeah | 08:07 |
piyushbansal | I was interested in the testing project, I am not able to setup the dev environ correctly , it sucks :| | 08:07 |
piyushbansal | Any undocumented dependencies, that you suspect ? | 08:08 |
madrazr | piyushbansal: it does, welcome to Python package management | 08:08 |
madrazr | piyushbansal: nope | 08:08 |
piyushbansal | I have been using pip/buildout/easy_install and all that kind of stuff for over an year now | 08:09 |
piyushbansal | never faced an issue like this one. | 08:09 |
madrazr | piyushbansal: curious | 08:09 |
piyushbansal | Sorry, didn' t get you | 08:09 |
madrazr | piyushbansal: I just meant that you seeing this problem all of a sudden is curious | 08:10 |
piyushbansal | I just installed a django application on my machine a week ago, used buildout , it installed with no major issues | 08:11 |
madrazr | piyushbansal: that makes me even more curious | 08:14 |
madrazr | piyushbansal: btw | 08:14 |
madrazr | piyushbansal: can you try https://pypi.python.org/pypi/zc.buildout/2.1.0 | 08:14 |
tpb | Title: zc.buildout 2.1.0 : Python Package Index (at pypi.python.org) | 08:14 |
madrazr | the -t command line option from here? | 08:14 |
madrazr | piyushbansal: may be set -t to very long | 08:14 |
madrazr | 10 secs? | 08:15 |
madrazr | piyushbansal: or even longer? | 08:15 |
piyushbansal | oh yes, that can be done | 08:15 |
piyushbansal | let me give it a shot | 08:15 |
piyushbansal | Infact I have used the same package | 08:16 |
piyushbansal | I can try the timeout thing though | 08:16 |
piyushbansal | timedout at 50 s :| | 08:20 |
*** rishabh has quit IRC | 08:21 | |
*** roonyH has quit IRC | 08:22 | |
piyushbansal | I feel that I am failing to install cns.recipe.symlink properly | 08:24 |
piyushbansal | Would you just try install it from git+git://github.com/koodaamo/cns.recipe.symlink.git, madrazr ? | 08:25 |
piyushbansal | I believe there is some problem with the recipe itself | 08:25 |
piyushbansal | rather than buildout, because buildout has always been working for me :\ | 08:25 |
madrazr | piyushbansal: yeah, may be try that | 08:26 |
madrazr | piyushbansal: you may also want to put in under melange/eggs | 08:26 |
piyushbansal | I tried that, and the recipe is failing | 08:27 |
piyushbansal | would you please give it a shot, just to be sure, that its problem at the recipe level | 08:27 |
madrazr | piyushbansal: disable that part and try? | 08:27 |
piyushbansal | disable the ? | 08:27 |
madrazr | piyushbansal: yes, I just did a fresh checkout and buildout | 08:27 |
madrazr | piyushbansal: it builds fine for me | 08:27 |
madrazr | on a completely new machine | 08:27 |
madrazr | my lab machine actually | 08:28 |
piyushbansal | It would build fine, because already dependecny of cns... recipe is satisfied ? | 08:28 |
piyushbansal | I guess. | 08:28 |
piyushbansal | If that recipe is not there, fetching it and installing it is what's causing the issue | 08:28 |
*** bobbyaldol has joined #melange | 08:29 | |
madrazr | piyushbansal: what do you mean? | 08:49 |
*** roonyH has joined #melange | 08:50 | |
*** vinookuri has joined #melange | 09:04 | |
vinookuri | Hello, i was interested in participating in GSOC this year for melange. Can someone help me on how i should begin? | 09:05 |
*** Hamish_B has joined #melange | 09:24 | |
madrazr | vinookuri: Hi | 09:26 |
madrazr | welcome | 09:26 |
madrazr | vinookuri: some of the first steps that students generally do are, trying to get Melange up and running on a local development machine, look at our ideas page and discuss them with Melange developers here, send a patch to Melange, etc. | 09:27 |
vinookuri | Awesome. I will get melange up and running on my local machine first | 09:28 |
madrazr | vinookuri: cool, sure | 09:31 |
*** banas has quit IRC | 09:50 | |
*** vinookuri has quit IRC | 10:00 | |
piyushbansal | Hi madrazr : Sorry I dozed off for a while :\ | 10:14 |
piyushbansal | What I meant was, was the dependendency of cns.recipe.symlinks met locally on your machine ? | 10:15 |
madrazr | piyushbansal: I think so yeah | 10:15 |
madrazr | how else will buildout proceed otherwise? | 10:15 |
piyushbansal | You would have to fetch it first, that's the thing | 10:16 |
piyushbansal | When you said that you installed on a fresh machine, I meant to ask if the machine already had cns.recipe.symlink present in it ? | 10:17 |
piyushbansal | If this depedendency was met locally. | 10:17 |
madrazr | piyushbansal: I said "fresh" install | 10:19 |
madrazr | piyushbansal: I wish that machine new about those packages before :P | 10:19 |
*** Hamish_B has left #melange | 10:20 | |
piyushbansal | Sorry , but I think I might not have been able to express myself very clearly here. | 10:20 |
piyushbansal | I meant that we all have multiple projects up nad running on our machines, if one project requires one package it would have been installed at some point of time | 10:21 |
piyushbansal | If the buildout you are using can find that package locally, it would not fetch it. | 10:21 |
madrazr | piyushbansal: no worries, a fresh checkout on a completely arbitrary machines where no Python related work was done before could run Melange from buildout | 10:21 |
*** Merio has joined #melange | 10:21 | |
*** ChanServ sets mode: +o Merio | 10:21 | |
madrazr | that's the take away | 10:21 |
madrazr | so there is nothing wrong the buildout configuration I can see | 10:21 |
piyushbansal | Oh, that's what I was asking | 10:22 |
madrazr | piyushbansal: also no one else has complained so far | 10:22 |
madrazr | so I don't think buildout configuration has any issues | 10:22 |
piyushbansal | Hmm, I will try on another machine and get back to you. | 10:22 |
madrazr | piyushbansal: btw, about your "we all have multiple projects up nad running on our machines" which is exactly why I never ever ever install any python packages system wide | 10:23 |
piyushbansal | Oh, okay. I am not very experienced, so :\ | 10:23 |
madrazr | piyushbansal: if I ever have to install a Python package that spans across two projects or something like that, I use virtualenv, install packages there and just blow out the virtualenv directory once I am done | 10:23 |
piyushbansal | Sorry, if I am being too naive here | 10:24 |
*** roonyH has quit IRC | 10:24 | |
madrazr | you/everyone else should do that too | 10:24 |
madrazr | :) | 10:24 |
piyushbansal | Oh okay, that's a good suggestion. | 10:24 |
piyushbansal | I should do it, every time I get a similar use case. | 10:24 |
piyushbansal | Thanks a lot madrazr :) | 10:26 |
madrazr | piyushbansal: YW | 10:26 |
*** banas has joined #melange | 10:58 | |
*** perepujal has joined #melange | 11:23 | |
*** jenmylo has joined #melange | 11:23 | |
*** xan_ps has joined #melange | 11:24 | |
*** bobbyaldol has quit IRC | 11:30 | |
*** jenmylo has quit IRC | 11:38 | |
*** perepujal has quit IRC | 11:40 | |
Uli- | can you please make those new connection emails a little more useful? | 11:41 |
piyushbansal | madrazr : I finally managed to install :) | 11:41 |
madrazr | piyushbansal: awesome! | 11:42 |
madrazr | piyushbansal: what did you do? | 11:42 |
piyushbansal | There was a lot of source code I had to go through actually to do it, like reading source code of cns.recipe.symlink | 11:42 |
Uli- | they are plain wrong, telling me "An org admin for xyz has established a connection with you" when actually someone wanted to be a mentor and I as the org admin am receiving the email | 11:42 |
madrazr | Uli-: Please file an issue at tinyurl.com/new-issue | 11:42 |
piyushbansal | The github repo from where I pulled source of cns.recipe.symink had a bug, I commented some unnecessary credits section of the code, added egg to local eggs directory | 11:43 |
piyushbansal | forced buildout to use everything locally | 11:43 |
piyushbansal | And it built everything except for node :\ | 11:43 |
piyushbansal | Do you have bin/node present ? | 11:43 |
madrazr | piyushbansal: Oh man, that must have been painful | 11:43 |
piyushbansal | I told you, I had been working on it for so long | 11:44 |
*** perepujal has joined #melange | 11:44 | |
madrazr | piyushbansal: yes | 11:44 |
piyushbansal | I feel like sending a patch to cns.recipe.symlink as well | 11:44 |
piyushbansal | :) | 11:44 |
piyushbansal | I still cannot figure out, what the real issue was . | 11:44 |
piyushbansal | What exactly does node do ? | 11:46 |
piyushbansal | I don't have any idea, as per how important is it for the system to run. | 11:46 |
piyushbansal | I believe it must be something that improves scalibility, or I am wrong ? | 11:46 |
*** Merio has quit IRC | 11:54 | |
*** Merio has joined #melange | 11:54 | |
*** ChanServ sets mode: +o Merio | 11:54 | |
madrazr | Merio: welcome back :) | 12:02 |
madrazr | piyushbansal: which one? | 12:02 |
*** rihnapstor has joined #melange | 12:06 | |
piyushbansal | node , madrazr ? | 12:08 |
piyushbansal | Is it node.js sort of thing ? | 12:08 |
madrazr | that's used for JS testing | 12:08 |
madrazr | piyushbansal: not sort of, it is node.js :) | 12:08 |
piyushbansal | oh okay :) | 12:09 |
piyushbansal | would you please paste ls bin/ | 12:09 |
piyushbansal | I need to see what all packages have failed installing | 12:09 |
piyushbansal | So that I have more manual work to do :P | 12:09 |
madrazr | piyushbansal: | 12:11 |
madrazr | http://paste.pound-python.org/show/32148/ | 12:11 |
tpb | Title: Paste #32148 | LodgeIt! (at paste.pound-python.org) | 12:11 |
Merio | madrazr: thx :) | 12:11 |
madrazr | Merio: :D | 12:12 |
piyushbansal | madrazr : I am missing all the node.js packages it seems | 12:13 |
piyushbansal | They aren't very critical for unit testing , are they ? | 12:13 |
piyushbansal | like npm, node, node-waf ? | 12:13 |
*** rihnapstor has quit IRC | 12:19 | |
*** SinnerShanky has quit IRC | 12:22 | |
*** SinnerShanky has joined #melange | 12:23 | |
*** rihnapstor has joined #melange | 12:32 | |
madrazr | piyushbansal: depends on what you are unit testing | 12:33 |
madrazr | alright I should be off to bed now | 12:33 |
madrazr | piyushbansal: Merio can help you with that if he is around | 12:33 |
madrazr | piyushbansal: or nathanielmanista or someone will help you | 12:33 |
piyushbansal | Okay , thanks a lot madrazr :) | 12:34 |
madrazr | piyushbansal: sorry, I need to crash, 5:30AM here already :D | 12:34 |
Merio | madrazr, piyushbansal: yes I'm around :) | 12:34 |
madrazr | piyushbansal: NP | 12:34 |
madrazr | Merio: thanks! Please help piyushbansal | 12:34 |
piyushbansal | madrazr : np :) You have really helped me a lot | 12:34 |
*** madrazr has quit IRC | 12:34 | |
piyushbansal | I have the environ up and running, better start hacking on it:) | 12:34 |
piyushbansal | Merio : I was facing some difficulty over installation | 12:35 |
Merio | piyushbansal: looking at the backlog :) | 12:35 |
piyushbansal | I manually installed all dependencies and somehow managed to install all the packages except for node related | 12:35 |
rihnapstor | piyushbansal: which version of node you have ? | 12:36 |
piyushbansal | How important are node related packages for non js unit testing/functional testing | 12:36 |
piyushbansal | v0.6.12 | 12:36 |
piyushbansal | ^ rihnapstor | 12:37 |
Merio | piyushbansal: why do you feel they're not installed? Is node_modules directory present? | 12:38 |
piyushbansal | nope :\ | 12:38 |
piyushbansal | Also in the bin/ there are no node related packages | 12:38 |
piyushbansal | like npm, node, node-was | 12:38 |
*** banas has quit IRC | 12:38 | |
piyushbansal | *wps | 12:38 |
piyushbansal | All three | 12:38 |
Merio | piyushbansal: however, it's useful for us to debug, but don't worry about it.. .there are currently no meaningful tests for JS | 12:39 |
piyushbansal | Merio : okay , thanks a lot | 12:40 |
*** banas has joined #melange | 12:40 | |
Merio | just keep in mind | 12:40 |
piyushbansal | yeah, tell me | 12:41 |
*** mang0 has joined #melange | 12:41 | |
*** mang0 has joined #melange | 12:41 | |
Merio | basically you can select which tests to run | 12:42 |
Merio | If you do ./bin/run-tests everything runs, it shouldn't be a problem if you don't have node it will just skip the js tests | 12:43 |
piyushbansal | right | 12:43 |
Merio | if you run into any issue you can run only unit tests by using ./bin/run-tests -t pyunit | 12:43 |
Merio | so it will run only python's unit tests | 12:43 |
piyushbansal | yeah, okay | 12:44 |
Merio | However as far as I can see it's a problem with the connection to the recipe, so there is not much we can do I suppose | 12:44 |
rihnapstor | hey Merio :) i have started with bugs as its necessary to submit a patchset with gsoc proposal. I would like to know more about how exactly we should write unit test for js ? | 12:44 |
piyushbansal | Yeah, Merio, you are right. | 12:44 |
Merio | rihnapstor: as in the style or how to add/create one? | 12:44 |
Merio | rihnapstor: hi, btw :) | 12:45 |
piyushbansal | I manually pull the source and installed the eggs system wide( not so good , I know :() | 12:45 |
piyushbansal | Then it worked. | 12:45 |
piyushbansal | But still, it can be useful if someone faces similar issue | 12:45 |
Merio | piyushbansal: if you want/have time to, you can add a comment in the wiki about the process you followed https://code.google.com/p/soc/wiki/GettingStarted | 12:48 |
tpb | <http://ln-s.net/+yoz> (at code.google.com) | 12:48 |
rihnapstor | Merio: yeah, can just give explain me precisely of what exactly needs to be done in Javascript Tests. i have never written unit test for js ,but would love to learn. | 12:49 |
Merio | rihnapstor: the infrastructure has just been put in place a couple of weeks ago, so everything it's in an early stage | 12:50 |
Merio | rihnapstor: it's the first time that I use jasmine for me as well, so I'm not 100% sure there is no adjustment to make in the infrastructure itself. So there is a lot of room for improvement and to influence how things will be done | 12:51 |
Merio | rihnapstor: we currently use testem, which is configured in file testem.json in the root directory of the project | 12:51 |
rihnapstor | Merio: : so i should first learn how to write unit test for js ? | 12:52 |
Merio | rihnapstor: first step then is to learn how to use jasmine => http://pivotal.github.io/jasmine/ | 12:54 |
tpb | Title: introduction-1.3.1.js (at pivotal.github.io) | 12:54 |
rihnapstor | ok thanks Merio :) | 12:55 |
Merio | rihnapstor: yw :) | 12:56 |
piyushbansal | Merio : Sure, I would do that. I don't want everyone to go through the source code of various recipes and do a human brute force :P | 12:58 |
rihnapstor | Merio: here i will have to follow the complete Tutorial to understand Jasmine ? and then get on with applying jasmine to hack with melange js files ? | 12:59 |
Merio | rihnapstor: I would say so. You can find the current spec files and fixtures (very simple ones, just to confirm that everything is in place and working) in tests/app/soc/content/js | 13:01 |
Merio | piyushbansal: hehe, sure, thanks :) | 13:02 |
Merio | piyushbansal, rihnapstor: need to be AFK for a while to have lunch, see you in half an hour/one houe | 13:03 |
Merio | s/houe/hour | 13:03 |
rihnapstor | Merio: what time you are available usually so that we can discuss more ? | 13:04 |
rihnapstor | ok Merio :) thanks for help today. | 13:04 |
rihnapstor | btw, Merio jasmine has many callbacks and the code looks awesome with solarized theme :) | 13:05 |
piyushbansal | Merio : Thanks a lot | 13:05 |
piyushbansal | And one thing more, Merio : I am interested in funcitonal testing, But I dont' see leo around here. | 13:06 |
piyushbansal | When is the best time, to discuss more with him ? | 13:06 |
Merio | rihnapstor: safer days are working days (Mon-Fri) from about 8 to 18 UTC+1 | 13:06 |
Merio | piyushbansal: I think your best bet is to send an email to the mailing list | 13:08 |
rihnapstor | ok thanks Merio :) | 13:08 |
piyushbansal | Merio : Okay I would do that , thanks a lot | 13:09 |
Merio | sure, going to have lunch, we'll be back soon so if you have any questions just write them here and I'll reply when I'll get back :) | 13:10 |
rihnapstor | no problem Merio :) | 13:11 |
rihnapstor | enjoy your lunch :D | 13:11 |
* rihnapstor greets | 13:12 | |
*** roonyH has joined #melange | 13:17 | |
*** sunu_ is now known as sunu | 13:19 | |
*** piyushbansal has quit IRC | 13:23 | |
*** piyushbansal has joined #melange | 13:36 | |
*** xan_ps has quit IRC | 13:47 | |
piyushbansal | Merio : made a comment at the bottom of the getting started page, not a very well structured, but it sure might be of some help. | 13:49 |
*** perepujal1 has joined #melange | 13:50 | |
*** jenmylo has joined #melange | 13:50 | |
*** perepujal has quit IRC | 13:51 | |
*** rihnapstor has quit IRC | 13:53 | |
*** rihnapstor has joined #melange | 13:54 | |
*** perepujal1 has quit IRC | 13:54 | |
*** perepujal has joined #melange | 13:54 | |
* rihnapstor will be right back | 13:54 | |
*** rihnapstor has quit IRC | 13:55 | |
*** roonyH has quit IRC | 14:04 | |
*** patrickg has left #melange | 14:05 | |
*** mang0 has quit IRC | 14:09 | |
Merio | piyushbansal: awesome, thank you very much! | 14:24 |
* downey just created https://code.google.com/p/soc/issues/detail?id=1784 | 14:24 | |
tpb | <http://ln-s.net/+z$N> (at code.google.com) | 14:25 |
piyushbansal | Merio : :) | 14:30 |
*** perepujal has quit IRC | 14:32 | |
*** asmeurer has joined #melange | 14:57 | |
*** rihnapstor has joined #melange | 15:03 | |
*** saurabhsood91 has joined #melange | 15:17 | |
*** piyushbansal has quit IRC | 15:19 | |
*** shaumik has joined #melange | 15:27 | |
*** saurabhsood91 has quit IRC | 15:27 | |
*** saurabhsood91 has joined #melange | 15:34 | |
*** vrnithin has joined #melange | 15:35 | |
vrnithin | am trying to setting up melange directory in my system | 15:36 |
vrnithin | After executing "python bootstrap.py" I am getting this. | 15:36 |
vrnithin | error: None | 15:36 |
vrnithin | Traceback (most recent call last): | 15:36 |
vrnithin | File "bootstrap.py", line 155, in <module> | 15:36 |
vrnithin | repr(cmd)[1:-1]) | 15:36 |
vrnithin | Exception: ('Failed to execute command:\n%s', "'/usr/bin/python', '-c', 'from setuptools.command.easy_install import main; main()', '-mZqNxd', '/tmp/tmp_tFGrK', 'zc.buildout==2.1.0'") | 15:36 |
vrnithin | what to do ? | 15:36 |
*** akif500 has joined #melange | 15:36 | |
shaumik | @vrnithin- try doing a sudo python bootstrap.py | 15:38 |
akif500 | got a question that can we attach graphics and diagrams in our gsoc proposal? | 15:38 |
vrnithin | @shaumik still getting the same error. | 15:41 |
Merio | vrnithin: It seems like Lennard has replied to your mail on the dev list, did you try to run that command? | 15:52 |
Merio | akif500: IIRC you can attach images as long as you link them by URL and host them elsewhere | 15:53 |
vrnithin | @Merio yup its working fine..thanks | 15:53 |
*** snizzo has joined #melange | 15:54 | |
Merio | akif500: otherwise you can still write a proposal and put a link to redirect potential mentors to further information on your proposal | 15:54 |
rihnapstor | Merio: installed jasmine 1.3.1 :) | 15:54 |
Merio | akif500: as in put a simpler proposal in Melange and then say: have a look at this link for further information on how I want to implement this and this... | 15:54 |
Merio | vrnithin: nice! | 15:55 |
Merio | rihnapstor: awesome :) do you have it working also in melange? | 15:55 |
Merio | rihnapstor: you can run ./bin/run-tests -t js in order to run JS tests and see if they're working. So whenever you want you can try and do something on Melange as well | 15:56 |
rihnapstor | Merio: I 'cd ' into melange/tests/ and then triggered 'jasmine-node .' | 15:57 |
*** Cadair has joined #melange | 15:57 | |
rihnapstor | Merio: Finished in 0.042 seconds ====2 tests, 4 assertions, 4 failures | 15:58 |
vrnithin | am getting timed out error for this command "sudo bin/buildout" | 15:58 |
*** Cadair has left #melange | 15:58 | |
akif500 | Merio:thanks a lot | 15:58 |
*** akif500 has quit IRC | 15:58 | |
rihnapstor | vrnithin: type './bin/buildout' from the directory 'melange/soc' | 15:59 |
rihnapstor | vrnithin: note the period i ahve prefixed. | 15:59 |
Merio | rihnapstor: run ./bin/run-tests -t js from the root directory and see if they work | 16:01 |
rihnapstor | Merio: ok | 16:02 |
Merio | vrnithin: are you behind a proxy? Because time out error seems to be related to a failed connection to a server | 16:02 |
*** carols has joined #melange | 16:04 | |
vrnithin | @Merio yup . in my college network many ports are blocked. | 16:04 |
vrnithin | @Merio SSH port is blocked.will it be an issue ? | 16:05 |
*** Merio has quit IRC | 16:06 | |
rihnapstor | Merio: Wow ! Firefox pops up says 'passing 2 specs' | 16:07 |
*** Merio has joined #melange | 16:07 | |
*** ChanServ sets mode: +o Merio | 16:07 | |
* rihnapstor impressed | 16:07 | |
rihnapstor | Merio: Wow ! Firefox pops up says 'passing 2 specs' | 16:08 |
*** shaumik has quit IRC | 16:09 | |
* rihnapstor brb | 16:19 | |
*** rihnapstor has quit IRC | 16:19 | |
*** sddhrthrt has joined #melange | 16:28 | |
*** manugupt1 has joined #melange | 16:31 | |
*** carols has quit IRC | 16:35 | |
*** carols has joined #melange | 16:39 | |
*** bhatta has joined #melange | 16:41 | |
*** roonyH has joined #melange | 16:49 | |
Merio | vrnithin: have a look at the last comment here https://code.google.com/p/soc/wiki/GettingStarted, it was left a couple of hours ago by another fellow | 16:57 |
*** DrJoel has joined #melange | 17:02 | |
* DrJoel asks politely... any updates on connections? | 17:03 | |
*** divyanshu has joined #melange | 17:25 | |
divyanshu | i need help setup melange | 17:25 |
*** roonyH has quit IRC | 17:28 | |
*** snizzo has quit IRC | 17:33 | |
divyanshu | I am getting timeout errors everytime i do bin/buildout | 17:34 |
*** snizzo has joined #melange | 17:35 | |
*** haseeb has joined #melange | 17:37 | |
Merio | divyanshu: Hi, are you behind a proxy? Have a look at the latest comments here https://code.google.com/p/soc/wiki/GettingStarted, it was left a couple of hours ago by another fellow | 17:37 |
*** haseeb has left #melange | 17:37 | |
*** rihnapstor has joined #melange | 17:40 | |
*** carols has quit IRC | 17:40 | |
divyanshu | thanks i ll try that | 17:42 |
*** carols has joined #melange | 17:43 | |
divyanshu | but i am not behind a proxy | 17:44 |
*** DrJoel has left #melange | 17:45 | |
Merio | dibyanshu, then probably there is a temporary problem with the connection to the source of a recipe (actually, I hope it's temporary) | 17:45 |
rihnapstor | Merio: hi | 17:46 |
Merio | rihnapstor: hi! | 17:46 |
*** piyushbansal has joined #melange | 17:50 | |
rihnapstor | Merio: i read about jasmine test framework.quite Interesting though. './bin/runtest' passed two test ,but test didn't run on chrome. Chrome automatically pops and shuts down . | 17:50 |
*** DrJoel has joined #melange | 17:51 | |
Merio | rihnapstor: they should work like this: it should do tests on chrome and then close the browser, same for other browsers that are found in the system. After those tests are done, it should also run them on phantomjs | 17:52 |
Merio | rihnapstor: the idea is to run them only on the headless phantomjs in order to implement continuous integration one day, but it doesn't hurt to test in other browsers meanwhile :) | 17:54 |
Merio | rihnapstor: or, rather than "meanwhile" I'd say when you run them locally :) | 17:54 |
piyushbansal | hi divyanshu :) | 17:54 |
rihnapstor | yeah,but Merio chrome doesn't load any test on any localhost post it pops and shuts down within seconds. so that means it test is passed ? | 17:55 |
piyushbansal | I was having a look at the IRC logs and it seems you are also facing installation issue | 17:55 |
*** divyanshu has quit IRC | 17:55 | |
rihnapstor | *port | 17:55 |
piyushbansal | I have made a comment at the bottom of getting started page, please go through it , and let me know if the issue prevails | 17:55 |
piyushbansal | hi vrnithin, Please have a look ^ , if you're still having installation issues | 17:56 |
Merio | piyushbansal: I didn't realise you were here, otherwise I would have pointed to you directly instead of saying "another fellow" :) Sorry it was just difficult for me to know your nick by heart, my fault! | 17:57 |
piyushbansal | Oh, not a big deal at all. Infact I am new to melange community, how can I expect you to know me in just a day or two :) | 17:57 |
vrnithin | @piyushbansal i saw your comment .after commenting out setup.py how to run setup.py ? whats the option to be given with "python setup.py" ? | 17:57 |
piyushbansal | first run build | 17:58 |
Merio | rihnapstor: what does the console say? It should pop and shut down within seconds, that's normal. It basically runs the tests (which are very simple right now, so it doesn't take much time) and then shuts down | 17:58 |
piyushbansal | ie. python setup.py build | 17:58 |
piyushbansal | and then pyhton setup.py install | 17:58 |
piyushbansal | This is the most common way of installing packages pyhton recipes(apart from pip/easy_install) | 17:58 |
piyushbansal | Merio: Oh, not a big deal at all. Infact I am new to melange community, how can I expect you to know me in just a day or two :) | 17:59 |
vrnithin | piyushbansal: thanks | 18:00 |
piyushbansal | vrnithin : Did it work ? | 18:00 |
Merio | piyushbansal: indeed, still I was wanting to look on the backlog and copy paste but I didn't have much time because of craziness at work and still I wanted to help out the others as soon as possible. However, yeah.. welcome to the community and great that you're helping out! I think it might be not a problem with the proxy thing, but probably the recipe just have connection issues | 18:01 |
Merio | As divyanshu seemed not to be behind proxy | 18:01 |
piyushbansal | Yeah, I figured. The recipe has some connectivity issues. | 18:01 |
vrnithin | piyushbansal: cns.recipe.symlink worked fine. | 18:02 |
piyushbansal | You're right, as a matter of fact, I tried everything, including tunneling and bypassing my college proxy | 18:02 |
piyushbansal | Okay cool, vrnithin | 18:02 |
piyushbansal | I am just idling around IRC for another hour or so, so if you still face issues, just ping me :) | 18:02 |
Merio | piyushbansal: let's hope it's temporary | 18:03 |
rihnapstor | piyushbansal: you dont attend classes ? | 18:03 |
piyushbansal | Merio : I wish. but since we have a (sort of) solution, it won't be much of an issue to us. :) | 18:03 |
Merio | I'm gonna leave soon and head home for tonight. I'll be back tomorrow, though. :) | 18:04 |
piyushbansal | rihnapstor : I do, I am from India, you see its like 12 midnight here :) | 18:04 |
piyushbansal | Merio : Okay cool, thanks for helping out and being here, if there are any more people with installtion issues, I would be happy to help. | 18:05 |
piyushbansal | Good night :) | 18:05 |
rihnapstor | Merio: Thanks you introduced me to jasmine TDD :) i am new to it. so it will be a learning curve. so from now we will test js by running './bin/runtests' and why not jasmine-node ? | 18:07 |
Merio | piyushbansal: thank you very much for helping out again! See you tomorrow | 18:07 |
rihnapstor | sorry BDD | 18:08 |
piyushbansal | Merio: One last thing before you go, what would be the ideal time to discuss functional tesing with liu ? | 18:08 |
piyushbansal | I don't find him on IRC | 18:09 |
Merio | rihnapstor: yw, I'm new to it myself, didn't have the chance to use it before. It's actually a BDD framework, but the difference is very blurred and AFAIK you can do TDD with a BDD framework, it just depends on what you do. You need to run ./bin/runtests because testem takes care of many things as doing the tests on every browser you have in your environment and sets jasmine up. It basically takes care of many things automatically. | 18:10 |
Merio | piyushbansal: your best bet is to send a mail to the mailing list, since I'm not sure he joins IRC at all. We mainly use the mailing list for communication, I'm not active in the IRC channel myself usually as well (unless somebody explicitly says my nick and I'm notified) :) | 18:11 |
rihnapstor | oh ok Merio tommorow you will be there ? and at what time UTC ? | 18:12 |
Merio | piyushbansal: but I usually try to be present as much as possible during GSoC students application phase, since sometimes people are more shy to write something in the mailing list and prefer direct communication and direct feedback instead | 18:12 |
Merio | rihnapstor: I'll probably be online at 8 AM Dublin time (Ireland). That would be 8 UTC+1 I guess (since we're in DST now). But I'm not sure about my responsiveness during the morning since I'm going to have some meetings at work. But you try and I'll write something as soon as I've some time :) | 18:13 |
piyushbansal | Merio: Okay thanks for the information, I have already sent a mail on the mailing list though :) | 18:14 |
rihnapstor | fine Merio :) gn :) have great day | 18:15 |
vrnithin | piyushbansal: " Fiddle around with your python environment path " means ? | 18:16 |
*** roonyH has joined #melange | 18:17 | |
Merio | piyushbansal: yeah, you're right. Lennard seems to have CCed Leo, so we have just to wait for him to show up. If he doesn't show up in one day or two we'll try other meanings of contacting him. | 18:18 |
*** robbyoconnor has quit IRC | 18:18 | |
piyushbansal | Merio: Okay sure :) and umm Lennie on IRC is lennard, right ? | 18:19 |
Lennie | Yeah that's me | 18:19 |
Merio | piyushbansal: He's Lennie | 18:19 |
Merio | Oh there you are :) | 18:19 |
rihnapstor | hi Lennie :) :D | 18:19 |
Lennie | Merio, that's what you get when I get highlighted :P | 18:19 |
piyushbansal | hi Lennie :) | 18:20 |
Merio | piyushbansal: you can have a look at the functional_testing branch (https://code.google.com/p/soc/source/list?name=functional_testing) meanwhile. | 18:20 |
Lennie | hi rihnapstor and piyushbansal | 18:20 |
tpb | <http://ln-s.net/+zC8> (at code.google.com) | 18:20 |
piyushbansal | vrnithin : Oops I forgot we were having a discussion, have a look at this link http://stackoverflow.com/questions/3402168/permanently-add-a-directory-to-pythonpath | 18:20 |
tpb | <http://ln-s.net/+zC+> (at stackoverflow.com) | 18:20 |
piyushbansal | Merio : Okay , I sure would | 18:21 |
piyushbansal | Btw, if you have some idea, Merio, would functional testing mostly comprise of selenium and smoke tests w.r.t our project ? | 18:21 |
Merio | piyushbansal: commits of Syed Armani, which was a student last year (and now he's a contributor) and he's making the functional testing happen | 18:21 |
Merio | s/which/who | 18:21 |
vrnithin | piyushbansal: ok | 18:22 |
Merio | rihnapstor: thanks :) | 18:22 |
Merio | Lennie: that's dangerous then :P | 18:23 |
*** perepujal has joined #melange | 18:25 | |
piyushbansal | Btw, if you have some idea, Merio, would functional testing mostly comprise of selenium and smoke tests w.r.t our project ? | 18:27 |
*** DrJoel has left #melange | 18:27 | |
*** perepujal has left #melange | 18:29 | |
* nathanielmanista is happy to see so much conversation going on and is totally lost in it all | 18:30 | |
* rihnapstor greets | 18:30 | |
vrnithin | piyushbansal: after Installation of gp.recipe.node can i proceed to "bin/gen-app-yaml local-devel" ? | 18:31 |
Merio | piyushbansal: as far as I know it's using selenium, yes | 18:33 |
Merio | Hi nathanielmanista :) | 18:33 |
vrnithin | piyushbansal: so ./bin/buildout is installing node.js,cns.recipe.symlink and gp.recipe.node ? | 18:33 |
Merio | nathanielmanista: sorry for yesterday, I was sick... headache all day. I'm glad you guys fixed the issues with connections so promptly (not that I would have been of any use, but ... still glad!!! :)) | 18:34 |
piyushbansal | Merio : okay , its good to know | 18:35 |
*** roonyH has quit IRC | 18:36 | |
piyushbansal | vrnithin : No, you must complete buildout to the extent that it either installs or throws an error while installing node dependent stuff. | 18:36 |
piyushbansal | I have only managed to install all packages except for node-wps. | 18:36 |
piyushbansal | Since I don't have much to do with js related stuff, I skipped that part. | 18:37 |
piyushbansal | So its more or less your pick, I would suggest that you let buildout compelete as much as it can | 18:37 |
piyushbansal | After that you can run local instance of the application ,as soon as a build folder is generated( by buildout) | 18:37 |
piyushbansal | I hope, I have made it sufficiently clear for you. | 18:38 |
*** piyushbansal is now known as piyushbansal|awa | 18:38 | |
*** piyushbansal|awa is now known as piyushbansal|bus | 18:39 | |
piyushbansal|bus | * charater limit on nick :| | 18:39 |
*** piyushbansal|bus is now known as piyush|away | 18:39 | |
*** carols has quit IRC | 18:46 | |
*** carols has joined #melange | 18:50 | |
*** saurabhsood91_ has joined #melange | 18:50 | |
*** saurabhsood91 has quit IRC | 18:51 | |
*** roonyH has joined #melange | 18:52 | |
*** Dragos__ has joined #melange | 18:59 | |
*** piyush|away is now known as piyushbansal | 19:02 | |
*** snizzo_ has joined #melange | 19:08 | |
*** snizzo has quit IRC | 19:08 | |
*** roonyH has quit IRC | 19:13 | |
*** Merio has quit IRC | 19:13 | |
*** Dragos__ has quit IRC | 19:15 | |
*** roonyH has joined #melange | 19:18 | |
*** carols has quit IRC | 19:21 | |
*** Strik3r has joined #melange | 19:22 | |
roonyH | Hi, I am a gsoc student | 19:23 |
roonyH | so as melange runs on gae, services offered from gae are available to melange. aren't they? | 19:24 |
*** robbyoconnor has joined #melange | 19:25 | |
*** hasil1 has joined #melange | 19:26 | |
nathanielmanista | Mostly, but Melange may or may not choose to avail itself of certain services. About which are you curious? | 19:26 |
roonyH | channel API | 19:27 |
*** sunu is now known as CookieThief | 19:33 | |
*** CookieThief is now known as sunu | 19:34 | |
*** hasil1 has quit IRC | 19:37 | |
*** hasil has joined #melange | 19:38 | |
*** haseeb has joined #melange | 19:46 | |
*** haseeb has left #melange | 19:46 | |
*** antrik has quit IRC | 19:52 | |
*** nikunj_ has joined #melange | 19:55 | |
*** antrik_ has joined #melange | 19:55 | |
*** robbyoconnor has quit IRC | 19:59 | |
*** robbyoconnor has joined #melange | 20:01 | |
* rihnapstor says gn :) | 20:03 | |
*** nikunj_ has quit IRC | 20:03 | |
*** rihnapstor has quit IRC | 20:03 | |
*** Hamish_B has joined #melange | 20:04 | |
*** vrnithin has quit IRC | 20:09 | |
*** jenmylo has quit IRC | 20:12 | |
*** r0bby has joined #melange | 20:17 | |
*** saurabhsood91_ has quit IRC | 20:18 | |
*** robbyoconnor has quit IRC | 20:18 | |
nathanielmanista | roonyH: What would you have in mind for it? | 20:26 |
roonyH | I am interested in the Messaging System project | 20:30 |
*** snizzo_ has quit IRC | 20:30 | |
*** hasil has quit IRC | 20:30 | |
roonyH | I have a feeling the channel API will be helpful | 20:30 |
nathanielmanista | Possibly! | 20:31 |
roonyH | :) great | 20:32 |
*** r0bby has quit IRC | 20:38 | |
roonyH | and what are the issues in the issue tracker that a student like me could work in. I am experienced with python and have some experience with appengine | 20:38 |
roonyH | should I look for a trivial one? | 20:38 |
roonyH | i also see some accepted issues are reported long ago. Is it ok to work even on them? | 20:40 |
downey | roonyH: Each organization maintains its own issue trackers, so you'll need to contact them directly to better understand what work is available to do and how the tracker is used by them | 20:45 |
downey | sorry, i mis-read that thinking i was in #gsoc, you can ignore my comments roonyH :-) | 20:45 |
* downey goes and finds caffeine | 20:45 | |
*** Uli- has left #melange | 20:46 | |
roonyH | downey: :D no worries. I think I should do the same. Its 2 am here. | 20:48 |
roonyH | :me goes and checks out #gsoc | 20:49 |
*** DrJoel has joined #melange | 20:50 | |
DrJoel | I wonder if anyone could help me with the connections | 20:50 |
piyushbansal | Hi nathanielmanista | 20:56 |
piyushbansal | I was looking at /tests/app/soc/logic/test_cleaning.py | 20:57 |
piyushbansal | I noticed that one or two methods from soc.logic.cleaning could be unit tested for more robustness, what do you think ? | 20:58 |
piyushbansal | I am talking about testing clean_birth_date and clean_irc etc .. | 20:58 |
piyushbansal | Lennie ^ | 20:59 |
Lennie | DrJoel, melange-soc-dev@gg is your best bet | 21:01 |
Lennie | piyushbansal, one sec | 21:01 |
piyushbansal | Lennie : yeah , sure :) | 21:01 |
Lennie | piyushbansal, yes those would be welcome additions | 21:01 |
DrJoel | Lennie thanks.. maybe you know before I ask.. connections initiated by mentor seem to work.. but the connections initiated by me inviting folks can't be accepted. | 21:02 |
Lennie | DrJoel, interesting. I got invited to be a mentor and it worked for me | 21:02 |
DrJoel | I can't even accept my own invite to be a mentor for RTEMS | 21:03 |
Lennie | Are they missing a link/ | 21:03 |
Lennie | DrJoel, you are already an org admin right? | 21:03 |
DrJoel | yes | 21:03 |
Lennie | Therefore also a Mentor | 21:03 |
Lennie | the fact that you can create such a request is a bug | 21:03 |
DrJoel | oh.. no longer separate roles... | 21:03 |
Lennie | They haven't been for 1 or 2 years | 21:03 |
DrJoel | once a year and I barely remember how to fill in the forms :) | 21:03 |
DrJoel | that explains my error. | 21:04 |
Lennie | we decided to have the once a year Melange trouble at the beginning :p | 21:04 |
Lennie | At least AppEngine scaled this time | 21:04 |
DrJoel | Our co-admin during proposal season ended up dropping himself to a mentor | 21:04 |
DrJoel | what do I need to do to bump him back up | 21:04 |
Lennie | Invite him as an org admin? | 21:05 |
Lennie | I'm not sure how though since I wasn't involved in this rewrite | 21:05 |
Lennie | Also I got to run | 21:05 |
DrJoel | ok.. thanks.. the org admin=mentor helped | 21:05 |
Lennie | Yeah afaik that is true | 21:06 |
DrJoel | I will email the list. I deleted the co-admin turned mentor and can't reinvite him to be admin even though he isn't in the list anymore :( | 21:08 |
piyushbansal | Lennie : okay, then I better get started :D | 21:20 |
*** carols has joined #melange | 21:21 | |
*** roonyH has quit IRC | 21:32 | |
*** haseeb has joined #melange | 21:35 | |
*** haseeb has left #melange | 21:35 | |
*** carols has quit IRC | 21:36 | |
*** DrJoel has quit IRC | 21:51 | |
*** SinnerShanky has quit IRC | 21:57 | |
piyushbansal | Lennie : I am running the application locally, I was wondering if line no 38 in soc/app/soc/logic/validate.py would execute | 21:57 |
piyushbansal | More specifically if google appengine's urlfetch would fail, I believe it should, what do you say ? | 21:58 |
*** SinnerShanky has joined #melange | 22:00 | |
*** Hamish_B has left #melange | 22:02 | |
*** manugupt1 has quit IRC | 22:05 | |
*** manugupt1 has joined #melange | 22:08 | |
*** manugupt1 has joined #melange | 22:08 | |
*** JoergH has joined #melange | 22:31 | |
*** mang0 has joined #melange | 22:44 | |
*** mang0 has joined #melange | 22:44 | |
piyushbansal | nathanielmanista : I wanted to ask something about one of the methods that you worked on | 22:46 |
nathanielmanista | I'm listening; ask away. :-) | 22:49 |
*** Strik3r has quit IRC | 22:51 | |
piyushbansal | yeah, I was wondering if we needed unit tests for clean_birth_date method | 22:52 |
piyushbansal | The validate function for DOB is alreeady there, but it still might be of use to have different method for cleaning logic tests | 22:52 |
piyushbansal | What do you say ? | 22:53 |
*** Strik3r has joined #melange | 22:53 | |
*** dreimark has quit IRC | 22:54 | |
*** dreimark has joined #melange | 22:54 | |
nathanielmanista | I worked on that? Huh. | 22:55 |
nathanielmanista | Oh right, I worked on isAgeSufficientForProgram. | 22:56 |
nathanielmanista | Yes, unit tests for clean_birth_date would be appropriate. | 22:56 |
nathanielmanista | It's not at all harmful that in cases in which code B calls code A that code B's tests will show either overlap with or similarity to code A's tests. | 22:57 |
piyushbansal | Okay great, I would work on it then :) | 22:57 |
piyushbansal | But wouldn't this overlap cause the overall process to be slow ? | 22:57 |
piyushbansal | Just wondering. | 22:57 |
piyushbansal | I mean, when we would be refactoring tests, this overlap would have to be removed, correct me if I am wrong here :D | 22:58 |
nathanielmanista | There's some variation, but in practice it's not a problem. Say in the case above that code A's public interface changes. | 22:59 |
nathanielmanista | code A's test will have to change, and code B's call site of code A will have to change, but if you've done things correctly... | 23:00 |
nathanielmanista | code B's test only contains a call site of code B and does not contain a call site of code A, and thus code B's test won't have to change. :-) | 23:00 |
piyushbansal | Yeah, you're right | 23:00 |
piyushbansal | We would just be building another abstraction layer over code B. | 23:01 |
piyushbansal | So that we are able to interface with internal methods of code b via a public interface | 23:01 |
piyushbansal | RIght :D | 23:01 |
piyushbansal | Similarly I have submitted a patch for clean_irc and clean_mailto methods , both of these didn't have cleaning unit tests. | 23:02 |
nathanielmanista | Cool. | 23:25 |
*** asmeurer__ has joined #melange | 23:37 | |
*** harlan_ has joined #melange | 23:38 | |
*** asmeurer has quit IRC | 23:38 | |
*** asmeurer__ is now known as asmeurer | 23:38 | |
*** harlan has quit IRC | 23:38 | |
*** piyushbansal has quit IRC | 23:51 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!