| *** tpb has joined #melange | 00:00 | |
| * Erant prods SRabbelier | 02:07 | |
| *** nuba has quit IRC | 02:51 | |
| *** kusum has joined #melange | 02:56 | |
| kusum | SRabbelier: hello | 02:57 |
|---|---|---|
| *** kusum has left #melange | 03:02 | |
| *** solydzajs has joined #melange | 04:58 | |
| *** ChanServ sets mode: +o solydzajs | 04:58 | |
| *** schmrz has joined #melange | 05:40 | |
| SRabbelier | Erant: because img tags are harmless? | 06:07 |
| SRabbelier | Erant: of course, if you can do nasty XSS with those img tags | 06:07 |
| SRabbelier | Erant: then please do tell us :P | 06:07 |
| schmrz | Hi. I'm getting this error when running melange: ImproperlyConfigured: Error importing middleware app_profiler.app_profiler: "No module named pstats". python-stats is installed. | 06:36 |
| schmrz | Any ideas ? | 06:36 |
| schmrz | Resolved. I forgot about python-profiler. | 06:40 |
| *** schmrz has left #melange | 09:00 | |
| *** nuba has joined #melange | 09:49 | |
| *** solydzajs has quit IRC | 11:05 | |
| *** Merio has joined #melange | 11:07 | |
| *** ChanServ sets mode: +v Merio | 11:07 | |
| *** dhaun has joined #melange | 11:55 | |
| *** schmrz has joined #melange | 12:26 | |
| *** Merio has quit IRC | 13:00 | |
| *** Merio has joined #melange | 13:04 | |
| *** ChanServ sets mode: +v Merio | 13:04 | |
| schmrz | I'm thinking of writing a "system" for document versioning (mainly for melange) which would be independant of the editor. What features would you (melange devs) need in that system ? | 13:05 |
| schmrz | Except diffs for revision history | 13:06 |
| schmrz | Anyone ? | 14:00 |
| SRabbelier | schmrz: heya :) | 14:36 |
| schmrz | SRabbelier: Hey there :) | 14:40 |
| schmrz | This channel isn't really busy, isn't it :) | 14:40 |
| SRabbelier | schmrz: no, it's not :D | 14:40 |
| SRabbelier | schmrz: you amir? | 14:41 |
| schmrz | So, I saw a post of the upcoming ghop so I though to give a hand | 14:41 |
| schmrz | Yes | 14:41 |
| SRabbelier | schmrz: ok, so the best thing you can do is chat on here with me for a while :P, and then send an email to melange-soc-dev | 14:41 |
| schmrz | ok :) | 14:41 |
| SRabbelier | schmrz: so the idea of 'modules' in melange is that you create a Callback object, which tells us 1. which urls you wish to handle and 2. what sidebar links we should add for your module | 14:42 |
| SRabbelier | with urls being say /document/* | 14:42 |
| SRabbelier | a django url pattern in any case | 14:42 |
| schmrz | I have never actively participated in ghop so I can't help with the overall structure of melange or some core-deep features but I think that I could implement a document versioning system. | 14:43 |
| schmrz | that makes sense | 14:43 |
| schmrz | But before I go into writting the system I would like to know what is needed in a system like that one. (my english sucks btw) | 14:44 |
| schmrz | Maybe write some design docs first... | 14:44 |
| SRabbelier | schmrz: meh, we're not that much a fan of design docs :P | 14:46 |
| SRabbelier | schmrz: have you used the socghop.appspot.com site at all btw? | 14:46 |
| SRabbelier | schmrz: it'd be easier to explain what we need if you had :) | 14:47 |
| schmrz | Yes, I have. | 14:47 |
| schmrz | Today :) | 14:47 |
| SRabbelier | schmrz: we need a replacement for the document editor, you can see it when you click "Create new document" under your user menu | 14:48 |
| schmrz | Yeah, I noticed it ( tinyMCE) | 14:49 |
| SRabbelier | schmrz: (please prefix your msgs with SRabbelier, or it'll take a while for me to notice you said anything) | 14:49 |
| schmrz | SRabbelier: ok | 14:50 |
| SRabbelier | schmrz: anyway, what we would want is something different in it's place | 14:50 |
| SRabbelier | schmrz: something that keeps track of revisions of files | 14:50 |
| SRabbelier | schmrz: and something with a decent editor | 14:50 |
| SRabbelier | schmrz: the only requirement is that whatever you implement runs on appengine, and outputs (sanitized) html | 14:51 |
| schmrz | SRabbelier: Hmm... I didn't think a lot about the actual editor, although it shouldn't matter. When it comes to sanitizing html output, I have noticed HtmlSanitizer.py, should I use that or ... ? | 14:54 |
| SRabbelier | schmrz: yes, you can use that our existing sanitizer, but preferrably a different editor than TinyMCE | 14:55 |
| schmrz | SRabbelier: Do you have a specific preference over the proposed alternatives ? | 14:56 |
| schmrz | HtmlBox, Markdown, Wikimarkdown | 14:56 |
| SRabbelier | schmrz: I kinda like the idea of using (wiki)Markdown myself | 14:56 |
| schmrz | SRabbelier: Yeah, I use Markdown in my projects too. | 14:57 |
| schmrz | SRabbelier: What I aim for is to be able to change the editor without losing the revision tracking abilities, so my choice wont really matter. | 14:58 |
| SRabbelier | schmrz: that'd be cool :) | 14:59 |
| schmrz | SRabbelier: The models/views in soc are quite confusing for a newcomer so I might need help with that. ( I just downloaded the code today or was it yesterday ) | 15:02 |
| SRabbelier | schmrz: it'd be great if we could work out what's confusing about them | 15:02 |
| SRabbelier | schmrz: and document that/ fix it | 15:02 |
| schmrz | SRabbelier: Well it's probably me whining, but we'll see in few days ;) I'm looking at the Work & Review models. Basicaly work is the base for document and Review is a model for document comments, right ? | 15:05 |
| SRabbelier | schmrz: both correct | 15:05 |
| schmrz | SRabbelier: Now, should I use Work as the base for my implementation of documents. I was thinking of implementing a one-to-many rel. betwen Document and DocumentRevision. One Document can have many DocumentRevision. But this means that the actual Document wont have the content field as that will be a part of DocumentRevision. | 15:08 |
| * Erant prods SRabbelier | 15:09 | |
| Erant | OI | 15:09 |
| SRabbelier | schmrz: lgtm | 15:09 |
| SRabbelier | Erant: whatddyawant? | 15:09 |
| Erant | Why can I still put <img> tags in a comment? | 15:09 |
| SRabbelier | Erant: as said, because img tags are failry innocent | 15:10 |
| SRabbelier | Erant: unless you can do nasty XSS with them ofc | 15:10 |
| SRabbelier | Erant: which you shouldn't be able to, sicne they're sanitized | 15:10 |
| Erant | <img src=http://melange-demo.appspot.com/_ah/logout> </img> | 15:11 |
| Erant | For example | 15:11 |
| schmrz | SRabbelier: Is Work used only as a base for Document or is it used somewhere else to ? | 15:11 |
| schmrz | *too | 15:12 |
| SRabbelier | Erant: wossitdo? | 15:12 |
| schmrz | Erant: that works ? :0 | 15:12 |
| SRabbelier | schmrz: it's used by survey too | 15:12 |
| schmrz | So I shouldn't touch that. :) | 15:13 |
| SRabbelier | schmrz: best not :) | 15:13 |
| SRabbelier | schmrz: you could of course create a new entity | 15:13 |
| SRabbelier | schmrz: call it RevisionedDocument or such | 15:13 |
| Erant | schmrz: Ofcourse that works. | 15:13 |
| schmrz | SRabbelier: that's probably what I will do | 15:14 |
| SRabbelier | schmrz: and then... RevisionedDocumentRevision :P | 15:14 |
| schmrz | haha :) | 15:14 |
| SRabbelier | Erant: will it log you out as soon as you visit the page? | 15:14 |
| Erant | SRabbelier: Yah. I'll look into it some more, if I find time. | 15:14 |
| SRabbelier | Erant: for shame :P | 15:14 |
| Erant | Right now, I have other matters of security. | 15:14 |
| SRabbelier | Erant: $dayjob related? :P | 15:16 |
| Erant | Yah | 15:16 |
| Erant | <img src=http://melange-demo.appspot.com/student/manage/google/gsoc2009/erant?resign=true> </img> <-- Before I leave, just imagine the ramifications of this ;) | 15:27 |
| tpb | <http://ln-s.net/4-_D> (at melange-demo.appspot.com) | 15:27 |
| *** Merio has quit IRC | 16:19 | |
| *** Merio has joined #melange | 16:19 | |
| *** ChanServ sets mode: +v Merio | 16:19 | |
| *** schmrz has quit IRC | 17:29 | |
| *** schmrz has joined #melange | 17:30 | |
| schmrz | SRabbelier: How come tinyMCE is not shown in my instance of melange (running on dev_appserver) ? | 17:35 |
| SRabbelier | Erant: mhhh, and that works too? those should be POST actions... | 17:36 |
| SRabbelier | schmrz: did you run build.sh? | 17:36 |
| schmrz | ugh no | 17:36 |
| SRabbelier | :) | 17:36 |
| SRabbelier | schmrz: we have a build script too that doesn't use bash | 17:36 |
| SRabbelier | schmrz: uhm, I must admit I don't use it though :D | 17:37 |
| schmrz | SRabbelier: haha | 17:37 |
| schmrz | SRabbelier: what does build.sh do ? | 17:37 |
| schmrz | SRabbelier: because the app was running just fine without it :) | 17:37 |
| Erant | SRabbelier: It's how the link is defined in the Resign tab | 17:37 |
| Erant | I didn't actually try it. | 17:37 |
| SRabbelier | Erant: yes, it will work | 17:37 |
| SRabbelier | Erant: I'm saying, we should change our code | 17:38 |
| SRabbelier | Erant: so that it requires a POST action | 17:38 |
| Erant | schmrz: It... builds stuff? | 17:38 |
| SRabbelier | schmrz: I forget, I think it zips up stuff to make tinymce work | 17:38 |
| Erant | SRabbelier: Yah, want me to file a bug? | 17:38 |
| SRabbelier | Erant: durr, maybe? :P | 17:39 |
| Erant | (Would there be a way to do this for logging out too?) | 17:39 |
| SRabbelier | Erant: describe it as "modification actions should be POST, not GET"? | 17:39 |
| SRabbelier | Erant: no, I think that's just how appengine is | 17:39 |
| Erant | Something like that | 17:39 |
| Erant | Well, you could redirect it. | 17:39 |
| Erant | Unless you have no control over that actual link | 17:39 |
| SRabbelier | Erant: I don't | 17:40 |
| SRabbelier | Erant: all _ah stuff is appengine controlled | 17:40 |
| Erant | k | 17:44 |
| Erant | Done, and done. | 17:44 |
| SRabbelier | Erant: so as to make actiosn what? :P | 17:48 |
| SRabbelier | I think you need an "impossible" somewhere | 17:48 |
| SRabbelier | oh, it's just moved at the end of a sentence | 17:49 |
| SRabbelier | uhm, that reads really weird :P | 17:49 |
| SRabbelier | it's a continued sentence, except there's no comma to indicate it is | 17:49 |
| *** dhaun has quit IRC | 17:58 | |
| Erant | Ah pfrt | 17:59 |
| schmrz | SRabbelier: I'm tangled in the views code. Can you help out :-) I can't find the actual code that is showing the document :\ | 18:04 |
| SRabbelier | schmrz: uhm, it's getting late here, but the actual showing is probably being done in soc.views.models.base | 18:04 |
| SRabbelier | schmrz: try adding a 'diaf' there to see which one | 18:05 |
| SRabbelier | I'd be more specific, but I really should be off to bed and need to finish this presentation :P | 18:05 |
| schmrz | SRabbelier: kk. It's getting late here too (Central Europe) 12:10AM :) | 18:05 |
| SRabbelier | same tz then | 18:06 |
| schmrz | SRabbelier: But I did check soc.views.models.base ... Nevermind, I will continue in the morning with a fresh cup of coffe :) | 18:07 |
| SRabbelier | schmrz: we really need to rework our view system, there's too much magic going on :P | 18:07 |
| schmrz | SRabbelier: yeah I really don't get the Views/Models part where Models are derived from base.View. Why are they called models ? :D | 18:08 |
| SRabbelier | wait, they're not | 18:09 |
| SRabbelier | models are derived from the base model class | 18:09 |
| SRabbelier | soc.models.base | 18:09 |
| SRabbelier | views are drived from the base view class | 18:09 |
| SRabbelier | soc.views.models.base | 18:09 |
| schmrz | Sure but I mix them with db.Models | 18:11 |
| schmrz | *as in mix them in my head :D | 18:11 |
| SRabbelier | schmrz: hehe | 18:11 |
| SRabbelier | db.Model is the base class to soc.models.base :P | 18:14 |
| SRabbelier | db.Model <- soc.models.base <- soc.models.work <- soc.models.document | 18:14 |
| schmrz | Yes and object <- soc.views.models.base.View <- soc.views.models.document.View :) | 18:17 |
| SRabbelier | schmrz: correcct | 18:17 |
| SRabbelier | schmrz: make more sense? | 18:19 |
| schmrz | When written in python-path style it makes sense but when browsing the source code repository for the first time... | 18:19 |
| schmrz | And I still haven't found the magic show for documents :D | 18:20 |
| SRabbelier | schmrz: time for bed here, I'm more than happy to give you a full tour tomorrow :) | 18:21 |
| schmrz | I will continue in the morning... | 18:21 |
| schmrz | Yeah :) | 18:21 |
| schmrz | Thank you and good night | 18:21 |
| SRabbelier | schmrz: you too! :) | 18:24 |
| *** schmrz has quit IRC | 18:26 | |
| *** mithro has quit IRC | 20:01 | |
| *** tansell has joined #melange | 20:23 | |
| *** mithro has joined #melange | 20:25 | |
| *** ChanServ sets mode: +v mithro | 20:25 | |
| *** Merio has quit IRC | 22:28 | |
| *** tansell_laptop has joined #melange | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!