| *** tpb has joined #melange | 00:00 | |
| *** arvind_khadri has joined #melange | 01:33 | |
| *** arvind_khadri has quit IRC | 02:09 | |
| *** arvind_khadri has joined #melange | 02:24 | |
| *** arvind_khadri has quit IRC | 03:03 | |
| *** madrazr has joined #melange | 04:02 | |
| *** ChanServ sets mode: +v madrazr | 04:02 | |
| *** dhaun has joined #melange | 04:27 | |
| *** jamtoday has joined #melange | 04:29 | |
| *** madrazr has quit IRC | 04:55 | |
| *** dukeleto_ has quit IRC | 05:11 | |
| *** dhans has joined #melange | 05:38 | |
| *** ChanServ sets mode: +v dhans | 05:38 | |
| *** dhans has quit IRC | 06:05 | |
| *** dhans has joined #melange | 06:45 | |
| *** ChanServ sets mode: +v dhans | 06:45 | |
| *** dhans has quit IRC | 06:46 | |
| *** dhans has joined #melange | 06:52 | |
| *** ChanServ sets mode: +v dhans | 06:52 | |
| *** Lennie has joined #melange | 07:19 | |
| *** ChanServ sets mode: +o Lennie | 07:19 | |
| *** Lennie sets mode: +v jamtoday | 07:19 | |
| Lennie | ajaksu: ping | 07:19 |
|---|---|---|
| ajaksu | Lennie: pong, good morning/afternoon :) | 07:20 |
| Lennie | ajaksu: Will there be any changes to the grade_field_form_2 patch? | 07:20 |
| ajaksu | Lennie: yes, fixing validation to never raise and adding good comments, sending it in 5 minutes :) | 07:21 |
| Lennie | ok | 07:21 |
| Lennie | then lunch comes first :) | 07:21 |
| Lennie | bbialb | 07:21 |
| *** Lennie is now known as Lennie|Food | 07:22 | |
| *** Lennie|Food is now known as Lennie | 07:45 | |
| Lennie | ajaksu: back :) | 07:46 |
| Lennie | ajaksu: going over that patch now thanks | 07:46 |
| ajaksu | Lennie: wb, thank you, I hope it works :) | 07:48 |
| Lennie | yes | 07:48 |
| Lennie | may I ask where the data kwarg is for? | 07:49 |
| Lennie | wtf works :D | 07:52 |
| Lennie | muhahahah | 07:53 |
| * Lennie dance | 07:53 | |
| Lennie | ^_^ | 07:53 |
| ajaksu | Lennie: it stores what usually is passed as the POST dict, in the db.Text patch I use it to build a list of fields which allow me to validate dynamic fields... | 08:03 |
| *** florinciu has joined #melange | 08:04 | |
| Lennie | ajaksu: it stores the field values as given? | 08:04 |
| ajaksu | Lennie: fills them in the form | 08:05 |
| Lennie | kind of initial value? | 08:05 |
| ajaksu | Lennie: wait, what are you asking about? :) | 08:05 |
| Lennie | data = self.kwargs.pop('data', {}) | 08:06 |
| ajaksu | Lennie: ah, data, lemme pick the doc... | 08:06 |
| Lennie | Its use confuses me a bit :) | 08:06 |
| Lennie | I know it must make sense :P | 08:06 |
| Lennie | my current description is data: dictionary containing data that fields contain | 08:06 |
| ajaksu | Lennie: "In this dictionary, the keys are the field names, which correspond to the attributes in your Form class. The values are the data you're trying to validate. These will usually be strings, but there's no requirement that they be strings; the type of data you pass depends on the Field, as we'll see in a moment." | 08:09 |
| ajaksu | http://docs.djangoproject.com/en/dev/ref/forms/api/#bound-and-unbound-forms | 08:09 |
| tpb | <http://ln-s.net/3SQN> (at docs.djangoproject.com) | 08:09 |
| Lennie | interesting though | 08:09 |
| Lennie | it feels weird | 08:09 |
| Lennie | data you want to validate | 08:09 |
| Lennie | but in getFields you give another set of data right? | 08:10 |
| Lennie | one day we'll get rid of getFields :P | 08:11 |
| Lennie | if we're lucky | 08:11 |
| ajaksu | Lennie: yup, in getFields we pretend we're being passed real data :) | 08:11 |
| *** madrazr has joined #melange | 08:16 | |
| *** ChanServ sets mode: +v madrazr | 08:16 | |
| ajaksu | Lennie: radio fixed (stupid mistake), can I reply to the thread you mention the issue in or is a new thread better? one line fix... | 08:16 |
| Lennie | hehe too bad you are not a project member ^_^ | 08:17 |
| Lennie | might have been your first own push | 08:17 |
| Lennie | yes reply in that thread is fine | 08:17 |
| Lennie | ajaksu: forgot to add you to authors :P | 08:19 |
| Lennie | oh you are not even in the main file as well | 08:20 |
| Lennie | so done: ) | 08:22 |
| Lennie | haha | 08:23 |
| Lennie | choicefield | 08:23 |
| Lennie | haha | 08:23 |
| Lennie | what a fix :D | 08:23 |
| ajaksu | Lennie: great timing, you might have skipped adding me there if you saw that fix before committing :D | 08:24 |
| Lennie | hehe :P | 08:24 |
| Lennie | actually the policy is that you should have been in that file from commit nr1 :) | 08:24 |
| ajaksu | Lennie: thanks for including me, I hope my case for a free license of https://wingware.com/store/prices will be much stronger with that :) | 08:25 |
| tpb | Title: Prices and Terms of Sale - Wingware Python IDE (at wingware.com) | 08:25 |
| Lennie | oh yes | 08:25 |
| Lennie | you should be able to mention melange :) | 08:25 |
| ajaksu | I wish their debugger would play a little nicer with the sdk (I have issues with continuing after an exception), but getting a console to poke at variables on exceptions is cool :) | 08:28 |
| Lennie | nice | 08:28 |
| Lennie | I don't have that :( | 08:28 |
| Lennie | however | 08:28 |
| Lennie | can you make a survey with a selection question | 08:28 |
| Lennie | and take a look | 08:28 |
| Lennie | seems to be broken | 08:28 |
| ajaksu | Lennie: looking into it | 08:29 |
| ajaksu | Lennie: missed one line when splitting, sending patch | 08:31 |
| Lennie | thanks | 08:38 |
| Lennie | hmm | 08:38 |
| Lennie | I send you an error message ^_^ | 08:38 |
| Lennie | if this patch fixes that cool | 08:38 |
| Lennie | you want anything to do :D? | 08:38 |
| ajaksu | Lennie: it should fix that, yes :) | 08:38 |
| *** Merio has joined #melange | 08:40 | |
| *** ChanServ sets mode: +v Merio | 08:40 | |
| ajaksu | Lennie: I was thinking of implementing your 'if POST dict, forget survey_record' idea: it would solve an issue with pick_multi not recording its new empty state after you have submitted it something checked once | 08:40 |
| Lennie | ok | 08:41 |
| Lennie | go for it | 08:41 |
| Lennie | I'm doing access checks | 08:41 |
| ajaksu | Lennie: and I'd like to get the import patch in, as that will allow us to build the survey on our test instances, tune JSON by hand if we want to, then import in the soc instance | 08:41 |
| Lennie | yes | 08:41 |
| Lennie | unfortunately I find that low priority :P | 08:41 |
| Lennie | If you are lucky I can take a look at it soon | 08:42 |
| Lennie | if all goes well | 08:42 |
| Lennie | Merio: If you have more CSS/JS fixes go for it | 08:42 |
| ajaksu | Lennie: ok, I hope I'm lucky :) | 08:43 |
| Lennie | yeah ^_^ | 08:44 |
| Merio | Lennie: going to do them in a hour after lunch. I'll go to Windows and try to fix something. Problem is that still I can't understand why those divs are hidden, because I can't find a statement anywhere | 08:44 |
| Lennie | Sorry for that | 08:44 |
| Lennie | but it can be easily done by hand :p | 08:44 |
| Lennie | Merio: might be templating error somewhere? | 08:44 |
| Lennie | Merio: I have no clue :P | 08:44 |
| Lennie | Merio: Back to access checks form e:) | 08:44 |
| Merio | Lennie: neither am I. James says that they're hidden, but I can't find where is stated that they're hidden. As soon as I put a clear:right they starts to appear. So there is something strange going up there, going to inspect it :) | 08:45 |
| Lennie | ^^ | 08:45 |
| Lennie | cool | 08:46 |
| Merio | Lennie: But I'm seeing now all the thread, so I'll see what you all said about style issues. Are the open issues stated somewhere in the thread? | 08:47 |
| Lennie | no | 08:47 |
| Lennie | there is no open issues list I know off for style | 08:47 |
| Lennie | maybe on their github? | 08:47 |
| Lennie | afaik | 08:48 |
| Lennie | Safari 4.0 still looks ugly :p | 08:48 |
| Merio | Ok so I'll look only for Safari 4.0 issues (at least Windows version ^__^) | 08:48 |
| Lennie | have not given it a spin on my windows machine (lol that I'd ever say that) | 08:48 |
| Lennie | The mac is taking me over :( | 08:48 |
| ajaksu | Merio: we have a ui.all.css file and jquery might be hidding them in JS, no? | 08:49 |
| Merio | ajaksu: well, to be fair I didn't see ui.all.css file. I've tried to see survey-edit js and soc css but I didn't find anything about that. Strange thing is that they appear if I add clear:right. But I'll dig further into it today | 08:52 |
| ajaksu | Merio: thanks again :) | 08:54 |
| *** madrazr has quit IRC | 08:54 | |
| Merio | ajaksu: np ^__^ | 08:55 |
| Merio | ajaksu: thank you for your effort on that :) | 08:55 |
| *** dhans has quit IRC | 09:01 | |
| ajaksu | Lennie: any urgent tasks? | 09:29 |
| Lennie | hmm | 09:31 |
| Lennie | what do you want to do, custom tooltips or fixing the fact that the form always goes into error mode when you are taking the survey for the first time or seeing the preview? | 09:31 |
| ajaksu | Lennie: form in error mode, thanks :) | 09:33 |
| Lennie | ok | 09:33 |
| Lennie | testcase: make a required question, save the survey, go to the public or take page | 09:33 |
| Lennie | and see for yourself :) | 09:33 |
| Lennie | Merio: If you have the time http://code.google.com/p/soc/source/detail?r=8f29bfb9eb52637f15f04a9b09e6e450a1cf7345 | 09:39 |
| tpb | <http://ln-s.net/3SS4> (at code.google.com) | 09:39 |
| Lennie | just a quick +1 should be enough :) | 09:40 |
| *** madrazr has joined #melange | 09:42 | |
| *** ChanServ sets mode: +v madrazr | 09:42 | |
| *** dr__house has joined #melange | 09:43 | |
| ajaksu | Lennie: found a fix (don't pass data={} on init if not self.survey_record), but ISTM it would disable the db.Text hack on first taking... testing | 09:55 |
| Lennie | hmm | 09:56 |
| Lennie | k | 09:56 |
| Lennie | sounds not so good | 10:00 |
| Lennie | I wonder why it happens | 10:01 |
| Lennie | I thought it would only happen when a validation has occured | 10:01 |
| Lennie | strange that a new form thinks we are giving it data to validate ;S | 10:28 |
| ajaksu | Lennie: we are, that's 'data', but I think I'm close to fixing this :) | 10:38 |
| Lennie | ok | 10:38 |
| Lennie | cool | 10:38 |
| Lennie | so | 10:45 |
| Lennie | taking access checks are in ^^ | 10:45 |
| Lennie | I'm gonna get a drink brb | 10:45 |
| ajaksu | cool :) | 10:46 |
| ajaksu | k :) | 10:46 |
| Merio | Lennie: ok, going to have a look (sorry I was at lunch :)) | 10:48 |
| Merio | Lennie: I was forgetting... I overlooked the fact that I'll be travelling to Italy from 6, but 6 is a Monday, so I'll be missing the conference call :( | 10:48 |
| Lennie | ok | 10:48 |
| Lennie | don't forget to post a blog update :) | 10:49 |
| Merio | Lennie: I mean, I have to catch the plane at 20:45 (Dublin time) | 10:49 |
| Lennie | have fun at the wedding :P? | 10:49 |
| Merio | Lennie: yep, going to do that | 10:49 |
| Merio | Lennie: well, hope so... will tell you after 11 :D | 10:49 |
| Lennie | hehe | 10:49 |
| Merio | Lennie: however if I can find something with Skype I'll try to get in :) | 10:50 |
| Lennie | ajaksu: I can't apply the db.Text patch ( | 10:50 |
| Lennie | :( | 10:50 |
| Lennie | and I lack a good diff viewer in my mac | 10:51 |
| ajaksu | Lennie: I'll update it | 10:51 |
| Lennie | thanks | 10:51 |
| Lennie | omg I'm an idiot | 10:56 |
| Lennie | I thought something had broken but I was actually just a host for the program I was testing stuff for | 10:56 |
| Lennie | roflmao | 10:57 |
| ajaksu | Lennie: done, but maybe we need to test the grade field again after this goes in :) | 10:57 |
| Lennie | ok | 10:57 |
| Lennie | boo :P | 10:57 |
| ajaksu | boo? | 10:58 |
| Lennie | access checks seem to be working as expected | 10:58 |
| Lennie | yes boooo (N) breaking stuff is my job :) | 10:58 |
| Lennie | ajaksu: do I need to test it for the db.Text patch? | 11:00 |
| * ajaksu went to the just sent patch: 'OMG, how did I paste something so broken?'... clicking - Show quoted text - made it better | 11:00 | |
| ajaksu | Lennie: well, I think I tested them together, but you know how these cross-patch tests go... | 11:00 |
| Lennie | :D | 11:01 |
| ajaksu | brb, food :) | 11:02 |
| Lennie | ok | 11:03 |
| Lennie | ajaksu: ping me when you are back | 11:07 |
| Merio | ajaksu: Lennie: don't know if it's already fixed, I'm reading mails I've missed just right now, what is the "double quotes" JS bug? | 11:21 |
| Lennie | no idea ^^ | 11:21 |
| Merio | Lennie: thx anyway :D | 11:21 |
| Lennie | ajaksu and jamtoday should know | 11:21 |
| Lennie | I've been too busy on the python side :P | 11:22 |
| Merio | Oh sorry didn't notice James was here | 11:22 |
| * Merio needs another coffee... or two :D | 11:22 | |
| ajaksu | Lennie: back (still hungry, but food should arrive soon :) | 11:24 |
| Lennie | hhehe | 11:24 |
| Lennie | you ordered :P? | 11:24 |
| ajaksu | Merio: let me get you a linky :) | 11:25 |
| Lennie | db.Text fix looks okay | 11:25 |
| Lennie | however | 11:25 |
| Merio | ajaksu: ok :) | 11:25 |
| Lennie | now when I do a multiple choice question all options are active | 11:25 |
| ajaksu | Lennie: yup, I even started getting read to cook something, but... I don't deserve having to eat the abomination I cook when I'm working so much :D | 11:26 |
| Merio | Lennie: done the +1 on revision, just a comment on style and a question about a commented line :) | 11:26 |
| ajaksu | Lennie: oh, great... lemme look into that after this: | 11:26 |
| Lennie | ajaksu: too bad you probably can't order with creditcard else I would have bought it for you :) | 11:26 |
| Lennie | Merio: tyvm | 11:26 |
| Merio | Lennie: www.tesco.ie, if you want I can give you my username and password, feel free to checkout something in the basket with your CC number if you feel like :D | 11:28 |
| Lennie | roflmao :P | 11:28 |
| Lennie | www.just-eat.nl if you want to deliver me something lol | 11:28 |
| Lennie | CC accepted :P | 11:29 |
| ajaksu | Merio: http://github.com/jamslevy/Melange/issues#issue/42 , survey-edit-090703.js:689 -> we lose text when options have double quotes | 11:29 |
| tpb | <http://ln-s.net/3SUv> (at github.com) | 11:29 |
| Merio | Lennie: eehehe ok will have a look at it :P | 11:29 |
| Lennie | roflmao :P | 11:29 |
| Merio | ajaksu: going to have a look | 11:29 |
| Lennie | most of the pizza/pasta stuff you'll know | 11:29 |
| ajaksu | Merio: thanks :) | 11:30 |
| Lennie | at least they look like italian names :P | 11:30 |
| Merio | Lennie: Yes, but as far as I know, for example here in Ireland they just inherit only the name :P | 11:30 |
| Lennie | not the taste :P | 11:30 |
| Lennie | you owe me a good pasta bolognese then :) | 11:31 |
| Lennie | and I'll get you something typically dutch when you are here lol | 11:31 |
| Merio | Lennie: sure I do :) But you should come in Rome and have a real pizza :) | 11:31 |
| Merio | Lennie: sure, looking forward to that! | 11:32 |
| Lennie | Rome is expensive for tourists ;( | 11:32 |
| Lennie | but I have an experienced guide :P? | 11:32 |
| Lennie | I'm Dutch I'm cheap :p | 11:32 |
| Merio | Lennie: sure you have :) And no needs for hotels ^__^ | 11:32 |
| Lennie | hahaah | 11:33 |
| Lennie | tempting offer rofl | 11:33 |
| * Lennie adds trip to Rome on his list of TODO's | 11:33 | |
| Lennie | the list is long so don't worry you'll be back in Italy before I get to that :P | 11:34 |
| Merio | #TODO (Lennie): come to Rome | 11:34 |
| madrazr | Merio: can you promise that to me too :P | 11:34 |
| Merio | madrazr: sure :) | 11:34 |
| madrazr | Merio: thank you!!! | 11:34 |
| Lennie | ok ajaksu | 11:35 |
| Lennie | I think it is good to combine the "all checked"-fix with the POST dict override patch | 11:35 |
| Lennie | since the problem still exists after applying that one | 11:36 |
| ajaksu | Lennie: got it, we were fetching content from survey_content, so agreed :) | 11:36 |
| Lennie | I can't uncheck all the boxes | 11:36 |
| Lennie | ok :) | 11:36 |
| Lennie | hehe | 11:36 |
| Lennie | that's the problem :P | 11:36 |
| Lennie | it's difficult to seperate them :( | 11:36 |
| Lennie | you know Merio pawel would say that you need to loose the : there :) | 11:37 |
| Lennie | # TODO(name) stuff " is the proper syntax :p | 11:37 |
| Lennie | sorry I'm too much into coding ^_^ | 11:37 |
| Lennie | making very very bad jokes | 11:37 |
| Merio | Lennie: eheh then I'll say him that to find the proper syntax (which I didn't remind, not too much into Python still :P) I just searched the trunk and got here | 11:38 |
| Merio | Lennie: http://www.google.com/codesearch?q=TODO+package%3Ahttp%3A%2F%2Fsoc\.googlecode\.com&origq=TODO&btnG=Search+Trunk | 11:38 |
| tpb | <http://ln-s.net/3SV8> (at www.google.com) | 11:38 |
| Merio | Lennie: and saw the first hit :P | 11:38 |
| Lennie | hahahah | 11:38 |
| Lennie | :D | 11:38 |
| Merio | :D :D | 11:39 |
| Lennie | actually I'm wrong as ussual | 11:39 |
| Lennie | it can be : | 11:39 |
| Lennie | as long as you start with a capital letter :) | 11:39 |
| Merio | Quite complex to get in :P | 11:39 |
| Lennie | yosh | 11:39 |
| ajaksu | Lennie: http://code.google.com/p/soc/source/browse/app/soc/views/models/survey.py?spec=svna023b71ce12595a4f76c95629a5d8a4d68b864f7&r=a023b71ce12595a4f76c95629a5d8a4d68b864f7#737 | 11:39 |
| tpb | <http://ln-s.net/3SV+> (at code.google.com) | 11:39 |
| Lennie | good task for GHOP | 11:39 |
| Lennie | find the inconsitencies :P | 11:39 |
| Lennie | he's wrong ajaksu :D | 11:40 |
| Lennie | I probably fixed that because I was going through some style comments | 11:40 |
| Lennie | but a colon is not needed | 11:40 |
| Lennie | if you don't start the description with a capital :D | 11:40 |
| Merio | What's the difference between starting the description with a capital or not? | 11:41 |
| ajaksu | Lennie: I read the style guide first and thought a colon was optional, then started adding them after I read that, now the rule depends on capitalization? is always adding a colon ok? :D | 11:41 |
| Lennie | you are right | 11:42 |
| Lennie | hehe | 11:42 |
| Lennie | ^_^ | 11:42 |
| Lennie | the rule is kinda crazy :P | 11:43 |
| ajaksu | Merio: you can only start with capital if it's a multi-line comment (or a class attribute, with a colon after # IIUC), simple, eh? :) | 11:43 |
| Lennie | :D | 11:43 |
| Lennie | every project got its quirks :P | 11:43 |
| Merio | and only if the weather outside is sunny and it doesn't rain in Alaska three times last week :P | 11:43 |
| ajaksu | * class attribute description :) | 11:43 |
| Merio | doesn't => didn't | 11:43 |
| Merio | :P | 11:43 |
| Merio | ajaksu: the problem is in line 689? | 11:45 |
| Merio | ajaksu: I mean, can you explain just a little bit more the problem? | 11:46 |
| ajaksu | Merio: sure :) | 11:46 |
| ajaksu | Merio: when we create a choice question, we have a textarea for quickly entering options, one per line | 11:47 |
| ajaksu | Merio: when the dialog is submitted, we split the textarea content on '\n' and build the options from that array | 11:47 |
| ajaksu | Merio: so the problem is probably on 689 or 698 (option_html), or the interaction of the two :) | 11:48 |
| Merio | ajaksu: it gives a JS error or it doesn't display the options? | 11:50 |
| ajaksu | Lennie: is adding the all-checkboxes-checked fix the only thing to go with the POST override patch? | 11:50 |
| ajaksu | Merio: it silently truncates on the first double quote in an option | 11:51 |
| Lennie | hmm | 11:53 |
| Lennie | I think so :P | 11:53 |
| Merio | ajaksu: ok going to have a look | 11:53 |
| Lennie | if the validationError goes through nicely when not selecting anythin on pick_multi then yes | 11:54 |
| Lennie | afaik I committed all your other patches | 11:54 |
| ajaksu | Lennie: yup, the validation still works | 11:55 |
| Lennie | okay didn't here ^_^ | 11:55 |
| Lennie | afaik that's the only thing | 11:55 |
| Lennie | did you epect someting lese? | 11:55 |
| Lennie | else | 11:55 |
| Lennie | *expect something else? | 11:55 |
| ajaksu | Lennie: I've got a fix for the errors on takeGet working, needs polish... | 11:56 |
| Lennie | then go eat and polish :)? | 11:56 |
| Lennie | you can sent them all in one big patch if you'd like | 11:56 |
| Lennie | whatever works out best for you | 11:56 |
| Lennie | Sorry Merio wrong button :P | 11:58 |
| ajaksu | Lennie: POST override only had a small change to avoid the checkboxes issue, good to commit if you don't find anything stoopid in there | 11:59 |
| Lennie | then sent it in :D | 11:59 |
| ajaksu | the errors fix should come after food :) | 11:59 |
| Lennie | oh already did :P | 11:59 |
| Lennie | you are fast :P | 11:59 |
| Merio | Lennie: what button? :) | 12:00 |
| ajaksu | Lennie: it's a jedi mind trick, you keep replying fast so people don't expect you to have sent anything in between :) | 12:00 |
| Lennie | ajaksu: roflmao :P | 12:00 |
| Lennie | Merio: skype I hit call :p | 12:00 |
| Lennie | Merio: apparently my cancellation skills own (or skype is so slow :P) that you didn't notice | 12:01 |
| Merio | Lennie: ah didn't warn me of anything :) | 12:01 |
| Lennie | ajaksu: ping | 12:21 |
| ajaksu | Lennie: pong | 12:22 |
| Lennie | the post should override previous record is not working as I expected it to :( | 12:22 |
| Lennie | if I always initate the form with a record | 12:23 |
| Lennie | it still uses data from that record even if I specify a post_dict on getFields | 12:23 |
| Lennie | the reason this problem popped up for me was because I'm now always constructing the form with a record | 12:24 |
| Lennie | it might be me though but it still seems to misuse the record when it is available next to the post_dict | 12:26 |
| ajaksu | Lennie: sorry, I hope it is going to be solved in the next patch, which changes setCleaners and __init__ to explicitely honor the post override | 12:26 |
| Lennie | ok | 12:27 |
| Lennie | I'm mailing you my patch ^^ | 12:27 |
| ajaksu | k :) | 12:30 |
| Lennie | it's in your inbox :P | 12:32 |
| Lennie | takeGet is gonna look boring :( | 12:34 |
| ajaksu | Lennie: you'll get what you need to have it in one line soon :) | 12:35 |
| Merio | Lennie: do we have already something in place to handle htmlentities and translate them to unicode before putting them into datastore? | 12:35 |
| Lennie | ajaksu: rofl mwah :P | 12:35 |
| Lennie | Merio: ? | 12:36 |
| Lennie | Merio: you mean some form of cleaner? | 12:36 |
| Lennie | me confused ^^ | 12:36 |
| Merio | Lennie: Actually problem for the JS double quotes bug is that they're stored into a "value" attribute of an input tag | 12:36 |
| Merio | Lennie: so, to have it stored properly I need to change double quotes to their HTML entity """ | 12:37 |
| Merio | Lennie: But then it is stored that way in the datastore. I would like to store it like double quotes | 12:37 |
| Merio | Lennie: so I need something that does " => " | 12:37 |
| Merio | Lennie: obviously if this is needed, otherwise well patch is ready :P | 12:39 |
| Lennie | hm | 12:41 |
| Lennie | not that I know of :( | 12:43 |
| ajaksu | Merio: lossy quoting is an alternative I find quite acceptable (double to single), but we might be prone to this sort of bug without some escaping | 12:49 |
| Merio | ajaksu: yes, I'm fixing this particular bug and sending the diff on dev list, but I don't know if it's needed somewhere else | 12:51 |
| ajaksu | Merio: did you get to run the survey edit UI? if so, pasting all sorts of garbage there could be interesting... is it XSS-prone? :) | 12:52 |
| Merio | ajaksu: actually still not tried to run a survey, I'll trying to. Are there particular bugs open I might help with (apart from Safari one, need to reboot on Windows to fix it) | 12:54 |
| ajaksu | Merio: we do have some pending JS bugs, I can push a fresh version to http://melange-ajaksu.appspot.com/ if that'd help you test | 12:56 |
| tpb | Title: Surveys demo instance (at melange-ajaksu.appspot.com) | 12:56 |
| Merio | Isn't the code pushed already in the main repository? | 12:57 |
| Merio | Otherwise I might pull your data from your repository (can't remember if I've the rights to do so however) | 12:58 |
| ajaksu | Merio: yep, what I meant was 'I can put the code in the public instance' :) | 12:58 |
| ajaksu | http://github.com/jamslevy/Melange/issues#issue/43 is actually a JS issue: we currently duplicate the edit UI in JS for adding new questions, the JS version is wrong here :) | 12:58 |
| tpb | <http://ln-s.net/3SX8> (at github.com) | 12:58 |
| Merio | ajaksu: going to have a look :) In the meantime, patch for #42 sent to dev list :) | 13:01 |
| Lennie | what does this patch influence? | 13:02 |
| Lennie | Merio: | 13:02 |
| Merio | Lennie: the edit survey javascript. It only substitutes " with " before pushing options fields names into hidden inputs | 13:02 |
| *** scorche has quit IRC | 13:02 | |
| Lennie | hmm ok | 13:03 |
| Merio | Lennie: Tested with " went well with Python roundtrip, Django parsed it well, so they turned to be double quotes again :) | 13:03 |
| Merio | ajaksu: can you give me further informations to begin with issue #43? I don't have a clue of what's the matter :P | 13:03 |
| Lennie | so you can store survey answers with " when it comes to selection questions? | 13:03 |
| ajaksu | Merio: getting linky :) | 13:05 |
| Merio | Lennie: Yes. At least In edit survey it stores them fine and retrieves them back. Didn't test what the rendering in the actual survey is, but I think it won't be different | 13:05 |
| Lennie | you can push that one yourself then :) | 13:06 |
| ajaksu | Merio: adding a choice question is supposed to add something very much like what this template generates: http://code.google.com/p/soc/source/browse/app/soc/templates/soc/survey/universal_choice_editor.html | 13:06 |
| tpb | <http://ln-s.net/3SXY> (at code.google.com) | 13:06 |
| Merio | Lennie: flattened, going to ^_^ | 13:07 |
| Lennie | roflmao | 13:07 |
| Lennie | flattened :P | 13:07 |
| Lennie | did an elephant sit on your lap? | 13:07 |
| ajaksu | Merio: but we have this instead (and boy should I fix our arrays for looks): http://code.google.com/p/soc/source/browse/app/soc/content/js/survey-edit-090703.js#648 | 13:07 |
| tpb | <http://ln-s.net/3SX_> (at code.google.com) | 13:07 |
| ajaksu | Lennie: real close now | 13:08 |
| Merio | Lennie: ahahah n=>r :D | 13:08 |
| Lennie | ajaksu: no rush, I'm hungry | 13:08 |
| Lennie | ajaksu: I'm gonna see if I can make myself dinner | 13:08 |
| Lennie | there are two more issues I know about | 13:09 |
| Lennie | custom tooltips :) | 13:09 |
| ajaksu | Lennie: that's a good sign, usually I have to see if I can eat the dinner I make :) | 13:09 |
| Lennie | and that the comments for multi_pick questions dissapear if the form validation fails | 13:10 |
| Lennie | while for other fields they work | 13:10 |
| Lennie | oh | 13:11 |
| Lennie | hmm | 13:11 |
| ajaksu | Lennie: hmm, didn't notice the second one, I'll take a look at it after I submit this patch | 13:11 |
| Lennie | recent JS work screwed someting up there | 13:11 |
| Lennie | maybe something for Merio :D | 13:11 |
| Lennie | currently the text put in there is greyed when form fails | 13:11 |
| Lennie | and when I click it it is all gone :( | 13:11 |
| Lennie | and for multi_pick it stil forgets :( | 13:12 |
| ajaksu | Lennie: saw that, it's the custom prompt magic working bad... maybe we could decide having custom prompts in the input widget is simply bad and remove it? | 13:12 |
| Merio | Lennie: will have a look at it too if time permits :) | 13:12 |
| Lennie | ajaksu: I'm +1 on that and just have the tooltips | 13:13 |
| Lennie | oh it all goes gray now | 13:13 |
| Lennie | hm | 13:13 |
| Merio | ajaksu: Hmm what are the differences between them, it's a little bit difficult to go through the array and comparing the two | 13:13 |
| Lennie | I'll be back later | 13:13 |
| Merio | ajaksu: oh nm, it's the "question type drop down" which is missing? | 13:14 |
| ajaksu | Merio: we only have render_for_ in JS, not type... yep, that's it :) | 13:15 |
| Merio | ajaksu: what happens if you add it to the array? Sorry about that, but I'm not so much into the overall working | 13:16 |
| ajaksu | Merio: do you think we could store that choice question widget in HTML and replicate it in JS when a new choice question is added? | 13:16 |
| ajaksu | Merio: that array is what renders a new choice question widget, so we'd have a newly created widget that matched those generated from our django template :) | 13:17 |
| *** scorche has joined #melange | 13:19 | |
| Merio | ajaksu: No I was meaning... why did you cut it out? What's happening with question type? | 13:20 |
| ajaksu | Merio: I promise I'll add *a lot* of comments to our JS if I survive deployment :) | 13:21 |
| Merio | ajaksu: ehehe no problems code is enought clear. It's that I can't understand what is the bug, what's the problem, so it's difficult to debug it :P | 13:21 |
| ajaksu | Merio: AFAIK, james removed it accidentaly (he was trying to match type with render, since we reverted to a 1:1 association) ... we still use it when the select is rendered :) | 13:22 |
| ajaksu | Merio: bug is simply that it's missing a part of the UI on the JS created version :) | 13:22 |
| Merio | ajaksu: the bug text says "This field was taken out because certain question types don't match with certain rendering types, but it is reverted on editing surveys. Unable to find the cause so far. Looks like maybe the HelperForm being called." | 13:23 |
| Merio | ajaksu: so it seems it has been taken out for a reason... but it's the reason I can't get :P | 13:24 |
| ajaksu | Merio: oops, I misread the bug... well, the Python side still believes we have the two selects there AFAIK, lemme check :) | 13:24 |
| ajaksu | Merio: the reason would be the current 1:1 relation of type and render, but I have to see if python code is ready to work with a single select there :) | 13:25 |
| Merio | ajaksu: well... so in the meantime if you want... just point me to the next bug ^__^ | 13:28 |
| *** dukeleto has joined #melange | 13:29 | |
| ajaksu | Merio: the JS code that sets question indexes count table rows to know where the next question should be inserted... but it was written for one row per-question, which doesn't happen currently (we get at least two per question, not sure whether only two always) | 13:30 |
| *** Lennie has quit IRC | 13:31 | |
| ajaksu | Merio: editing JS, line 630 -> field_count = survey_table.find('tr').length; | 13:31 |
| Merio | ajaksu: got it. :) | 13:33 |
| Merio | ajaksu: just time to push the double quotes patch :) | 13:33 |
| Merio | ajaksu: (and well, to drink some coffee :P) | 13:33 |
| ajaksu | Merio: no hurry, thanks a lot for all the help :) | 13:34 |
| ajaksu | Merio: btw, with >200 comments in review and so many advices, I think you should be @author in all survey JS files :) | 13:35 |
| Merio | ajaksu: too kind :) | 13:38 |
| ajaksu | Merio: seriously, you've been a great help, I hope I can retribute with some Python guidance for your GSoC if you need it:) | 13:44 |
| Merio | ajaksu: that would be great, thank you again :) | 13:47 |
| *** Lennie has joined #melange | 13:50 | |
| *** ChanServ sets mode: +o Lennie | 13:50 | |
| Lennie | hi ajaksu Merio how is it going :D? | 13:51 |
| ajaksu | Lennie: emailing the patch to you :) | 13:51 |
| Lennie | wicked | 13:51 |
| Merio | Lennie: patch pushed :) | 13:52 |
| Lennie | Merio: +1 :P | 13:52 |
| Lennie | ajaksu: Isn't the form always bound on POST request? | 13:58 |
| ajaksu | Lennie: if we pass the post request, yes it is :) | 13:59 |
| Lennie | hmm | 14:00 |
| ajaksu | Lennie: but it shouldn't be bound on get, and passing anything besides None as 'data' makes it bound | 14:00 |
| Lennie | ok | 14:00 |
| Lennie | so that means I don't have to pass post_dict in _getSurveyTakeForm right? | 14:01 |
| Lennie | it just gets set when I call getFields? | 14:01 |
| ajaksu | Lennie: since we're using getFields to do something __init__ should do, we aren't getting bound forms IIUC (and that's why I had to pass a hand-crafted 'data' before) | 14:02 |
| ajaksu | Lennie: but that makes us really close to calling SurveyTakeForm(request.POST, **kwargs) and having __init__ do the getFields dance | 14:03 |
| Lennie | anything besides None? | 14:03 |
| Lennie | hmm | 14:03 |
| ajaksu | Lennie: at least an empty dict makes it bound :D | 14:04 |
| Lennie | hmm | 14:04 |
| Lennie | shouldn't line 100 be 'data', None then? | 14:04 |
| ajaksu | Lennie: no need, but it would be clearer: we're removing data from kwargs and only adding it back if it had content to begin with | 14:07 |
| ajaksu | Lennie: so, hm, the empty dict is never used, None is bestest :) | 14:08 |
| Lennie | ok | 14:08 |
| Lennie | so hmm why would I need to pass the same data to getFields again :)? | 14:10 |
| ajaksu | Lennie: you wouldn't, if I factored the common field-value fetching code out of setCleaners and getField, then saved the values... and I can also make getFields run from __init__, so our form pretends to be normal :) | 14:11 |
| Merio | ajaksu: do you have an example in which a question takes more than one row? Because it seems fine here | 14:12 |
| ajaksu | Lennie: is that my task or is it low priority? | 14:12 |
| ajaksu | Merio: OK, sorry, same mistake I made when explaining to Lennie... in fact, that buglet only gives us higher indexes if we're displaying error msgs or something like that, but it's a bad index function once you add lots of questions and remove some, then add new ones :) | 14:14 |
| Erant | SRabbelier: So, doing anything today? | 14:15 |
| SRabbelier | Erant: yup! | 14:15 |
| Erant | liek w0t | 14:15 |
| SRabbelier | Erant: got invited by some friends :) | 14:15 |
| Erant | Over to where? | 14:15 |
| Merio | ajaksu: if I remove a question and then I add one it seems to keep good working | 14:15 |
| SRabbelier | Erant: over to their place to have fun and watch fireworks :P | 14:16 |
| Erant | Ah. I'm leaving for Santa Cruz in about an hour, should be kickass :) | 14:16 |
| Lennie | 4th of July ^_^ | 14:16 |
| Lennie | have fun | 14:16 |
| Erant | Yupz | 14:16 |
| Erant | Beer + beach + fireworks + babes == teh win. | 14:16 |
| ajaksu | Lennie: never mind, the data extraction is trivial to replace as we keep it as 'data', question is: should I move getFields to __init__? :) | 14:16 |
| Merio | Erant: :D | 14:16 |
| Lennie | ajaksu: yes lets get it over with! | 14:17 |
| Lennie | ajaksu: then it feels more like a normal form :) | 14:17 |
| Merio | SRabbelier: have fun :) | 14:17 |
| Lennie | which can read both a survey_record and POST data | 14:17 |
| Lennie | ajaksu: you agree? | 14:17 |
| Lennie | ajaksu: however you should still have _getFields don't want to clutter __init__ too much :D | 14:18 |
| ajaksu | Merio: hm, try adding half a dozen questions, saving, and deleting the first four and saving... when you add new ones (and save), they'll appear on top of the existing ones | 14:18 |
| ajaksu | Lennie: agree and agree :) | 14:18 |
| Merio | ajaksu: ok thanks, trying to test it | 14:18 |
| Lennie | ajaksu: awesome | 14:19 |
| ajaksu | Merio: fix for that isn't too clear to me... maybe we should re-index when saving the schema to remove gaps? | 14:19 |
| SRabbelier | http://www.youtube.com/watch?v=YWdJxdy7w8I | 14:23 |
| tpb | Title: YouTube - Italian Sausage Burgers Recipe by the BBQ Pit Boys (at www.youtube.com) | 14:23 |
| SRabbelier | BBQ :D | 14:23 |
| Merio | ajaksu: Actually I know that if you put in fields a name attribute name="field[]" it can actually behaves like an array. But I need to have a deeper look at your code to see what's really happening | 14:23 |
| Merio | ajaksu: Actually I remember that putting name like that you would end up in PHP with an array, going to see if this is happening also in JS :) | 14:24 |
| ajaksu | Merio: I think we use something similar for the per-choice-question options (which are sortable, so serialize their order on POST) | 14:25 |
| Merio | ajaksu: oh they are? I didn't notice it :) | 14:26 |
| Merio | ajaksu: an hover with cursor:move could be useful | 14:26 |
| ajaksu | Merio: actually they're numbered but we use sortable.serialize() or something like that to re-number :) | 14:26 |
| ajaksu | Merio: agreed, and something to flag that double-clicking let's you edit the option text would also be cool... | 14:27 |
| Merio | ajaksu: actually when you edit, at least in my box, it happens that you have spaces before and after the label | 14:29 |
| ajaksu | Merio: here too, never took the time to fix that... | 14:30 |
| Merio | ajaksu: ok going to see too :) | 14:30 |
| ajaksu | Merio: thanks :) | 14:32 |
| Lennie | ajaksu: you can attach your patch to the POST override thread ;) | 14:32 |
| Lennie | Mario you have mail | 14:33 |
| Merio | Lennie: great :) | 14:33 |
| Merio | ajaksu: should the count start with 0 or 1? Because well, I'm making an ugly hack to count with <a class="delete"> instead of <tr> :) | 14:37 |
| ajaksu | Merio: I think it starts at 1, from when the survey has no fields yet, but shouldn't matter if we're consistent when counting :) | 14:40 |
| Lennie | counting from 1, VB horror :P | 14:40 |
| Merio | ajaksu: well so what matters? :P eheheh | 14:41 |
| Lennie | as long as it is consistent it doesn't matter right?? | 14:41 |
| Merio | ajaksu: I mean, well probably it's because I couldn't reproduce the error you're talking about, I'll try to do it | 14:41 |
| Merio | Lennie: ah, I misread :P | 14:42 |
| ajaksu | Merio: maybe I'm wrong, wanna try the inline edit issue until I can try to find a reproducible case? :) | 14:44 |
| Merio | ajaksu: eheh ok :P However I see that if you use class=delete as a reference the counting is right. Don't know however what happens in backend, if this index need to be used for something and then it's needed to be refreshed in some way. | 14:46 |
| ajaksu | Merio: yes, the issue would be that the index is stored and is static, so the field with index 10 could be listed below newer ones if 1-9 were deleted... however, if we do generate the indexes dynamically, this doesn't happen... but I don't think we do :) | 14:48 |
| Merio | ajaksu: problem is that as far as I can see you don't output the indexes after saving them. Don't know if it can break something, trying to see | 14:53 |
| ajaksu | Merio: right, they are used to sort the fields but not actually output... maybe we could serialize field order and reindex from that, but it's not a big issue: you can edit order by hand in the json export :) | 14:54 |
| ajaksu | Merio: gives a good overview of a survey: http://paste.pocoo.org/show/126495/ | 14:57 |
| tpb | Title: Paste #126495 | LodgeIt! (at paste.pocoo.org) | 14:57 |
| ajaksu | key fields are survey_content and schema inside it | 14:58 |
| Lennie | I'm still pondering about the import view :) | 14:59 |
| Lennie | ajaksu how is it going? | 15:01 |
| Lennie | I want to round up early today | 15:01 |
| Lennie | so we can say that we are done with ti :P | 15:01 |
| ajaksu | Lennie: going well, but... don't we have pairing to solve? :) | 15:03 |
| Lennie | no | 15:03 |
| Lennie | that's something for next week | 15:03 |
| Lennie | task API ftw :) | 15:03 |
| Lennie | we'll have the task API doing the pairing | 15:05 |
| Lennie | and that's where the program admin can change the outcome if required | 15:05 |
| ajaksu | Lennie: but if the models don't support it, can we deploy? I mean, given two open grading surveys paired to two open project surveys by a project, which goes with which? etc. :) | 15:05 |
| Lennie | we have a SurveyGroup | 15:06 |
| ajaksu | Lennie: so we're keeping the group/pair model | 15:06 |
| Lennie | you specifiy which goes to which :) | 15:06 |
| Lennie | one time | 15:06 |
| Lennie | and then Task API gathers it all for you | 15:06 |
| Lennie | making GroupRecords | 15:06 |
| Lennie | or whatever we'll call them | 15:06 |
| ajaksu | Lennie: great, so we're almost done :) | 15:06 |
| Lennie | yes | 15:06 |
| Lennie | :) | 15:07 |
| Lennie | just waiting for your patch :P | 15:07 |
| Lennie | and then another one | 15:07 |
| Lennie | I'm working on some Melange administration :p | 15:07 |
| Lennie | after the patch from you we only have to take care of the annoying prompt swallowing up real answers which might go hand in hand with custom tooltips :) | 15:08 |
| Lennie | that would mean my list of TODO is empty :P | 15:08 |
| Lennie | and I would have to give a big thanks to you for doing a lot of work the last days :D | 15:08 |
| ajaksu | Lennie: heh, IMO I'm the one that should say thank you oh so very much :) | 15:11 |
| *** Lennie has quit IRC | 15:12 | |
| *** Lennie has joined #melange | 15:12 | |
| *** ChanServ sets mode: +o Lennie | 15:12 | |
| Lennie | hmm | 15:12 |
| Lennie | if it isn't the wireless, it's me pulling out the LAN cable | 15:12 |
| Lennie | what was the last thing I said and what did I miss :P? | 15:12 |
| Merio | ajaksu: is it expected behavior that if I delete a survey the survey content is still in the datastore? | 15:14 |
| ajaksu | [16:08:33] <@Lennie> and I would have to give a big thanks to you for doing a lot of work the last days :D | 15:14 |
| ajaksu | [16:11:30] <ajaksu> Lennie: heh, IMO I'm the one that should say thank you oh so very much :) | 15:14 |
| Lennie | ha | 15:15 |
| Lennie | let me lend a quote from someone | 15:15 |
| Lennie | "Don't deny the awesome" | 15:15 |
| Lennie | you deserve a thank you ;) | 15:15 |
| Lennie | anyhow | 15:16 |
| Lennie | I want to give you a free evening | 15:16 |
| ajaksu | Merio: nope, I think we should have all traces erased if we had a 'restore with results from backup', but both are important as I see it | 15:16 |
| Lennie | so | 15:16 |
| Lennie | :D | 15:16 |
| ajaksu | Lennie: thanks, and thanks for the free evening, so hacking for that :) | 15:17 |
| Lennie | hehe | 15:17 |
| Lennie | cool | 15:17 |
| madrazr | Lennie: Surveys testing mail should be sent to melange-soc list also I feel, there are more audience there than dev list | 15:18 |
| Lennie | hmm | 15:18 |
| Lennie | true | 15:19 |
| Lennie | it has been done madrazr | 15:20 |
| madrazr | Lennie: cool! expecting more testing :) | 15:20 |
| Lennie | interesting | 15:20 |
| Lennie | I didn't know our group had 104 members lolo | 15:21 |
| madrazr | Lennie: awesome! | 15:21 |
| Lennie | kblin: sorry that it had to take that long for something real to be out there but atleast it is really usable now :D | 15:23 |
| Lennie | kblin: I don't expect you to give it a spin tomorrow since you have a presentation :) | 15:23 |
| Lennie | (to prepare) | 15:23 |
| Lennie | anyhow | 15:25 |
| Lennie | just keeping in line with GSoC tradition everything at the latest moment :P? | 15:26 |
| Lennie | SRabbelier: wanna bet for emergency maintenance tomorrow ;P? | 15:26 |
| madrazr | Lennie: Murphy's law, eh? :P | 15:27 |
| Lennie | oh | 15:27 |
| Lennie | hehe | 15:27 |
| Lennie | don't start me on that ;0 | 15:27 |
| madrazr | Lennie: ROFL :D | 15:27 |
| SRabbelier | Lennie: lol :) | 15:30 |
| SRabbelier | Lennie: I'll keep an eye on the google internal appengine threads :P | 15:30 |
| Lennie | hehe :D | 15:30 |
| Lennie | (hints at wanting a t-shirt) | 15:31 |
| ajaksu | Lennie: done, sending the patch... | 15:39 |
| Lennie | ^^ | 15:40 |
| Lennie | +1 | 15:41 |
| ajaksu | Lennie: heh, I thought we had the post override patch applied (and applying this one makes it moot), but the getFromPost helper was lost in translation... want me to keep it? | 15:46 |
| Lennie | hmm | 15:46 |
| Lennie | I didn't apply the post override one | 15:46 |
| Lennie | just give it all in one package :D | 15:46 |
| Lennie | whatever works for you that means | 15:52 |
| ajaksu | Lennie: deleting one line and deciding the helper isn't worth the hassle, not much work but I'm not that fast when not using mind tricks :D | 15:54 |
| ajaksu | sent | 15:54 |
| Lennie | ok | 15:54 |
| Lennie | I'll go and take a look then :D | 15:54 |
| Lennie | lool :P | 15:56 |
| Lennie | 505 :( | 15:56 |
| ajaksu | sigh... error msg? | 15:56 |
| Lennie | I'll fix it I think | 15:57 |
| Lennie | _getSurveyForm takes 4, 5 given | 15:57 |
| ajaksu | Lennie: but the patch makes _getSurveyForm take 5... maybe kwargs vs args? | 15:58 |
| Lennie | nah | 15:58 |
| Lennie | gradingProjectSurvey overwrites that method | 15:59 |
| Lennie | that's the problem | 15:59 |
| Lennie | AttributeError: This QueryDict instance is immutable | 15:59 |
| Lennie | hmm | 15:59 |
| Lennie | oh | 15:59 |
| Lennie | hehe | 15:59 |
| Lennie | you are trying to write to mutate a POST dict there :) | 16:00 |
| ajaksu | Lennie: told ya about possible subclass issues on the private message, forgot to pass to the final patch message :) | 16:00 |
| ajaksu | Lennie: in Survey? or a subclass? | 16:00 |
| Lennie | subclass this time | 16:00 |
| Lennie | I'm running the grading survey :P | 16:01 |
| Lennie | since that's the most elaborate test case | 16:01 |
| ajaksu | Lennie: didn't test with subclasses, expect breakage there... and yes, my grade hack is probably treating data as a dict... lemme run the grading survey and fix it | 16:02 |
| Lennie | however | 16:04 |
| Lennie | it does fix the mentioned problems :D | 16:04 |
| ajaksu | Lennie: now getFields runs in __init__ it should be easy to fix that... new version with subclasses fixes soon :) | 16:05 |
| Lennie | I'm happy it sounds more solid | 16:06 |
| Lennie | although it doens't add much to the outside :) | 16:06 |
| kblin | Lennie: demo site ready? | 16:09 |
| Lennie | hmm no | 16:11 |
| Lennie | Pawel will put the new version online tomorrow | 16:11 |
| Lennie | ~10.00 UTC+2 | 16:11 |
| ajaksu | kblin: I can push current code to my instance in a couple of minutes :) | 16:11 |
| Lennie | however | 16:11 |
| Lennie | that is indeed possible | 16:11 |
| ajaksu | Lennie: don't let me forget to ask you about how and when we freeze ;) | 16:12 |
| *** MatthewWilkes has joined #melange | 16:12 | |
| *** dr__house has quit IRC | 16:14 | |
| kblin | ok, whatever | 16:15 |
| kblin | I can't promise anything, but if I've got some time tomorrow, I'll try to break whatever you have :) | 16:15 |
| Lennie | hehe | 16:15 |
| Lennie | don't worry | 16:15 |
| Lennie | we are used to letting it break when going live ;P | 16:15 |
| Lennie | it is software after all | 16:16 |
| kblin | this will have to be before 14:00 CEST | 16:16 |
| kblin | tomorrow, that is | 16:16 |
| kblin | I've got an appointment after that :) | 16:16 |
| Lennie | yes it shouldn't take Pawel more then 30m to cut, push and prepare the demo instance | 16:16 |
| Lennie | so it should be done well before 14.00 CEST | 16:17 |
| kblin | ok, great | 16:17 |
| *** florinciu_ has joined #melange | 16:18 | |
| kblin | always a pleasure trying to break your toys :) | 16:19 |
| Lennie | hehe | 16:19 |
| Lennie | you mean bully! | 16:19 |
| *** florinciu has quit IRC | 16:20 | |
| *** florinciu_ is now known as florinciu | 16:20 | |
| *** florinciu_ has joined #melange | 16:28 | |
| *** madrazr1 has joined #melange | 16:34 | |
| *** madrazr has quit IRC | 16:34 | |
| *** madrazr1 is now known as madrazr | 16:34 | |
| *** ChanServ sets mode: +v madrazr | 16:35 | |
| *** florinciu has quit IRC | 16:36 | |
| ajaksu | Lennie: ugly 8 lines fixs on its way, was the 'pick a project' page supposed to appear after taking a grading survey, but without a project listed? | 16:42 |
| Lennie | hmm | 16:43 |
| Lennie | no | 16:43 |
| Lennie | that can't happen :S | 16:43 |
| ajaksu | lemme create a new project to make sure... | 16:44 |
| Lennie | hmm | 16:44 |
| Lennie | taking a survey and whatever is on the filtering page have no influence on each other | 16:45 |
| ajaksu | Lennie: access rules changes, I guess... and one more grade field validation issue to tackle | 16:49 |
| Lennie | ? | 16:49 |
| Lennie | what's wrong? | 16:49 |
| ajaksu | Lennie: not storing the grade, should I do a crude special case then fix it neatly when my brain is back in action? | 16:55 |
| Lennie | wow | 16:55 |
| Lennie | it used to store it :D | 16:55 |
| Lennie | is this an exception of some kind? | 16:56 |
| Lennie | does it still store it in the normal case? | 16:56 |
| ajaksu | you mean normal form values? yep... but we used getFields and insertFields to add the gradeField, I must be missing something stupid in this new config... | 16:57 |
| Lennie | hmm | 16:58 |
| Lennie | I thought taking it out wasn't that hard because you could just call getFields in the __init__ | 16:58 |
| Lennie | apparently there is more to it | 16:58 |
| Lennie | if you fixed the rest you should send it | 16:59 |
| Lennie | I want to take a look too | 16:59 |
| ajaksu | Lennie: sent, going to take a small break to see if old brain wakes up :) | 17:04 |
| Lennie | sure | 17:04 |
| Lennie | I'll take a look | 17:04 |
| ajaksu | thanks :) | 17:04 |
| ajaksu | Lennie: it seems the field name is added to 'data', but I believe the field itself isn't added to self.fields... | 17:05 |
| ajaksu | damn the break, lemme check this | 17:06 |
| Lennie | hmm ok | 17:06 |
| Lennie | lol :) | 17:06 |
| ajaksu | hmm, no, fields is this at the end of SurveyTakeForm.__init__: {'wfqf': <django.forms.fields.CharField object at 0x15862aac>, 'comment_for_wfqf': <django.forms.fields.CharField object at 0x15862e6c>, 'grade': <django.forms.fields.ChoiceField object at 0x1586254c>} | 17:07 |
| Lennie | hmm | 17:08 |
| ajaksu | (nice field name, huh?) | 17:08 |
| Lennie | anyhow | 17:08 |
| Lennie | yes | 17:08 |
| Lennie | can the getFields call be removed from takeGet? | 17:08 |
| ajaksu | testing, but so far looks like yes it can :) | 17:11 |
| Lennie | I think I perhaps know why | 17:11 |
| Lennie | projectgradingsurvey | 17:12 |
| Lennie | line 161 | 17:12 |
| Lennie | there never is self.data because super was never called | 17:12 |
| Lennie | always setting it to None | 17:12 |
| Lennie | and not to what the data to the constructor might have | 17:12 |
| Lennie | so we are not respecting the data kwarg there as the comment states afaik | 17:14 |
| ajaksu | testing this... | 17:16 |
| Lennie | if I replace None by 'fail' or 'pass' I'm getting some response | 17:16 |
| Lennie | so I think it must be there | 17:16 |
| Lennie | the rest of the functionality seems to be intact :) | 17:19 |
| Lennie | yeah | 17:20 |
| Lennie | storing works fine | 17:20 |
| ajaksu | next time I say 'should be easy', shoot me twice | 17:21 |
| Lennie | SRabbelier has experience on that ;D | 17:21 |
| ajaksu | Lennie: fixed it or looking at the datastore? | 17:21 |
| Lennie | looking at datastore | 17:21 |
| Lennie | with by forcing data to be 'pass' | 17:21 |
| Lennie | have you fixed it :P/ | 17:21 |
| Lennie | I'm just beginning to get a good grip on it | 17:21 |
| ajaksu | not yet, but I'm starting to see a chance of fixing it before I punch my laptop, so all is good :) | 17:22 |
| Lennie | hehe | 17:25 |
| Lennie | my best bet is line 161 :P | 17:25 |
| Lennie | or the code around that line | 17:25 |
| Lennie | because what I am seeing on a post where grade should be fail | 17:25 |
| Lennie | is that data gets set to | 17:25 |
| Lennie | None | 17:25 |
| ajaksu | stumbling on "too many subqueries (max: 30, got 31)", gotta get me a clean db and real users... | 17:28 |
| Lennie | lol | 17:29 |
| Lennie | :P | 17:29 |
| ajaksu | http://localhost:8080/grading_project_survey/take/program/google/gsoc2009/survey_id with a clean db gives me: Error: ReferenceProperty failed to be resolved, (fetching project wanna traceback? | 17:31 |
| Lennie | because the surveys don't get deleted? | 17:32 |
| Lennie | seed_db doesn't do that | 17:32 |
| Lennie | or something else got deleted in wrong order :) | 17:32 |
| ajaksu | aha, must be it :) | 17:32 |
| Lennie | okay | 17:33 |
| Lennie | I'm confused | 17:33 |
| Lennie | why do I have to set self.data | 17:33 |
| Lennie | and why am I the only field in there :P? | 17:34 |
| ajaksu | Lennie: we don't have to set self.data, but we have to send a new 'grade' entry to super, which was done using the data kwarg, that is now read-only... | 17:35 |
| ajaksu | so, hmm, stupid solution :) | 17:35 |
| Lennie | anyhow | 17:36 |
| Lennie | I traced it back to 161 | 17:36 |
| Lennie | since that is where the self.data['grade'] = None is set | 17:36 |
| Lennie | and that is used in the form | 17:36 |
| ajaksu | and it should be kwargs['data']['grade'] ! | 17:37 |
| Lennie | yosh | 17:37 |
| ajaksu | right? | 17:37 |
| Lennie | if it exists | 17:37 |
| Lennie | that's what I have now | 17:37 |
| Lennie | but | 17:37 |
| ajaksu | but? | 17:37 |
| Lennie | it still doesn't populate the field with the record :( | 17:37 |
| Lennie | so it goes back to choice a grade | 17:37 |
| Lennie | choose* | 17:38 |
| ajaksu | without the validation error? | 17:38 |
| Lennie | yes | 17:38 |
| Lennie | however it gets stored correctly | 17:38 |
| Lennie | it just doesn't read it back correctly | 17:38 |
| ajaksu | hm, ok, that would be because we're iterating fields by schema I guess.... | 17:38 |
| ajaksu | Lennie: or not... lines 184-189 in grading...survey should fetch it | 17:41 |
| Lennie | they fetch it | 17:41 |
| Lennie | but it doesn't get set | 17:41 |
| Lennie | it doesn't get added to the clean_data in the super | 17:45 |
| ajaksu | it was a stale student project causing the error.... | 17:53 |
| Lennie | thought so | 17:53 |
| Lennie | anyhow | 17:53 |
| Lennie | I havent fixed it yet :( | 17:53 |
| Lennie | somewhere something is going out of order | 17:53 |
| Lennie | jamtoday: | 18:19 |
| Lennie | wanna join debug part :P? | 18:19 |
| Lennie | party | 18:19 |
| jamtoday | Lennie: yes i do! | 18:32 |
| jamtoday | in the US of A there are other parties going on but luckily I am antisocial | 18:32 |
| Lennie | hehe | 18:33 |
| Lennie | we already got it :( | 18:33 |
| MatthewWilkes | yay, somebody XChat colourises as purple, not green, the conversation might be followable :) | 18:33 |
| Lennie | happy 4th of Juli btw | 18:33 |
| Lennie | gratz MatthewWilkes :P | 18:33 |
| MatthewWilkes | after rubbing the loss of the colonies in my face? | 18:33 |
| MatthewWilkes | :) | 18:35 |
| Lennie | :) | 18:37 |
| Lennie | yes | 18:37 |
| jamtoday | MatthewWilkes: Sorry bloke | 18:38 |
| MatthewWilkes | jamtoday: "bloke" can't be used like that. I'd suggest "mate", "fella", or preferably "chap" | 18:39 |
| jamtoday | MatthewWilkes: right on mate | 18:40 |
| scorche|sh | MatthewWilkes: dont mind that bloke ;) | 18:40 |
| jamtoday | Lennie: In addition to testing on the staging server, I was planning on getting smoke tests ready for project/grading surveys. Is there anything higher priority for me to work on first? | 18:42 |
| Lennie | hmm | 18:42 |
| Lennie | not that I know | 18:43 |
| jamtoday | Still some weird behavior with validation, but it seems like that might be fixed by now | 18:43 |
| Lennie | oh yes | 18:43 |
| Lennie | that is fixed | 18:43 |
| Lennie | however | 18:43 |
| Lennie | form validatoin failur | 18:43 |
| Lennie | make the comment fields text fields go into prompt mode | 18:44 |
| Lennie | so you can't edit them without losing your data :S | 18:44 |
| jamtoday | go into prompt mode...not sure I understand | 18:44 |
| jamtoday | I'm going to make sure grading works, and SurveyRecordGroups. We might not need it yet, but I want to make sure it won't require any changes to the model that we can't make after Monday | 18:45 |
| Lennie | hmm | 18:45 |
| Lennie | please dont | 18:46 |
| Lennie | there is a lot more to it then it seems | 18:46 |
| Lennie | create group | 18:46 |
| Lennie | using task API | 18:46 |
| Lennie | as long as the surveys are in place nothing has to change to record groups | 18:46 |
| jamtoday | true | 18:46 |
| Lennie | it is something that's supposed to be used for data collectoin | 18:46 |
| jamtoday | so I want the comment fields to empty when focused? | 18:46 |
| Lennie | I rather have you working on some JS/CSS testing | 18:46 |
| Lennie | fixing | 18:47 |
| Lennie | testing | 18:47 |
| Lennie | and then you can go on with newsfeeds next week | 18:47 |
| Lennie | I think me and ajaksu(if he wants) will take care of the rest | 18:47 |
| jamtoday | alright, I've got Opera, Webkit, IE, and FF open | 18:47 |
| Lennie | ajaksu: ping, are you going to do the comment/tooltip thingy :)? | 18:48 |
| *** dhaun has quit IRC | 18:48 | |
| Lennie | I would love it if you'd get a staging server live | 18:48 |
| Lennie | might be useful for early testing :P | 18:48 |
| ajaksu | Lennie: reading back, but I can do it if nobody else really really wants to :) | 18:49 |
| Lennie | we are talking about comment/tooltip right? | 18:49 |
| Lennie | my 2 cents are you go and enjoy the rest of the evening and maybe give it a shot tomorrow :P? | 18:49 |
| Lennie | I'm sure we can still get it in | 18:49 |
| Lennie | however it might be good to disable the prompt asap | 18:50 |
| Lennie | since it is not nice to see your story go away :p | 18:50 |
| ajaksu | Lennie: disabling asap, and making the question about freezing: how and when do we freeze? and after the release, how conservative do we get? i.e., do we accept nice-to-haves after first release or just bugfixes? | 18:52 |
| Lennie | bugfixes > nth | 18:53 |
| Lennie | it's just more of a way of seeing if that release is ready for taking surveys :) | 18:53 |
| Lennie | it's not really a big freeze | 18:53 |
| *** madrazr has left #melange | 18:53 | |
| Lennie | for instance I still need to get your import view in :( | 18:54 |
| ajaksu | jamtoday: the 'prompt mode' means we get the 'default prompt' behavior (disappering text when we start to type) with stuff we typed before... disabling it | 18:54 |
| ajaksu | Lennie: that's good news, actually, as I don't have to deliver all my todos in 24h :) | 18:55 |
| Lennie | hehe | 18:57 |
| Lennie | however | 18:57 |
| Lennie | ofcourse | 18:57 |
| jamtoday | oh...that shouldn | 18:57 |
| Lennie | big changes are more unlikely to make it fast :) | 18:57 |
| Lennie | ok | 18:57 |
| Lennie | it happens when a selection questoin fails | 18:57 |
| jamtoday | ajaksu: depending on if we want the default prompt behavior for all non-comment textareas, we can just do a negative lookup on comment class, I modified the comment widget attrs to include comment class | 18:58 |
| ajaksu | Lennie: got it with 2 long_answers, one filled other failing, and confirmed that commenting out some JS bits fixes that... | 18:58 |
| Lennie | hmm | 18:58 |
| Lennie | ok | 18:58 |
| Lennie | :) | 18:58 |
| ajaksu | jamtoday: how about we don't add behavior to textarea contents and put default prompts in tooltips? | 18:59 |
| Lennie | oh | 19:00 |
| Lennie | good idea ;) | 19:01 |
| Lennie | I'm +1000 on that :P | 19:01 |
| Lennie | since the text disappears when you start typing anyway | 19:01 |
| Lennie | and that way you can read it agian :) | 19:01 |
| Lennie | jamtoday: the current version should be good for testing | 19:02 |
| Lennie | everything should work | 19:02 |
| Lennie | (tm) | 19:02 |
| jamtoday | Lennie and ajaksu: Yes....I feel silly for having wasted all of our times with that "feature" | 19:02 |
| Lennie | ? | 19:03 |
| Lennie | is that meant sarcastic :)? | 19:03 |
| jamtoday | no, serious | 19:03 |
| Lennie | ok | 19:03 |
| Lennie | it's not really wasting | 19:03 |
| Lennie | it's programming | 19:03 |
| Lennie | you have to try stuff | 19:03 |
| Lennie | and apparently this doesn't work out for us | 19:03 |
| jamtoday | true, it sounded good on paper | 19:03 |
| Lennie | we can just use our tooltips | 19:03 |
| Lennie | which we have :) | 19:03 |
| Lennie | already | 19:03 |
| Lennie | one could say you have wasted time on how the system looked 1 week ago | 19:04 |
| Lennie | not realy through | 19:04 |
| Lennie | code evolves | 19:04 |
| Lennie | I might have made the same if I started from scratch :) | 19:04 |
| Lennie | anyhow, no time for these kinds of discussions :P | 19:04 |
| jamtoday | yeah much easier to work on something that exists | 19:04 |
| Lennie | it's 01:00 here :D | 19:04 |
| ajaksu | jamtoday: Lennie is looking into the final bug I introduced in the final patch for today for, dunno, three hours? :) | 19:05 |
| Lennie | jamtoday: so true | 19:05 |
| jamtoday | alright, get some sleep. I will get some BBQ | 19:05 |
| Lennie | :D | 19:05 |
| Lennie | ajaksu: I'm past expiration date, too tired | 19:05 |
| Lennie | but the bug has been fixed now afaik :) | 19:05 |
| Lennie | so please test | 19:05 |
| Lennie | makes me happy | 19:05 |
| Lennie | ^^ | 19:05 |
| jamtoday | Lennie and ajaksu: updating my staging server, I'll try my hardest to break things | 19:05 |
| ajaksu | Lennie: yay, pulling and testing | 19:05 |
| Lennie | jamtoday: _1 | 19:06 |
| Lennie | +1 | 19:06 |
| ajaksu | jamtoday: do you know the 'paste > 1MB in the textarea' trick? seems we still have an upper bound for text fields :D | 19:06 |
| Lennie | ajaksu: I've not given your patch a real proper rundown though | 19:06 |
| Lennie | just keeping fingers corssed :P | 19:06 |
| Lennie | ajaksu: :D | 19:06 |
| Lennie | jamtoday: access checks are in place too btw | 19:07 |
| Lennie | so you should be able to log in as a student :) | 19:07 |
| jamtoday | ajaksu: I don't know if we need to support > 1 MB in a textfield, do we? | 19:07 |
| ajaksu | Lennie: I created and took surveys and project surveys with it, I'll try another run with the new code and focus on grading surveys :) | 19:07 |
| Lennie | jamtoday: you can't entities are limited to 1MB anyway | 19:07 |
| Lennie | ajaksu: as student :) | 19:07 |
| Lennie | ? | 19:07 |
| Lennie | ajaksu: and mentor? | 19:07 |
| Lennie | ajaksu: afaik it all seems good | 19:08 |
| ajaksu | Lennie: aha, I think I didn't take as student for the last round, after access changes... | 19:08 |
| Lennie | jamtoday: I still have a JS menu patch from you I think | 19:08 |
| Lennie | for showing featured surveys | 19:08 |
| Lennie | that might be something I can get in after the new release has been cut :) | 19:09 |
| ajaksu | Lennie: it's 20:08 here, I'll take a 1 hour break and come back for some more hacking, so expect patches and reports when you wake up :) | 19:09 |
| Lennie | if you want to test it on your own stage it would be cool | 19:09 |
| jamtoday | ajaksu: you fixed the double quotes bug! | 19:09 |
| Lennie | jamtoday: no! | 19:09 |
| Lennie | jamtoday: Merio did :D | 19:09 |
| Lennie | right :P/ | 19:10 |
| Lennie | ? | 19:10 |
| ajaksu | jamtoday: the 1MB thing was me trying to test we were able to have > 500 chars fields... a pasted a liiiittle too much :) | 19:10 |
| Lennie | ajaksu: okay, hmm that's kind of you :D | 19:10 |
| Lennie | ajaksu: thanks for all the help so far | 19:10 |
| ajaksu | jamtoday: Merio did, bless him :) | 19:10 |
| Lennie | jamtoday: survey_sidebar patch can you test it yourself and see if it works for the grading and project as well :)? | 19:10 |
| Lennie | put it in a seperate thread if it needs updating | 19:11 |
| Lennie | and I'll get to it in the morning | 19:11 |
| Merio | sorry guys I was asleep... thx too kind ^__^ | 19:11 |
| Lennie | :P | 19:11 |
| ajaksu | Meri o: I can't believe you woke up to be polite :D | 19:12 |
| ajaksu | (extra space to avoid waking him up again, just in case) | 19:13 |
| Lennie | haha | 19:13 |
| Lennie | I like a bit of torture | 19:13 |
| Lennie | Merio: | 19:13 |
| Lennie | been reading too much James Bond lately | 19:13 |
| Lennie | is rubbing off :) | 19:13 |
| ajaksu | lol | 19:13 |
| Merio | eheheh :) | 19:13 |
| Merio | actually I was studying Physics... and turned out to be better than chamomile today :P | 19:14 |
| Lennie | Physics? | 19:14 |
| Lennie | ok | 19:14 |
| Lennie | hmm | 19:14 |
| Lennie | remind me | 19:14 |
| Lennie | what do you study? | 19:14 |
| Merio | Computer Engineering | 19:14 |
| Lennie | ok | 19:14 |
| Lennie | physics and CE | 19:14 |
| Lennie | are we talking electrical currents here? | 19:15 |
| Lennie | quantum mechanics ^_^ ? | 19:15 |
| Merio | Electromagnetism :) | 19:15 |
| Lennie | ok | 19:15 |
| Merio | We've two exams, this is the last one. The former was about dynamics... but already done :) | 19:16 |
| jamtoday | ajaksu: testing sidebar...I'm trying to figure out what happened to my qip | 19:16 |
| Lennie | :) | 19:16 |
| Merio | I've left the better exams for last :D | 19:16 |
| jamtoday | *qtip | 19:16 |
| ajaksu | jamtoday: qtip? | 19:17 |
| Lennie | yes queue tip I think? | 19:17 |
| Lennie | mercurial or git stuff :P | 19:17 |
| Lennie | whatever it may be | 19:17 |
| Lennie | atleast I hope :D? | 19:17 |
| Lennie | jamtoday, ajaksu, Merio. I gotta leave you all alone | 19:17 |
| Lennie | sleep is getting to me | 19:17 |
| Merio | me too :P | 19:17 |
| Lennie | jamtoday: I'll also take a look into notifications for the two surveys next week :) | 19:18 |
| ajaksu | Lennie: take a nice rest, thank you very very much, you deserve to sleep till monday but I hope you're too kind to do that :) | 19:19 |
| Lennie | rofl | 19:19 |
| ajaksu | Merio: you deserve a good rest and to turn the ping beep down, not necessarily in that order :) | 19:19 |
| Lennie | ajaksu: thanks but not needed, workaholic here | 19:20 |
| Lennie | ajaksu: you seem to be putting a lot of time in this as well | 19:20 |
| Lennie | ajaksu: I'm sure you can take it easier next week and you might still help out then if you'd wish :0 | 19:20 |
| Merio | ajaksu: eheheh going to turn off the computer :) Please let me know if there's something I can do tomorrow :) | 19:21 |
| Lennie | apparently your TODO list is big enough :D | 19:21 |
| Lennie | Merio: run surveys, make a backdoor that ensures you pass | 19:21 |
| Lennie | anything usefull :P | 19:21 |
| Lennie | thanks all, bye ^_^ | 19:21 |
| Merio | ehehehehe Lennie :D | 19:21 |
| Merio | Bye ^__^ | 19:21 |
| Lennie | otherwise tease Erant, he's in a weird country | 19:21 |
| ajaksu | Lennie: night, chat later :) | 19:21 |
| ajaksu | jamtoday: http://craigsworks.com/projects/qtip/ ? | 19:22 |
| tpb | Title: qTip - The jQuery tooltip plugin - Home (at craigsworks.com) | 19:22 |
| jamtoday | ajaksu: yes, I'm referring to my hg queue tip. It won't let me apply my patch...doing a clean checkout | 19:22 |
| *** Lennie has quit IRC | 19:23 | |
| Merio | Good night guys, I'm off too :) | 19:24 |
| Merio | See you tomorrow" | 19:24 |
| Merio | ! | 19:24 |
| ajaksu | jamtoday: ah, OK, is the latest version the one in email? :) | 19:25 |
| Merio | (double quotes... they're everywhere! :P) | 19:25 |
| ajaksu | Merio: good night :) | 19:25 |
| Merio | bye :) | 19:25 |
| *** Merio has quit IRC | 19:26 | |
| jamtoday | ajaksu: I've tried both that one and a slightly more updated one, but my new problem is that the getMenusforScope isn't being called | 19:32 |
| jamtoday | so I've been digging through the view code trying to see what changed | 19:32 |
| ajaksu | jamtoday: that's a change in program, lemme get it | 19:32 |
| jamtoday | ajaksu: getExtraMenus...? | 19:33 |
| ajaksu | jamtoday: http://code.google.com/p/soc/source/diff?spec=svna9dec4763c6bc80bd1b731f70cae5d2f2640ee13&r=b83c9b1ea0e102c0372f3ceacace3f000d1e36a8&format=side&path=/app/soc/views/models/program.py#sc_svn32620683a7a6bdde6ff02e69ef578425cec7afee_640 | 19:35 |
| tpb | <http://ln-s.net/3Shj> (at code.google.com) | 19:35 |
| ajaksu | yup, getExtraMenus :) | 19:35 |
| jamtoday | ajaksu: thanks for your help! Sometimes it can get just a bit confusing... | 19:50 |
| jamtoday | the patch has been sent | 19:50 |
| ajaksu | jamtoday: ok, going for my 1 hour break, will test when I come back :) | 19:51 |
| jamtoday | ajaksu: I still need to subclass the menus, but that should be easy | 20:24 |
| *** mithro has quit IRC | 22:12 | |
| *** mithro has joined #melange | 23:08 | |
| *** ChanServ sets mode: +v mithro | 23:08 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!