| *** tpb has joined #melange | 00:00 | |
| *** dmitrig01|afk has quit IRC | 01:07 | |
| *** dmitrig01|afk has joined #melange | 01:07 | |
| *** ChanServ sets mode: +v dmitrig01|afk | 01:07 | |
| *** mithro has quit IRC | 01:10 | |
| *** dmitrig01|afk has quit IRC | 01:27 | |
| *** dmitrig01|afk has joined #melange | 01:28 | |
| *** ChanServ sets mode: +v dmitrig01|afk | 01:28 | |
| *** dmitrig01|afk is now known as dmitrig01 | 01:29 | |
| *** penyaskito has quit IRC | 01:30 | |
| *** dmitrig01 has quit IRC | 01:45 | |
| *** madrazr has quit IRC | 01:46 | |
| *** mithro has joined #melange | 02:02 | |
| *** ChanServ sets mode: +v mithro | 02:02 | |
| *** scorche has quit IRC | 03:23 | |
| *** scorche has joined #melange | 03:23 | |
| *** scorche has quit IRC | 04:04 | |
| *** scorche has joined #melange | 04:04 | |
| *** mithro has quit IRC | 04:49 | |
| *** MatthewWilkes has joined #melange | 05:28 | |
| *** scorche has quit IRC | 05:55 | |
| *** scorche has joined #melange | 05:55 | |
| *** MatthewWilkes has quit IRC | 06:50 | |
| *** MatthewWilkes has joined #melange | 06:56 | |
| *** MatthewWilkes has quit IRC | 07:04 | |
| *** MatthewWilkes has joined #melange | 07:10 | |
| *** MatthewWilkes has quit IRC | 07:34 | |
| *** MatthewWilkes has joined #melange | 07:39 | |
| *** solydzajs has joined #melange | 07:52 | |
| *** ChanServ sets mode: +o solydzajs | 07:52 | |
| *** Lennie has joined #melange | 07:57 | |
| *** ChanServ sets mode: +v Lennie | 07:57 | |
| *** solydzajs has quit IRC | 08:00 | |
| *** MatthewWilkes has quit IRC | 08:00 | |
| *** MatthewWilkes has joined #melange | 08:02 | |
| *** madrazr has joined #melange | 08:19 | |
| *** MatthewWilkes is now known as mwilkes|lunch | 08:35 | |
| *** Merio has joined #melange | 08:48 | |
| Lennie | hi | 08:55 |
|---|---|---|
| madrazr | Lennie: Hi :) | 08:56 |
| *** mwilkes|lunch is now known as MatthewWilkes | 09:17 | |
| MatthewWilkes | afternoon Lennie | 09:22 |
| Lennie | hi MatthewWilkes | 09:22 |
| Lennie | hmm | 09:33 |
| Lennie | lets see | 09:33 |
| Lennie | house heroes | 09:33 |
| Lennie | or big bang theory | 09:33 |
| Lennie | hmm | 09:33 |
| Lennie | I'll take a small break, BBT it is. bbl | 09:33 |
| *** Lennie is now known as Lennie|Gone | 09:33 | |
| MatthewWilkes | Lennie|Gone: Good call. You seen the IT Crowd? | 09:34 |
| Lennie|Gone | I've seen it a few times | 09:35 |
| Lennie|Gone | I dont follow it though | 09:35 |
| Lennie|Gone | but its nice :D | 09:35 |
| Lennie|Gone | anyhow bbl | 09:35 |
| *** SRabbelier has joined #melange | 09:53 | |
| *** ChanServ sets mode: +v SRabbelier | 09:53 | |
| SRabbelier | Merio: ping | 09:56 |
| Merio | SRabbelier: pong :) | 10:00 |
| SRabbelier | Merio: I applied your patch, but it looks weird :-./ | 10:00 |
| Merio | SRabbelier: what appens? | 10:00 |
| Merio | *happens | 10:01 |
| SRabbelier | Merio: he completion shows up as a regular (dotted) list just below the input box in for example site setting | 10:01 |
| Merio | SRabbelier: is the thickbox in the /jquery path? | 10:02 |
| SRabbelier | Merio: I tried adding thickbox, but maybe I did somethign wrong somehow | 10:02 |
| Lennie|Gone | you added thickbox and the pictures :D? | 10:02 |
| Lennie|Gone | also a IE7 fix needs to be applied :P? | 10:02 |
| *** Lennie|Gone is now known as Lennie | 10:02 | |
| SRabbelier | Lennie|Gone: yup | 10:02 |
| Lennie | (not that you are using IE7) | 10:02 |
| Lennie | but still | 10:02 |
| SRabbelier | Merio: perhaps you can send it as one patch (inlcuding thickbox)? | 10:03 |
| Merio | SRabbelier: ok, is there a problem if I'm sending it in 4 hours or such? (coding for exam as yesterday) :) | 10:04 |
| SRabbelier | Merio: sure, no hurries | 10:05 |
| Merio | SRabbelier: ok, I'll do :) Also I'll change the behavior to multiple:false and showing the link id instead of the title (I'm going to see if both of them can be searchable) so it become a more "real" patch :) | 10:08 |
| SRabbelier | Lennie: What is the point in being able to check if someone has an incative role? Isn't it supposed to be impossible to do anything if your role i inactive? | 10:40 |
| SRabbelier | Merio: ah, awesome :) | 10:40 |
| Lennie | SRabbelier | 10:40 |
| Lennie | data retention | 10:40 |
| Lennie | you need to be able to see your last years student | 10:40 |
| Lennie | but you cant edit stuff | 10:40 |
| SRabbelier | Lennie: but... inactive == no longer able to do anything? | 10:41 |
| SRabbelier | Lennie: or is that invalid? | 10:41 |
| Lennie | invalid is kicked cant do stuff | 10:41 |
| Lennie | inactive is can't change stuff :D | 10:41 |
| SRabbelier | Lennie: mhh, ok | 10:41 |
| SRabbelier | Lennie: so the new checkHasRole will be ~ a copy/paste of the old one, only with the 'status': 'active', line removed? | 10:41 |
| SRabbelier | Lennie: mhhh, no | 10:42 |
| SRabbelier | Lennie: just needs to check it's active or inactive, yes? | 10:42 |
| Lennie | no | 10:42 |
| Lennie | since edit == active only | 10:42 |
| SRabbelier | Lennie: so should checkHasRole check for inactive, or also allow active? | 10:43 |
| Lennie | depends on what this checkHasRole does | 10:43 |
| SRabbelier | Lennie: I dunno, what should it do? | 10:43 |
| Lennie | does it check if the role belongs to the group given in django_args? | 10:43 |
| SRabbelier | Lennie: should it? | 10:44 |
| SRabbelier | Lennie: you weren't very clear in your commit msg | 10:44 |
| Lennie | We need one that just checks if you have a role for the given logic | 10:44 |
| Lennie | that's active | 10:45 |
| Lennie | one that uses django_args to see if you have a role for the group_mentioned in it that is either active/inactive | 10:45 |
| Lennie | and one that is active only | 10:45 |
| SRabbelier | Lennie: so 'checkHasRole, 'checkHasActiveRole', 'checkHasRoleForGroup', and 'checkHasActiveRoleForGroup' | 10:45 |
| Lennie | should be fine | 10:46 |
| Lennie | you can make the one call the other internally :) | 10:46 |
| SRabbelier | Lennie: sounds like they could all call one function | 10:46 |
| SRabbelier | right | 10:46 |
| Lennie | internally please | 10:46 |
| Lennie | so from the view it's clear what happens | 10:46 |
| SRabbelier | Lennie: that's what I was suggesting | 10:46 |
| *** Lennie is now known as Lennie|Gone | 11:11 | |
| *** Lennie|Gone is now known as Lennie | 12:01 | |
| *** Lennie is now known as Lennie|Food | 12:06 | |
| *** madrazr1 has joined #melange | 12:37 | |
| *** madrazr has quit IRC | 12:38 | |
| *** madrazr1 is now known as madrazr | 12:38 | |
| *** MatthewWilkes has quit IRC | 12:45 | |
| *** MatthewWilkes has joined #melange | 12:55 | |
| *** madrazr has quit IRC | 13:06 | |
| *** madrazr has joined #melange | 14:03 | |
| *** MatthewWilkes has quit IRC | 14:17 | |
| *** Lennie|Food is now known as Lennie | 14:25 | |
| *** madrazr has quit IRC | 14:47 | |
| Merio | SRabbelier: I'm going to output the diff patch (thickbox included). Send you in your private email? | 15:01 |
| SRabbelier | Merio: sure, np :) | 15:01 |
| Merio | SRabbelier: sent :) Now you can see the documents being searched for "link_id (title)", but only the link_id will be inside the textbox when you choose one doc | 15:08 |
| SRabbelier | Merio: very nice! | 15:08 |
| Merio | SRabbelier: so now I look in the JSON for "link_id" and "title", we need to generalize that for other things beside docs :) | 15:09 |
| SRabbelier | Merio: yes, we do :) | 15:10 |
| Merio | SRabbelier: however, if you've time try to see if it works now | 15:10 |
| SRabbelier | Merio: I will! | 15:10 |
| *** MatthewWilkes has joined #melange | 15:20 | |
| *** penyaskito has joined #melange | 15:47 | |
| *** Merio has quit IRC | 16:10 | |
| Lennie | nn all :) | 16:45 |
| *** Lennie has quit IRC | 16:46 | |
| *** Merio has joined #melange | 16:50 | |
| SRabbelier | Merio: ping | 17:10 |
| SRabbelier | Merio: patching file soc/templates/soc/templatetags/_as_table_row.html | 17:11 |
| SRabbelier | patch: **** malformed patch at line 1575: Index: soc/templates/soc/base.html | 17:11 |
| Merio | SRabbelier: ops... let me see :) | 17:12 |
| SRabbelier | Merio: :) | 17:12 |
| Merio | Hmm strange | 17:13 |
| SRabbelier | Merio: I applied it from /soc with patch -p0 | 17:14 |
| SRabbelier | err | 17:14 |
| SRabbelier | from /app | 17:14 |
| SRabbelier | Merio: I also tried 'git apply -p0' but same results :) | 17:14 |
| Merio | SRabbelier: sent another time... try again ;) | 17:22 |
| SRabbelier | Merio: ok! | 17:22 |
| SRabbelier | Merio: fancy! | 17:41 |
| SRabbelier | Merio: it works now, very nice box too | 17:41 |
| Merio | SRabbelier: great :) | 17:46 |
| SRabbelier | Merio: I'll review the code tomorrow and apply :) | 17:46 |
| Merio | SRabbelier: ok :) Please remember that now works only in the documents... so perhaps we'll need to port all the scripts inclusions only when appropriate (and not in base) | 17:47 |
| SRabbelier | Merio: ah, yes | 17:47 |
| SRabbelier | Merio: I'd point that out during review :P | 17:48 |
| Merio | SRabbelier: Perfect :) | 17:48 |
| SRabbelier | Merio: at least, I'd like to think that :P | 17:48 |
| Merio | SRabbelier: I'll be online tomorrow, so you can contact me for everything if useful. Perhaps we can try to do some lazy loading as well | 17:49 |
| SRabbelier | Merio: ok! I will :) | 17:49 |
| Merio | Going home to sleep a bit ;) Good night all :) | 17:57 |
| SRabbelier | Merio: ok man, g'night :) | 17:57 |
| Merio | SRabbelier: g'night :) | 17:58 |
| *** Merio has quit IRC | 17:58 | |
| *** lisppaste9 has quit IRC | 18:34 | |
| lh | SRabbelier: ping | 18:39 |
| SRabbelier | lh: pong | 18:40 |
| *** lisppaste9 has joined #melange | 18:40 | |
| lh | SRabbelier: so the select your backup administrator when creating a club application is borked | 18:45 |
| lh | logging a bug now | 18:45 |
| SRabbelier | lh: ok, will ook into it tomorrow | 18:45 |
| SRabbelier | lh: Merio fixed the selector thingy though, so that's awesome | 18:45 |
| SRabbelier | lh: going to bed now :) | 18:48 |
| lh | SRabbelier: no worries, i am surprised you answered. :) thanks dear and sleep well. :) | 18:48 |
| lh | oh and tell lennie i got his poster - you'll see him before i do | 18:48 |
| lh | :) | 18:48 |
| SRabbelier | lh: ^___^, thanks, I will | 18:49 |
| SRabbelier | lh: will do | 18:49 |
| *** SRabbelier has quit IRC | 18:49 | |
| tlarsen | lh: I will cut another Melange official release when issue 182 is fixed. | 18:53 |
| tlarsen | lh: Then, I can quickly cut a new official Google release and get it up on socghop. | 18:53 |
| tlarsen | lh: That bug had appeared in a related form some time ago (with a different selector, I think). I thought it was fixed by now, but it appears to be in a new place. | 18:53 |
| tlarsen | lh: Ah, here it is: http://code.google.com/p/soc/issues/detail?id=160 | 18:54 |
| tpb | <http://ln-s.net/2o4w> (at code.google.com) | 18:54 |
| lh | I also noted it was related to another issue possibly, http://code.google.com/p/soc/issues/detail?id=169 | 18:56 |
| tpb | Title: Issue 169 - soc - Cannot view all of the User list when selecting a backup admin - Google Code (at code.google.com) | 18:56 |
| lh | noted in the issue report. | 18:56 |
| lh | That bug is blocking me doing further testing for now, but I have a start on some stuff I can document. | 18:56 |
| * lh goes to a meeting | 18:56 | |
| tlarsen | lh: We've been promised by the committers that Document will not break. :) | 18:56 |
| lh | tlarsen: that's fine, i still intend to publish FAQs on code.google.com/soc/ for now. | 19:08 |
| tlarsen | lh: OK. | 19:09 |
| * lh goes back to meeting, stops being distracted | 19:09 | |
| tlarsen | lh: We need to get the Club stuff fixed and get a real ToS before we can point people at socghop to play with it anyway. | 19:09 |
| lh | i am working on the tos, stay tuned. as soon as i get blessing from legal, then life is good. | 19:13 |
| * lh goes back to meeting again again | 19:13 | |
| *** tlarsen has quit IRC | 20:13 | |
| *** lh has quit IRC | 20:31 | |
| *** mithro has joined #melange | 22:29 | |
| *** ChanServ sets mode: +v mithro | 22:29 | |
| *** dmitrig01|afk has joined #melange | 22:39 | |
| *** ChanServ sets mode: +v dmitrig01|afk | 22:39 | |
| *** MatthewWilkes has quit IRC | 22:48 | |
| *** johndbritton has joined #melange | 23:06 | |
| *** dmitrig01|afk is now known as dmitrig01 | 23:10 | |
| *** madrazr has joined #melange | 23:13 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!