*** tpb has joined #melange | 00:00 | |
*** dmitrig01|afk is now known as dmitrig01 | 01:45 | |
*** dmitrig01 has quit IRC | 02:11 | |
*** MatthewWilkes has joined #melange | 06:04 | |
*** matthewwilkes_ has joined #melange | 06:27 | |
*** MatthewWilkes has quit IRC | 06:28 | |
*** matthewwilkes_ is now known as MatthewWilkes | 06:28 | |
*** madrazr has joined #melange | 06:28 | |
*** solydzajs has joined #melange | 06:51 | |
*** ChanServ sets mode: +v solydzajs | 06:51 | |
*** madrazr has left #melange | 07:28 | |
*** lyaunzbe has quit IRC | 09:23 | |
*** lyaunzbe has joined #melange | 09:26 | |
*** solydzajs has quit IRC | 10:37 | |
*** solydzajs has joined #melange | 11:00 | |
*** ChanServ sets mode: +v solydzajs | 11:00 | |
*** lyaunzbe is now known as lyaunzbe_afk | 11:20 | |
*** MatthewWilkes has quit IRC | 12:37 | |
*** MatthewWilkes has joined #melange | 13:06 | |
*** MatthewWilkes has quit IRC | 13:14 | |
*** SRabbelier|Uni has joined #melange | 13:33 | |
*** ChanServ sets mode: +v SRabbelier|Uni | 13:33 | |
*** MatthewWilkes has joined #melange | 13:44 | |
*** mrs_spearce has joined #melange | 14:41 | |
*** MatthewWilkes has quit IRC | 15:10 | |
*** solydzajs has quit IRC | 15:36 | |
SRabbelier|Uni | lyaunzbe_afk: I got it to work | 16:05 |
---|---|---|
SRabbelier|Uni | lyaunzbe_afk: just need some CSS expert to finish the job now | 16:05 |
lyaunzbe_afk | Can you send me your changes? | 16:06 |
*** lyaunzbe_afk is now known as lyaunzbe | 16:06 | |
lyaunzbe | I'd really like to see how you fixed it :) | 16:06 |
SRabbelier|Uni | lyaunzbe: ofcourse :) | 16:06 |
SRabbelier|Uni | lyaunzbe: you made a few mistakes here and there, but I was able to finish it from your implementation | 16:08 |
SRabbelier|Uni | lyaunzbe: you saved me a lot of work! | 16:08 |
SRabbelier|Uni | lyaunzbe: committing now | 16:10 |
lyaunzbe | np. Hopefully next time i can provide even more help. | 16:17 |
SRabbelier|Uni | lyaunzbe: well, you know how to debug now! :) | 16:18 |
SRabbelier|Uni | lyaunzbe: what name should I credit you under? | 16:24 |
lyaunzbe | Srabbelier|Uni: Sorry, was away at dinner. Lyaunzbe is fine. | 16:38 |
SRabbelier|Uni | lyaunzbe: real name is better :) | 16:39 |
lyaunzbe | Oh okay. Benjamin Lyaunzon | 16:39 |
SRabbelier|Uni | lyaunzbe: ok | 16:45 |
*** dmitrig01|afk has joined #melange | 16:58 | |
*** ChanServ sets mode: +v dmitrig01|afk | 16:58 | |
*** dmitrig01|afk is now known as dmitrig01 | 17:00 | |
*** dmitrig01 has quit IRC | 17:03 | |
*** dmitrig01|afk has joined #melange | 17:47 | |
*** ChanServ sets mode: +v dmitrig01|afk | 17:47 | |
*** dmitrig01|afk is now known as dmitrig01 | 17:48 | |
*** solydzajs has joined #melange | 19:24 | |
*** ChanServ sets mode: +v solydzajs | 19:24 | |
SRabbelier|Uni | lyaunzbe: you there? | 19:54 |
solydzajs | SRabbelier|Uni: you have outdated nickname ;-) | 19:55 |
solydzajs | SRabbelier|Uni: sleeping at uni today ?:-) | 19:55 |
SRabbelier|Uni | solydzajs: it's so much bother to tell pidgin to use a different nickname | 19:56 |
SRabbelier|Uni | solydzajs: have to edit the config file manually and all | 19:56 |
SRabbelier|Uni | solydzajs: my computer broke down | 19:56 |
SRabbelier|Uni | solydzajs: so I'm forced to use my laptop | 19:56 |
solydzajs | SRabbelier|Uni: that means pidgin sucks :-) | 19:56 |
SRabbelier|Uni | solydzajs: it does | 19:56 |
solydzajs | SRabbelier|Uni: anyway regarding as_table as you know django also uses html code in python code for their implementation of as_table | 19:57 |
SRabbelier|Uni | solydzajs: obviously | 19:59 |
SRabbelier|Uni | solydzajs: but I don't have to read that ugly shit | 19:59 |
SRabbelier|Uni | solydzajs: it was so f'ing difficult to change the code | 19:59 |
SRabbelier|Uni | solydzajs: to add the example_text stuff | 19:59 |
SRabbelier|Uni | and all that was mainly because it was all in one function, and that function was generating html | 19:59 |
solydzajs | SRabbelier|Uni: yep it was my almost all my code, the reason it was hard to read is because django forms implementation is even worst | 20:00 |
solydzajs | SRabbelier|Uni: most of it was copy/pasted from django implementation, which to be honest sucks | 20:01 |
SRabbelier|Uni | solydzajs: aaaaaaah, now it makes sense | 20:01 |
SRabbelier|Uni | solydzajs: yeah, but Django can't use django templates ;) | 20:01 |
solydzajs | SRabbelier|Uni: :-) | 20:01 |
SRabbelier|Uni | solydzajs: do you think current version is better? | 20:02 |
solydzajs | SRabbelier|Uni: they should :D | 20:02 |
SRabbelier|Uni | solydzajs: they'd run into ugly recursion :P | 20:02 |
solydzajs | SRabbelier|Uni: I will review it tomorrow morning but yep it's good, I don't like html code in python code either :-) so I think it will be +1 :-) | 20:02 |
SRabbelier|Uni | solydzajs: awesome | 20:03 |
lyaunzbe | SRabbelier: yes? | 20:04 |
solydzajs | lyaunzbe: could you please sign CLA ? | 20:06 |
solydzajs | lyaunzbe: http://code.google.com/legal/individual-cla-v1.0.html | 20:07 |
tpb | <http://ln-s.net/2ZcG> (at code.google.com) | 20:07 |
solydzajs | lyaunzbe: we need that in order to receive 3rd party patches | 20:07 |
lyaunzbe | sure. My address wont be sent to anyone but google, right? | 20:07 |
solydzajs | lyaunzbe: yes | 20:07 |
SRabbelier|Uni | lyaunzbe: as you can see it's a code.google.com/legal url, we don't even get to see it | 20:11 |
lyaunzbe | SRabbelier: Thats fine. I submitted it. Thanks again for adding me as an author of the patch :) | 20:13 |
lyaunzbe | Really exciting, as it is my first time contributing to anything :D | 20:15 |
SRabbelier|Uni | lyaunzbe: I know, it's awesome right? :D | 20:16 |
lyaunzbe | SRabbelier: Yup. Hopefully its the first of many. | 20:19 |
SRabbelier|Uni | lyaunzbe: that'd be great! :) | 20:19 |
lyaunzbe | One thing. If you guys have time later and its not bothersome, could you change the my last name on the credit to "Lyaunzon" instead of "Lyaunzbe". Thanks in advance. | 20:30 |
SRabbelier|Uni | lyaunzbe: oh dear, I'm sorry for that | 20:31 |
SRabbelier|Uni | lyaunzbe: We can't really change the commit message afaik | 20:32 |
lyaunzbe | Oh, then its okay. | 20:32 |
SRabbelier|Uni | lyaunzbe: will make sure to get it right on your next patch ;) | 20:32 |
*** SRabbelier|Uni has quit IRC | 20:57 | |
*** lyaunzbe is now known as lyaunzbe_afk | 21:06 | |
*** solydzajs has quit IRC | 21:40 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!