| *** tpb <[email protected]> has joined #litex | 00:00 | |
| *** Guest10 <[email protected]> has joined #litex | 00:23 | |
| Guest10 | Hello again _florent_ I implemented the liteeth standalone core on artix7 fpga and when I tried to get the dhcp I ran into issues. When I do dhcp_start, MAC sends in DHCP discover message (should I expect it to send dhcp options 50 with requesting IP address) and receives DHCP Offer back but, when sending the DHCP request the Client IP address will | 00:28 |
|---|---|---|
| Guest10 | be 0.0.0.0 and not the offered IP address. I want to debug this issue and so tried to simulate the RTL in vivado and ran into "FATAL_ERROR: Iteration limit 10000 is reached. Possible zero delay oscillation detected where simulation time can not advance. Please check your source code. Note that the iteration limit can be changed using switch | 00:28 |
| Guest10 | -maxdeltaid." It seems this error is caused by infinite loop but, I couldn't find any. | 00:28 |
| Guest10 | Can you please point on how to simulate the standalone core with DHCP. Thank you in advance. Any help is much appreciated. | 00:28 |
| *** Guest10 <[email protected]> has quit IRC (Quit: Client closed) | 00:48 | |
| *** sakman <[email protected]> has quit IRC (Ping timeout: 246 seconds) | 01:14 | |
| *** sakman <[email protected]> has joined #litex | 01:20 | |
| *** Degi_ <[email protected]> has joined #litex | 02:04 | |
| *** Degi <[email protected]> has quit IRC (Ping timeout: 246 seconds) | 02:04 | |
| *** Degi_ is now known as Degi | 02:04 | |
| *** ewen <[email protected]> has joined #litex | 02:36 | |
| *** pbsds <[email protected]> has quit IRC (Quit: The Lounge - https://thelounge.chat) | 02:42 | |
| *** pbsds <[email protected]> has joined #litex | 02:43 | |
| *** nanoric[m] <nanoric[m]!nanoricmat@2a01:4f8:c012:5b7:0:1:0:ab> has quit IRC (Quit: Idle timeout reached: 172800s) | 03:15 | |
| *** ewen <[email protected]> has quit IRC (Quit: leaving) | 04:27 | |
| *** sakman <[email protected]> has quit IRC (Ping timeout: 260 seconds) | 04:40 | |
| *** sakman <[email protected]> has joined #litex | 04:47 | |
| *** key2 <[email protected]> has quit IRC (Quit: Connection closed for inactivity) | 05:14 | |
| *** FabM <[email protected]> has joined #litex | 06:11 | |
| *** TMM_ <[email protected]> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.) | 07:43 | |
| *** TMM_ <[email protected]> has joined #litex | 07:44 | |
| *** awordnot <awordnot!~awordnot@user/awordnot> has quit IRC (Ping timeout: 252 seconds) | 09:58 | |
| *** RaYmAn <[email protected]> has quit IRC (Ping timeout: 245 seconds) | 11:34 | |
| *** RaYmAn <[email protected]> has joined #litex | 11:49 | |
| *** _alice <[email protected]> has quit IRC (*.net *.split) | 12:05 | |
| *** tcal <[email protected]> has quit IRC (*.net *.split) | 12:05 | |
| *** Xesxen <Xesxen!~cyber@hackalot/deelnemer/xesxen> has quit IRC (*.net *.split) | 12:05 | |
| *** lkcl <[email protected]> has quit IRC (*.net *.split) | 12:05 | |
| *** benh_ <[email protected]> has quit IRC (*.net *.split) | 12:05 | |
| *** sensille <[email protected]> has quit IRC (*.net *.split) | 12:05 | |
| *** Abhishek_ <[email protected]> has quit IRC (*.net *.split) | 12:05 | |
| *** LoveMHz <[email protected]> has quit IRC (*.net *.split) | 12:05 | |
| *** _alice <[email protected]> has joined #litex | 12:05 | |
| *** tcal <[email protected]> has joined #litex | 12:05 | |
| *** lkcl <[email protected]> has joined #litex | 12:05 | |
| *** Xesxen <Xesxen!~cyber@hackalot/deelnemer/xesxen> has joined #litex | 12:05 | |
| *** benh_ <[email protected]> has joined #litex | 12:05 | |
| *** sensille <[email protected]> has joined #litex | 12:05 | |
| *** Abhishek_ <[email protected]> has joined #litex | 12:05 | |
| *** LoveMHz <[email protected]> has joined #litex | 12:05 | |
| *** indy <[email protected]> has quit IRC (Ping timeout: 245 seconds) | 12:57 | |
| *** indy <[email protected]> has joined #litex | 12:57 | |
| *** FabM <FabM!~FabM@armadeus/team/FabM> has quit IRC (Ping timeout: 256 seconds) | 15:29 | |
| *** sakman <[email protected]> has quit IRC (Remote host closed the connection) | 15:59 | |
| *** somlo_ <[email protected]> has joined #litex | 15:59 | |
| *** sakman <[email protected]> has joined #litex | 16:00 | |
| *** somlo <[email protected]> has quit IRC (Remote host closed the connection) | 16:00 | |
| josuah | sorry for this bug I introduced! | 16:10 |
| josuah | should I bundle pull-requests together to void bloating the backlog? | 16:10 |
| *** Guest10 <[email protected]> has joined #litex | 16:44 | |
| *** whitequark[cis] <whitequark[cis]!whitequa_1@2a01:4f8:c012:5b7:0:1:0:4> has joined #litex | 17:37 | |
| whitequark[cis] | in my experience putting more stuff in a single PR makes it harder to merge | 17:37 |
| *** Guest10 <[email protected]> has quit IRC (Ping timeout: 246 seconds) | 17:49 | |
| *** somlo_ is now known as somlo | 17:54 | |
| *** Guest10 <[email protected]> has joined #litex | 17:56 | |
| somlo | re. "structuring PRs", I find this: https://kernelnewbies.org/PatchSeries to be useful advice (where a "patch series" would be equivalent to a PR, and with the added note that a "series" or PR should consist of individual patches (or commits) that are somehow semantically related to each other, i.e. trying to fix the same overall problem or implement the same overall feature) | 17:57 |
| tpb | Title: PatchSeries - Linux Kernel Newbies (at kernelnewbies.org) | 17:57 |
| somlo | IOW, "don't fix multiple unrelated problems in the same PR" :) | 17:57 |
| whitequark[cis] | linux kernel has a fairly different culture but i would broadly speaking consider this good advice | 17:58 |
| somlo | whitequark: IMHO it's less about culture, and more about making it easy for others (but most importantly, one's own self) to figure out what the thinking was behind making a change, no matter how long ago :) | 17:59 |
| *** TMM_ <[email protected]> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.) | 18:16 | |
| *** TMM_ <[email protected]> has joined #litex | 18:21 | |
| *** so-offish <so-offish!~so-offish@2610:148:610:2b10::6> has joined #litex | 18:45 | |
| *** Guest10 <[email protected]> has quit IRC (Ping timeout: 246 seconds) | 19:17 | |
| *** lkcl <[email protected]> has quit IRC (Quit: BNC by #bnc4you) | 19:25 | |
| *** lkcl <[email protected]> has joined #litex | 19:25 | |
| zyp | I agree, but it depends a bit on how large or controversial changes we're talking | 21:42 |
| zyp | if while working one issue, I run into a minor unrelated issue with an obvious fix, I'd be inclined to include a commit fixing that in the same PR | 21:44 |
| zyp | but then we're talking issues small and uncontroversial enough that it should pass straight through a review | 21:45 |
| zyp | if we're talking separate issues that needs separate discussions before merging, those should be separate PRs | 21:45 |
| josuah | somlo: thank you, good advise | 22:15 |
| josuah | s/advise/advice/ (spelled right earlier!) | 22:15 |
| josuah | this sounds about identifying what is the unit of change submission | 22:17 |
| josuah | one PR for one thing to be reviewed | 22:17 |
| * josuah slowly learns how to code | 22:17 | |
| *** awordnot <awordnot!~awordnot@user/awordnot> has joined #litex | 22:52 | |
| *** AndrewD <[email protected]> has joined #litex | 22:53 | |
| *** so-offish <so-offish!~so-offish@2610:148:610:2b10::6> has quit IRC (Ping timeout: 260 seconds) | 23:45 | |
| *** lexano <[email protected]> has quit IRC (Ping timeout: 245 seconds) | 23:55 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!